Skip to content

PHOENIX-6376 Update MetaDataProtocol.java for Phoenix 5.2 - #1157

Closed
yanxinyi wants to merge 2 commits into
apache:masterfrom
yanxinyi:PHOENIX-6376.master
Closed

PHOENIX-6376 Update MetaDataProtocol.java for Phoenix 5.2#1157
yanxinyi wants to merge 2 commits into
apache:masterfrom
yanxinyi:PHOENIX-6376.master

Conversation

@yanxinyi

Copy link
Copy Markdown
Contributor

No description provided.

@stoty

stoty commented Mar 2, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 40sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall15m 33smaster passed
+0hbaserecompile23m 14sHBase recompiled.
+1 💚compile1m 22smaster passed
+1 💚checkstyle0m 47smaster passed
+1 💚javadoc1m 6smaster passed
+0 🆗spotbugs4m 10sphoenix-core in master has 959 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall11m 40sthe patch passed
+0hbaserecompile25m 51sHBase recompiled.
+1 💚compile1m 20sthe patch passed
+1 💚javac1m 20sthe patch passed
-1 ❌checkstyle0m 44sphoenix-core: The patch generated 8 new + 342 unchanged - 4 fixed = 350 total (was 346)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 57sthe patch passed
+1 💚spotbugs3m 58sthe patch passed
_ Other Tests _
-1 ❌unit117m 35sphoenix-core in the patch failed.
+1 💚asflicense0m 43sThe patch does not generate ASF License warnings.
186m 51s
ReasonTests
Failed junit testsphoenix.end2end.BackwardCompatibilityIT
phoenix.end2end.BackwardCompatibilityForSplittableSyscatIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1157/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1157
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux 976f50973d40 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / f7d25b9
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1157/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1157/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1157/1/testReport/
Max. process+thread count11593 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1157/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@yanxinyi

yanxinyi commented Mar 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Finished at: 2021-03-02T06:58:30+00:00[INFO] Final Memory: 23M/450M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.1.1:get (default-cli) on project phoenix-core: Couldn't download artifact: org.eclipse.aether.resolution.DependencyResolutionException: Failure to find org.apache.phoenix:phoenix-client:jar:5.1.0-HBase-2.4 in https://repository.apache.org/content/repositories/releases/ was cached in the local repository, resolution will not be reattempted until the update interval of apache release has elapsed or updates are forced ->

@stoty

stoty commented Mar 8, 2021

Copy link
Copy Markdown
Contributor

This looks like the backward compatibility tests cannot find the artifacts with the new naming scheme.
We either need to add logic for this, or just pull the maven coordinates from the json config file directly.

@yanxinyi

Copy link
Copy Markdown
ContributorAuthor

I created Jira for fixing the backward compatibility tests https://issues.apache.org/jira/browse/PHOENIX-6399

For Now, let's remove the backward compatibility tests for 5.1 and add them back later.

@stoty

stoty commented Mar 9, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 22sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall16m 0smaster passed
+0hbaserecompile22m 33sHBase recompiled.
+1 💚compile1m 2smaster passed
+1 💚checkstyle0m 43smaster passed
+1 💚javadoc0m 51smaster passed
+0 🆗spotbugs3m 5sphoenix-core in master has 959 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall8m 11sthe patch passed
+0hbaserecompile17m 53sHBase recompiled.
+1 💚compile1m 2sthe patch passed
+1 💚javac1m 2sthe patch passed
-1 ❌checkstyle0m 42sphoenix-core: The patch generated 8 new + 342 unchanged - 4 fixed = 350 total (was 346)
+1 💚whitespace0m 1sThe patch has no whitespace issues.
+1 💚javadoc0m 49sthe patch passed
+1 💚spotbugs3m 15sthe patch passed
_ Other Tests _
-1 ❌unit106m 36sphoenix-core in the patch failed.
+1 💚asflicense0m 44sThe patch does not generate ASF License warnings.
164m 42s
ReasonTests
Failed junit testsphoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT
phoenix.end2end.BackwardCompatibilityForSplittableSyscatIT
phoenix.end2end.BackwardCompatibilityIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1157/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1157
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux 2f03087115f2 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / d161867
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1157/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1157/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1157/2/testReport/
Max. process+thread count11273 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1157/2/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@yanxinyi@stoty