Skip to content

PHOENIX-6427 Create sequence fails in lowercase schema - #1182

Closed
stoty wants to merge 2 commits into
apache:masterfrom
stoty:PHOENIX-6427
Closed

PHOENIX-6427 Create sequence fails in lowercase schema#1182
stoty wants to merge 2 commits into
apache:masterfrom
stoty:PHOENIX-6427

Conversation

@stoty

Copy link
Copy Markdown
Contributor

No description provided.


public static ColumnResolver getResolverForSchema(String schema, PhoenixConnection connection) throws SQLException {
return new SchemaResolver(connection, SchemaUtil.normalizeIdentifier(schema), true);
return new SchemaResolver(connection, schema, true);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one. Ship it.

@stoty

Copy link
Copy Markdown
ContributorAuthor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 10sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall15m 49smaster passed
+0hbaserecompile23m 9sHBase recompiled.
+1 💚compile1m 4smaster passed
+1 💚checkstyle0m 45smaster passed
+1 💚javadoc0m 51smaster passed
+0 🆗spotbugs3m 3sphoenix-core in master has 956 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall8m 2sthe patch passed
+0hbaserecompile45m 57sHBase recompiled.
+1 💚compile1m 3sthe patch passed
+1 💚javac1m 3sthe patch passed
-1 ❌checkstyle0m 45sphoenix-core: The patch generated 9 new + 553 unchanged - 10 fixed = 562 total (was 563)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 51sthe patch passed
+1 💚spotbugs3m 16sthe patch passed
_ Other Tests _
+1 💚unit112m 17sphoenix-core in the patch passed.
+1 💚asflicense0m 17sThe patch does not generate ASF License warnings.
196m 44s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1182/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1182
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux 4414b6082061 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 2a2d996
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1182/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1182/2/testReport/
Max. process+thread count9441 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1182/2/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stotystoty closed this Mar 25, 2021
@stoty
stoty deleted the PHOENIX-6427 branch July 29, 2021 14:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@stoty@lhofhansl