Skip to content

Remove server-side dependencies from client code - #1191

Closed
stoty wants to merge 9 commits into
apache:masterfrom
stoty:PHOENIX-6053-2
Closed

Remove server-side dependencies from client code#1191
stoty wants to merge 9 commits into
apache:masterfrom
stoty:PHOENIX-6053-2

Conversation

@stoty

@stotystoty commented Apr 7, 2021

Copy link
Copy Markdown
Contributor

Add phoenix-client-byo-shaded-hbase

Add phoenix-client-byo-shaded-hbase
@stoty
stoty marked this pull request as draft April 7, 2021 05:07
@stoty

stoty commented Apr 7, 2021

Copy link
Copy Markdown
ContributorAuthor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 50sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep5m 15sMaven dependency ordering for branch
+1 💚mvninstall11m 7smaster passed
+0hbaserecompile23m 3sHBase recompiled.
+1 💚compile1m 34smaster passed
+1 💚checkstyle2m 49smaster passed
+1 💚javadoc2m 30smaster passed
+0 🆗spotbugs4m 41sroot in master has 1015 extant spotbugs warnings.
+0 🆗spotbugs3m 5sphoenix-core in master has 956 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall11m 20sthe patch passed
+0hbaserecompile17m 51sHBase recompiled.
+1 💚compile1m 43sthe patch passed
+1 💚javac1m 43sthe patch passed
-1 ❌checkstyle3m 11sroot: The patch generated 239 new + 6354 unchanged - 105 fixed = 6593 total (was 6459)
-1 ❌whitespace0m 0sThe patch has 14 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 ❌whitespace0m 0sThe patch 1 line(s) with tabs.
+1 💚xml0m 3sThe patch has no ill-formed XML file.
+1 💚javadoc2m 42sthe patch passed
+1 💚spotbugs8m 15sthe patch passed
_ Other Tests _
-1 ❌unit114m 46sroot in the patch failed.
-1 ❌asflicense2m 59sThe patch generated 613 ASF License warnings.
200m 8s
ReasonTests
Failed junit testsphoenix.end2end.UpsertSelectIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1191/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1191
Optional Testsdupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle
unameLinux 82af1b36fadb 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 21599ac
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1191/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespacehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1191/1/artifact/yetus-general-check/output/whitespace-eol.txt
whitespacehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1191/1/artifact/yetus-general-check/output/whitespace-tabs.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1191/1/artifact/yetus-general-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1191/1/testReport/
asflicensehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1191/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count10205 (vs. ulimit of 30000)
modulesC: phoenix-core phoenix-client-parent phoenix-client-parent/phoenix-client-byo-shaded-hbase . U: .
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1191/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

stoty commented Apr 8, 2021

Copy link
Copy Markdown
ContributorAuthor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec7m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep5m 31sMaven dependency ordering for branch
+1 💚mvninstall14m 56smaster passed
+0hbaserecompile29m 3sHBase recompiled.
+1 💚compile2m 10smaster passed
+1 💚checkstyle3m 17smaster passed
+1 💚javadoc3m 10smaster passed
+0 🆗spotbugs6m 1sroot in master has 1015 extant spotbugs warnings.
+0 🆗spotbugs4m 2sphoenix-core in master has 956 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for patch
+1 💚mvninstall14m 18sthe patch passed
+0hbaserecompile22m 12sHBase recompiled.
+1 💚compile1m 39sthe patch passed
+1 💚javac1m 39sthe patch passed
-1 ❌checkstyle3m 41sroot: The patch generated 272 new + 6898 unchanged - 145 fixed = 7170 total (was 7043)
-1 ❌whitespace0m 0sThe patch has 14 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 ❌whitespace0m 0sThe patch 1 line(s) with tabs.
+1 💚xml0m 3sThe patch has no ill-formed XML file.
+1 💚javadoc2m 46sthe patch passed
+1 💚spotbugs8m 2sthe patch passed
_ Other Tests _
-1 ❌unit109m 41sroot in the patch failed.
-1 ❌asflicense2m 58sThe patch generated 613 ASF License warnings.
210m 40s
ReasonTests
Failed junit testsphoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1191/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1191
Optional Testsdupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle
unameLinux 0f2ef54b083c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 21599ac
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1191/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespacehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1191/2/artifact/yetus-general-check/output/whitespace-eol.txt
whitespacehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1191/2/artifact/yetus-general-check/output/whitespace-tabs.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1191/2/artifact/yetus-general-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1191/2/testReport/
asflicensehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1191/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count16139 (vs. ulimit of 30000)
modulesC: phoenix-core phoenix-client-parent phoenix-client-parent/phoenix-client-byo-shaded-hbase . U: .
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1191/2/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

stoty commented Jan 2, 2024

Copy link
Copy Markdown
ContributorAuthor

Final version has been committed.

@stotystoty closed this Jan 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@stoty