Skip to content

PHOENIX-6387 Conditional updates on tables with indexes - #1215

Merged
swaroopak merged 4 commits into
apache:PHOENIX-6387-4.xfrom
tkhurana:PHOENIX-6387
May 18, 2021
Merged

PHOENIX-6387 Conditional updates on tables with indexes#1215
swaroopak merged 4 commits into
apache:PHOENIX-6387-4.xfrom
tkhurana:PHOENIX-6387

Conversation

@tkhurana

Copy link
Copy Markdown
Contributor

No description provided.

@tkhuranatkhurana changed the title Phoenix 6387 Conditional updates on tables with indexesPHOENIX-6387 Conditional updates on tables with indexesApr 28, 2021
@tkhurana

Copy link
Copy Markdown
ContributorAuthor

@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 9sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ PHOENIX-6387-4.x Compile Tests _
+1 💚mvninstall15m 1sPHOENIX-6387-4.x passed
+1 💚compile1m 5sPHOENIX-6387-4.x passed
+1 💚checkstyle1m 8sPHOENIX-6387-4.x passed
+1 💚javadoc0m 50sPHOENIX-6387-4.x passed
+0 🆗spotbugs3m 15sphoenix-core in PHOENIX-6387-4.x has 946 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall6m 53sthe patch passed
+1 💚compile1m 3sthe patch passed
+1 💚javac1m 3sthe patch passed
-1 ❌checkstyle1m 13sphoenix-core: The patch generated 178 new + 2655 unchanged - 45 fixed = 2833 total (was 2700)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 46sthe patch passed
-1 ❌spotbugs3m 31sphoenix-core generated 2 new + 944 unchanged - 2 fixed = 946 total (was 946)
_ Other Tests _
+1 💚unit212m 46sphoenix-core in the patch passed.
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
249m 47s
ReasonTests
FindBugsmodule:phoenix-core
Dead store to ts in org.apache.phoenix.hbase.index.IndexRegionObserver.readColumnsFromRow(Put, Set) At IndexRegionObserver.java:org.apache.phoenix.hbase.index.IndexRegionObserver.readColumnsFromRow(Put, Set) At IndexRegionObserver.java:[line 1535]
Switch statement found in org.apache.phoenix.hbase.index.IndexRegionObserver.applyOnePendingDeleteMutation(IndexRegionObserver$BatchMutateContext, Delete) where default case is missing At IndexRegionObserver.java:Delete) where default case is missing At IndexRegionObserver.java:[lines 682-689]
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1215
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux fd923e626890 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionPHOENIX-6387-4.x / c3f166e
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/1/testReport/
Max. process+thread count5390 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Comment threadphoenix-core/src/it/java/org/apache/phoenix/end2end/WALAnnotationIT.java Outdated
@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 43sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ PHOENIX-6387-4.x Compile Tests _
+1 💚mvninstall16m 55sPHOENIX-6387-4.x passed
+1 💚compile1m 17sPHOENIX-6387-4.x passed
+1 💚checkstyle1m 26sPHOENIX-6387-4.x passed
+1 💚javadoc0m 57sPHOENIX-6387-4.x passed
+0 🆗spotbugs3m 38sphoenix-core in PHOENIX-6387-4.x has 946 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall8m 16sthe patch passed
+1 💚compile1m 11sthe patch passed
+1 💚javac1m 11sthe patch passed
-1 ❌checkstyle1m 26sphoenix-core: The patch generated 178 new + 2655 unchanged - 45 fixed = 2833 total (was 2700)
+1 💚whitespace0m 1sThe patch has no whitespace issues.
+1 💚javadoc0m 52sthe patch passed
-1 ❌spotbugs3m 51sphoenix-core generated 2 new + 944 unchanged - 2 fixed = 946 total (was 946)
_ Other Tests _
-1 ❌unit210m 33sphoenix-core in the patch failed.
+1 💚asflicense0m 48sThe patch does not generate ASF License warnings.
256m 8s
ReasonTests
FindBugsmodule:phoenix-core
Dead store to ts in org.apache.phoenix.hbase.index.IndexRegionObserver.readColumnsFromRow(Put, Set) At IndexRegionObserver.java:org.apache.phoenix.hbase.index.IndexRegionObserver.readColumnsFromRow(Put, Set) At IndexRegionObserver.java:[line 1535]
Switch statement found in org.apache.phoenix.hbase.index.IndexRegionObserver.applyOnePendingDeleteMutation(IndexRegionObserver$BatchMutateContext, Delete) where default case is missing At IndexRegionObserver.java:Delete) where default case is missing At IndexRegionObserver.java:[lines 682-689]
Failed junit testsphoenix.end2end.ConcurrentUpsertsWithoutIndexedColsIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1215
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux 19a8296b42fd 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionPHOENIX-6387-4.x / c3f166e
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/2/testReport/
Max. process+thread count5353 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/2/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 10sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ PHOENIX-6387-4.x Compile Tests _
+1 💚mvninstall14m 52sPHOENIX-6387-4.x passed
+1 💚compile1m 12sPHOENIX-6387-4.x passed
+1 💚checkstyle1m 6sPHOENIX-6387-4.x passed
+1 💚javadoc0m 51sPHOENIX-6387-4.x passed
+0 🆗spotbugs3m 32sphoenix-core in PHOENIX-6387-4.x has 946 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall7m 5sthe patch passed
+1 💚compile1m 9sthe patch passed
+1 💚javac1m 9sthe patch passed
-1 ❌checkstyle1m 9sphoenix-core: The patch generated 182 new + 2655 unchanged - 45 fixed = 2837 total (was 2700)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 50sthe patch passed
-1 ❌spotbugs3m 40sphoenix-core generated 1 new + 944 unchanged - 2 fixed = 945 total (was 946)
_ Other Tests _
+1 💚unit216m 27sphoenix-core in the patch passed.
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
254m 9s
ReasonTests
FindBugsmodule:phoenix-core
Switch statement found in org.apache.phoenix.hbase.index.IndexRegionObserver.applyOnePendingDeleteMutation(IndexRegionObserver$BatchMutateContext, Delete) where default case is missing At IndexRegionObserver.java:Delete) where default case is missing At IndexRegionObserver.java:[lines 682-689]
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1215
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux e49400746ebf 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionPHOENIX-6387-4.x / c3f166e
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/3/testReport/
Max. process+thread count4966 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/3/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@gjacoby126gjacoby126 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good -- some questions and comments

Comment threadphoenix-core/src/it/java/org/apache/phoenix/end2end/WALAnnotationIT.java Outdated
@stoty

stoty commented May 7, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec8m 6sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ PHOENIX-6387-4.x Compile Tests _
+1 💚mvninstall16m 41sPHOENIX-6387-4.x passed
+1 💚compile1m 15sPHOENIX-6387-4.x passed
+1 💚checkstyle1m 25sPHOENIX-6387-4.x passed
+1 💚javadoc0m 56sPHOENIX-6387-4.x passed
+0 🆗spotbugs3m 36sphoenix-core in PHOENIX-6387-4.x has 946 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall8m 2sthe patch passed
+1 💚compile1m 13sthe patch passed
+1 💚javac1m 13sthe patch passed
-1 ❌checkstyle1m 20sphoenix-core: The patch generated 162 new + 2674 unchanged - 26 fixed = 2836 total (was 2700)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 51sthe patch passed
-1 ❌spotbugs3m 58sphoenix-core generated 1 new + 944 unchanged - 2 fixed = 945 total (was 946)
_ Other Tests _
-1 ❌unit213m 1sphoenix-core in the patch failed.
+1 💚asflicense0m 46sThe patch does not generate ASF License warnings.
264m 7s
ReasonTests
FindBugsmodule:phoenix-core
Switch statement found in org.apache.phoenix.hbase.index.IndexRegionObserver.applyOnePendingDeleteMutation(IndexRegionObserver$BatchMutateContext, Delete) where default case is missing At IndexRegionObserver.java:Delete) where default case is missing At IndexRegionObserver.java:[lines 682-689]
Failed junit testsphoenix.end2end.ConcurrentUpsertsWithoutIndexedColsIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1215
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux 575e0e203195 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionPHOENIX-6387-4.x / c3f166e
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/4/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/4/testReport/
Max. process+thread count5303 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/4/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@gjacoby126gjacoby126 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks @tkhurana

@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ PHOENIX-6387-4.x Compile Tests _
+1 💚mvninstall14m 11sPHOENIX-6387-4.x passed
+1 💚compile1m 2sPHOENIX-6387-4.x passed
+1 💚checkstyle1m 35sPHOENIX-6387-4.x passed
+1 💚javadoc0m 45sPHOENIX-6387-4.x passed
+0 🆗spotbugs2m 59sphoenix-core in PHOENIX-6387-4.x has 946 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall5m 41sthe patch passed
+1 💚compile1m 1sthe patch passed
+1 💚javac1m 1sthe patch passed
-1 ❌checkstyle1m 36sphoenix-core: The patch generated 162 new + 2674 unchanged - 26 fixed = 2836 total (was 2700)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 46sthe patch passed
-1 ❌spotbugs3m 16sphoenix-core generated 1 new + 944 unchanged - 2 fixed = 945 total (was 946)
_ Other Tests _
+1 💚unit136m 17sphoenix-core in the patch passed.
+1 💚asflicense0m 12sThe patch does not generate ASF License warnings.
170m 54s
ReasonTests
FindBugsmodule:phoenix-core
Switch statement found in org.apache.phoenix.hbase.index.IndexRegionObserver.applyOnePendingDeleteMutation(IndexRegionObserver$BatchMutateContext, Delete) where default case is missing At IndexRegionObserver.java:Delete) where default case is missing At IndexRegionObserver.java:[lines 682-689]
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1215
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux beb729dc5693 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionPHOENIX-6387-4.x / c3f166e
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/5/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/5/testReport/
Max. process+thread count6044 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1215/5/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@swaroopak
swaroopak merged commit 67620b1 into apache:PHOENIX-6387-4.xMay 18, 2021
tkhurana added a commit to tkhurana/phoenix that referenced this pull request Jun 16, 2021
* PHOENIX-6387 Conditional updates on tables with indexes client side
* PHOENIX-6387 Conditional updates on tables with indexes server side
* Remove the extra read For regular upserts on tables with local index
* Addressed review comments
swaroopak pushed a commit that referenced this pull request Jun 16, 2021
* PHOENIX-6387 Conditional updates on tables with indexes (#1215)
* PHOENIX-6387 Conditional updates on tables with indexes client side
* PHOENIX-6387 Conditional updates on tables with indexes server side
* Remove the extra read For regular upserts on tables with local index
* Addressed review comments
* PHOENIX-6474 Client and server metrics for atomic upserts (#1237)
* PHOENIX-6474 Client and server metrics for atomic upserts
* Fixed failing tests related to metrics
tkhurana added a commit to tkhurana/phoenix that referenced this pull request Aug 4, 2021
* PHOENIX-6387 Conditional updates on tables with indexes (apache#1215)
* PHOENIX-6387 Conditional updates on tables with indexes client side
* PHOENIX-6387 Conditional updates on tables with indexes server side
* Remove the extra read For regular upserts on tables with local index
* Addressed review comments
* PHOENIX-6474 Client and server metrics for atomic upserts (apache#1237)
* PHOENIX-6474 Client and server metrics for atomic upserts
* Fixed failing tests related to metrics
jpisaac pushed a commit to jpisaac/phoenix that referenced this pull request Jun 10, 2022
* PHOENIX-6420 Wrong result when conditional and regular upserts are passed in the same commit batch (apache#1183)
* PHOENIX-6420 Wrong result when conditional and regular upserts are passed in the same commit batch
* Addressed feedback
* Added comments, rename variable
* PHOENIX-6387 Conditional updates on tables with indexes (apache#1215)
* PHOENIX-6387 Conditional updates on tables with indexes client side
* PHOENIX-6387 Conditional updates on tables with indexes server side
* Remove the extra read For regular upserts on tables with local index
* Addressed review comments
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tkhurana@stoty@swaroopak@gjacoby126@gokceni