Skip to content

PHOENIX-6474 Client and server metrics for atomic upserts - #1237

Merged
swaroopak merged 2 commits into
apache:PHOENIX-6387-4.xfrom
tkhurana:PHOENIX-6474
Jun 7, 2021
Merged

PHOENIX-6474 Client and server metrics for atomic upserts#1237
swaroopak merged 2 commits into
apache:PHOENIX-6387-4.xfrom
tkhurana:PHOENIX-6474

Conversation

@tkhurana

@tkhuranatkhurana commented May 21, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@tkhurana

tkhurana commented May 21, 2021

Copy link
Copy Markdown
ContributorAuthor

@kadirozde@vmeka2020

@stoty

stoty commented May 21, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 23sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ PHOENIX-6387-4.x Compile Tests _
+1 💚mvninstall14m 13sPHOENIX-6387-4.x passed
+1 💚compile1m 1sPHOENIX-6387-4.x passed
+1 💚checkstyle1m 48sPHOENIX-6387-4.x passed
+1 💚javadoc0m 44sPHOENIX-6387-4.x passed
+0 🆗spotbugs2m 56sphoenix-core in PHOENIX-6387-4.x has 950 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall5m 43sthe patch passed
+1 💚compile1m 1sthe patch passed
+1 💚javac1m 1sthe patch passed
-1 ❌checkstyle1m 50sphoenix-core: The patch generated 102 new + 3215 unchanged - 57 fixed = 3317 total (was 3272)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 43sthe patch passed
+1 💚spotbugs3m 11sthe patch passed
_ Other Tests _
-1 ❌unit224m 46sphoenix-core in the patch failed.
+1 💚asflicense0m 42sThe patch does not generate ASF License warnings.
268m 19s
ReasonTests
Failed junit testsphoenix.monitoring.PhoenixMetricsIT
phoenix.monitoring.PhoenixLoggingMetricsIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1237/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1237
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux a44a252f72db 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionPHOENIX-6387-4.x / 7eba973
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1237/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1237/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1237/1/testReport/
Max. process+thread count5074 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1237/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

stoty commented May 24, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ PHOENIX-6387-4.x Compile Tests _
+1 💚mvninstall14m 39sPHOENIX-6387-4.x passed
+1 💚compile1m 0sPHOENIX-6387-4.x passed
+1 💚checkstyle1m 47sPHOENIX-6387-4.x passed
+1 💚javadoc0m 44sPHOENIX-6387-4.x passed
+0 🆗spotbugs3m 1sphoenix-core in PHOENIX-6387-4.x has 950 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall5m 43sthe patch passed
+1 💚compile1m 0sthe patch passed
+1 💚javac1m 0sthe patch passed
-1 ❌checkstyle1m 50sphoenix-core: The patch generated 102 new + 3215 unchanged - 57 fixed = 3317 total (was 3272)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 45sthe patch passed
+1 💚spotbugs3m 11sthe patch passed
_ Other Tests _
+1 💚unit138m 30sphoenix-core in the patch passed.
+1 💚asflicense0m 12sThe patch does not generate ASF License warnings.
179m 0s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1237/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1237
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux e7b0898f4ee3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionPHOENIX-6387-4.x / 7eba973
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1237/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1237/2/testReport/
Max. process+thread count5621 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1237/2/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

vmeka2020
vmeka2020 approved these changes Jun 7, 2021
View reviewed changes

@vmeka2020vmeka2020 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

swaroopak
swaroopak approved these changes Jun 7, 2021
View reviewed changes

@swaroopakswaroopak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks for the patch @tkhurana

@swaroopak
swaroopak merged commit 50160a0 into apache:PHOENIX-6387-4.xJun 7, 2021
tkhurana added a commit to tkhurana/phoenix that referenced this pull request Jun 16, 2021
@tkhurana
PHOENIX-6474 Client and server metrics for atomic upserts (apache#1237)
4bf8b22
* PHOENIX-6474 Client and server metrics for atomic upserts
* Fixed failing tests related to metrics
swaroopak pushed a commit that referenced this pull request Jun 16, 2021
@tkhurana
PHOENIX-6387: Conditional updates on tables with indexes
68ef271
* PHOENIX-6387 Conditional updates on tables with indexes (#1215)
* PHOENIX-6387 Conditional updates on tables with indexes client side
* PHOENIX-6387 Conditional updates on tables with indexes server side
* Remove the extra read For regular upserts on tables with local index
* Addressed review comments
* PHOENIX-6474 Client and server metrics for atomic upserts (#1237)
* PHOENIX-6474 Client and server metrics for atomic upserts
* Fixed failing tests related to metrics
tkhurana added a commit to tkhurana/phoenix that referenced this pull request Aug 4, 2021
@tkhurana
PHOENIX-6387: Conditional updates on tables with indexes
2b3b787
* PHOENIX-6387 Conditional updates on tables with indexes (apache#1215)
* PHOENIX-6387 Conditional updates on tables with indexes client side
* PHOENIX-6387 Conditional updates on tables with indexes server side
* Remove the extra read For regular upserts on tables with local index
* Addressed review comments
* PHOENIX-6474 Client and server metrics for atomic upserts (apache#1237)
* PHOENIX-6474 Client and server metrics for atomic upserts
* Fixed failing tests related to metrics
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swaroopakswaroopakswaroopak approved these changes
+1 more reviewer
@vmeka2020vmeka2020vmeka2020 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tkhurana@stoty@swaroopak@vmeka2020