Skip to content

PHOENIX-6453 Possible ArrayIndexOutOfBoundsException while preparing …#1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrajeshbabu wants to merge 2 commits into from
Closed

PHOENIX-6453 Possible ArrayIndexOutOfBoundsException while preparing … #1220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb5361d
PHOENIX-6453 Possible ArrayIndexOutOfBoundsException while preparing …
chrajeshbabu May 4, 2021
7b717c7
Handling review comments(Rajeshbabu)
chrajeshbabu May 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions phoenix-core/src/it/java/org/apache/phoenix/end2end/InListIT.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,8 +46,10 @@
import org.apache.phoenix.thirdparty.com.google.common.base.Function;
import org.apache.phoenix.thirdparty.com.google.common.base.Joiner;
import org.apache.phoenix.thirdparty.com.google.common.collect.Lists;
import org.apache.phoenix.util.EnvironmentEdgeManager;
import org.apache.phoenix.util.PhoenixRuntime;
import org.apache.phoenix.util.PropertiesUtil;
import org.apache.phoenix.util.SchemaUtil;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
Expand DownExpand Up@@ -1673,4 +1675,37 @@ public void testBaseTableAndIndexTableHaveRightScan() throws Exception {
.startsWith(ExplainTable.POINT_LOOKUP_ON_STRING));
}
}

@Test
public void testInListExpressionWithVariableLengthColumnsRanges() throws Exception {
Properties props = new Properties();
final String schemaName = generateUniqueName();
final String tableName = generateUniqueName();
final String dataTableFullName = SchemaUtil.getTableName(schemaName, tableName);
String ddl =
"CREATE TABLE " + dataTableFullName + " (a VARCHAR(22) NOT NULL," +
"b CHAR(6) NOT NULL," +
"c VARCHAR(12) NOT NULL,d VARCHAR(200) NOT NULL, " +
"CONSTRAINT PK_TEST_KO PRIMARY KEY (a,b,c,d)) ";
long startTS = EnvironmentEdgeManager.currentTimeMillis();
try (Connection conn = DriverManager.getConnection(getUrl(), props)) {
conn.createStatement().execute(ddl);
conn.commit();
conn.createStatement().execute("upsert into "+ dataTableFullName+
" values('AAAA1234567890','202001','A1','foo')");
conn.createStatement().execute("upsert into "+ dataTableFullName+
" values('AAAA1234567892','202002','A1','foo')");
conn.createStatement().execute("upsert into "+ dataTableFullName+
" values('AAAA1234567892','202002','B1','foo')");
conn.createStatement().execute("upsert into "+ dataTableFullName+
" values('AAAA1234567890','202001','B1','foo')");
conn.commit();
String query = "SELECT count(*) FROM "+dataTableFullName+
" WHERE (a, b) IN (('AAAA1234567890', '202001'), ( 'AAAA1234567892', '202002'))" +
" AND c IN ('A1')";
ResultSet r = conn.createStatement().executeQuery(query);
r.next();
assertEquals(2, r.getInt(1));
}
}
}
4 changes: 3 additions & 1 deletion phoenix-core/src/main/java/org/apache/phoenix/util/ScanUtil.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -363,10 +363,12 @@ private static byte[] getKey(RowKeySchema schema, List<List<KeyRange>> slots, in
}
int[] position = new int[slots.size()];
int maxLength = 0;
int slotEndingFieldPos = -1;
for (int i = 0; i < position.length; i++) {
position[i] = bound == Bound.LOWER ? 0 : slots.get(i).size()-1;
KeyRange range = slots.get(i).get(position[i]);
Field field = schema.getField(i + slotSpan[i]);
slotEndingFieldPos = slotEndingFieldPos + slotSpan[i] + 1;
Field field = schema.getField(slotEndingFieldPos);
int keyLength = range.getRange(bound).length;
if (!field.getDataType().isFixedWidth()) {
keyLength++;
Expand Down