Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6453 Possible ArrayIndexOutOfBoundsException while preparing … - #1220
Closed
chrajeshbabu wants to merge 2 commits into
Closed
PHOENIX-6453 Possible ArrayIndexOutOfBoundsException while preparing …#1220chrajeshbabu wants to merge 2 commits into
chrajeshbabu wants to merge 2 commits into
Conversation
…scan start key with multiple key range queries(Rajeshbabu)
chrajeshbabu
requested review from
gjacoby126, joshelser, kadirozde, lhofhansl and stotyMay 4, 2021 08:21
stoty
commented
May 4, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
suggested changes
May 13, 2021
stoty
left a comment
Contributor
There was a problem hiding this comment.
The logic looks good, but I feel it could be made easier to read.
| position[i] = bound == Bound.LOWER ? 0 : slots.get(i).size()-1; | ||
| KeyRange range = slots.get(i).get(position[i]); | ||
| Field field = schema.getField(i + slotSpan[i]); | ||
| slotEndingFieldPos = slotEndingFieldPos + slotSpan[i] + (i>0? 1: 0); |
Contributor
There was a problem hiding this comment.
nit:
This is quite confusing : + (i>0? 1: 0); .
Can we increment slotEndingFieldPos at the end of the for cycle body instead?
Or just initialize slotEndingFieldPos to -1 , and increment it here unconditionally ?
stoty
commented
May 25, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
joshelser
approved these changes
May 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…scan start key with multiple key range queries(Rajeshbabu)
The field position preparation logic from the slot spans is wrong so when there are mix of fixed length and variable length columns in different in lists scan key length coming wrong so getting AIOOB exception.