Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6454: Add feature to SchemaTool to get the DDL in specificati… - #1233
Merged
Conversation
stoty
commented
May 14, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
May 18, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
gjacoby126
requested changes
May 18, 2021
| private void runAndVerify(String expected, String baseDDL) throws Exception { | ||
| String[] arg = { "-m", "SYNTH", "-d", baseDDL }; | ||
| String result = runSchemaTool(null, arg); | ||
| System.out.println(result); |
| .getFirst())); | ||
| pkList.add(cd); | ||
| } | ||
| for(ColumnDef cd : addStmt.getColumnDefs()) { |
Contributor
There was a problem hiding this comment.
What if the ALTER tries to add an existing PK column?
ContributorAuthor
There was a problem hiding this comment.
That's a valid point, I am thinking to create a new Jira which will validate if the statements are valid on the mini-cluster (as parsing won't catch this and similar problem) and then only proceed for synthesis. Does that sound okay?
stoty
commented
Jun 10, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
gjacoby126
approved these changes
Jun 10, 2021
swaroopak added a commit
that referenced
this pull request
Jun 14, 2021
richardantal pushed a commit
to richardantal/phoenix-1
that referenced
this pull request
Jul 22, 2021
richardantal pushed a commit
to richardantal/phoenix-1
that referenced
this pull request
Jul 22, 2021
richardantal pushed a commit
that referenced
this pull request
Jul 29, 2021
richardantal pushed a commit
that referenced
this pull request
Jul 29, 2021
jpisaac pushed a commit
to jpisaac/phoenix
that referenced
this pull request
Jun 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on mode (Addendum)