Skip to content

PHOENIX-5650: IndexUpgradeTool does not rebuild view indexes - #665

Closed
swaroopak wants to merge 1 commit into
apache:4.x-HBase-1.3from
swaroopak:PHOENIX-5650
Closed

PHOENIX-5650: IndexUpgradeTool does not rebuild view indexes#665
swaroopak wants to merge 1 commit into
apache:4.x-HBase-1.3from
swaroopak:PHOENIX-5650

Conversation

@swaroopak

@swaroopakswaroopak commented Dec 25, 2019

Copy link
Copy Markdown
Contributor

No description provided.

yanxinyi
yanxinyi reviewed Dec 26, 2019
View reviewed changes
Comment threadphoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java Outdated
@yanxinyi

yanxinyi commented Dec 26, 2019

Copy link
Copy Markdown
Contributor

overall looks great! Just two small nits from my perspective. Thank you for the patch and happy holiday!

gjacoby126
gjacoby126 requested changes Jan 3, 2020
View reviewed changes
Comment threadphoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java Outdated
Comment threadphoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java
gjacoby126
gjacoby126 approved these changes Jan 6, 2020
View reviewed changes

@gjacoby126gjacoby126 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. But longer term, the view and view index SQL methods should really live in a metadata library somewhere

Comment threadphoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java Outdated
priyankporwal
priyankporwal suggested changes Jan 6, 2020
View reviewed changes
Comment threadphoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java Outdated
Comment threadphoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java Outdated
Comment threadphoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java Outdated
priyankporwal
priyankporwal reviewed Jan 6, 2020
View reviewed changes
Comment threadphoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java Outdated
jpisaac pushed a commit to jpisaac/phoenix that referenced this pull request Jun 10, 2022
Swaroopa KadamGitHub Enterprise
PHOENIX-6454: Add feature to SchemaTool to get the DDL in specificati…
7b45b09
…on (Addendum) (apache#1233) (apache#665)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanxinyiyanxinyiyanxinyi left review comments
@gjacoby126gjacoby126gjacoby126 approved these changes
@kadirozdekadirozdeAwaiting requested review from kadirozde
+1 more reviewer
@priyankporwalpriyankporwalpriyankporwal approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swaroopak@yanxinyi@gjacoby126@priyankporwal