Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6476 Index tool when verifying from index to data doesn't correctly split page into tasks - #1240
Merged
Merged
Conversation
…rectly split page into tasks
ContributorAuthor
stoty
commented
May 26, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
May 27, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
gokceni
reviewed
May 27, 2021
| byte[] dataRowKey = indexMaintainer.buildDataRowKey(new ImmutableBytesWritable(indexRowKey), viewConstants); | ||
| for (int i = 0; i < dataRowKeysSetList.size(); ++i) { | ||
| if (dataRowKeysSetList.get(i).contains(dataRowKey)) { | ||
| mapList.get(i).put(indexRowKey, actualMutationList); |
ContributorAuthor
There was a problem hiding this comment.
Yes, that would avoid unnecessary lookups.
gokceni
approved these changes
May 27, 2021
tkhurana added a commit
to tkhurana/phoenix
that referenced
this pull request
Jun 16, 2021
…rectly split page into tasks (apache#1240) * PHOENIX-6476 Index tool when verifying from index to data doesn't correctly split page into tasks * Fix failing tests, add comments * Break early when the matching set is found
swaroopak pushed a commit
that referenced
this pull request
Jun 16, 2021
…rectly split page into tasks (#1240) (#1248) * PHOENIX-6476 Index tool when verifying from index to data doesn't correctly split page into tasks * Fix failing tests, add comments * Break early when the matching set is found
virajjasani pushed a commit
that referenced
this pull request
Jul 23, 2021
…rectly split page into tasks (#1240) (#1248) * PHOENIX-6476 Index tool when verifying from index to data doesn't correctly split page into tasks * Fix failing tests, add comments * Break early when the matching set is found
jpisaac pushed a commit
to jpisaac/phoenix
that referenced
this pull request
Jun 10, 2022
* PHOENIX-6476 Index tool when verifying from index to data doesn't correctly split page into tasks (apache#1240) * PHOENIX-6476 Index tool when verifying from index to data doesn't correctly split page into tasks * Fix failing tests, add comments * Break early when the matching set is found * Fix import usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When verifying from index table to data table, there were 2 issues: