Skip to content

PHOENIX-6476 Index tool when verifying from index to data doesn't cor… - #1248

Merged
swaroopak merged 1 commit into
apache:masterfrom
tkhurana:PHOENIX-6476-master
Jun 16, 2021
Merged

PHOENIX-6476 Index tool when verifying from index to data doesn't cor…#1248
swaroopak merged 1 commit into
apache:masterfrom
tkhurana:PHOENIX-6476-master

Conversation

@tkhurana

Copy link
Copy Markdown
Contributor

…rectly split page into tasks (#1240)

  • PHOENIX-6476 Index tool when verifying from index to data doesn't correctly split page into tasks

  • Fix failing tests, add comments

  • Break early when the matching set is found

…rectly split page into tasks (apache#1240)
* PHOENIX-6476 Index tool when verifying from index to data doesn't correctly split page into tasks
* Fix failing tests, add comments
* Break early when the matching set is found
@tkhurana

Copy link
Copy Markdown
ContributorAuthor

@swaroopak cherry-pick to master

@swaroopak
swaroopak merged commit 8b81579 into apache:masterJun 16, 2021
@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 8sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 ❌mvninstall17m 21sroot in master failed.
+0hbaserecompile24m 47sHBase recompiled.
+1 💚compile1m 5smaster passed
+1 💚checkstyle0m 33smaster passed
+1 💚javadoc0m 53smaster passed
+0 🆗spotbugs3m 21sphoenix-core in master has 965 extant spotbugs warnings.
_ Patch Compile Tests _
-1 ❌mvninstall9m 38sroot in the patch failed.
+0hbaserecompile19m 59sHBase recompiled.
+1 💚compile1m 3sthe patch passed
+1 💚javac1m 3sthe patch passed
-1 ❌checkstyle0m 34sphoenix-core: The patch generated 12 new + 126 unchanged - 2 fixed = 138 total (was 128)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 50sthe patch passed
+1 💚spotbugs3m 32sthe patch passed
_ Other Tests _
-1 ❌unit114m 58sphoenix-core in the patch failed.
+1 💚asflicense0m 35sThe patch does not generate ASF License warnings.
172m 53s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1248/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1248
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux 998cc1b94b45 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / b6d9338
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstallhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1248/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
mvninstallhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1248/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1248/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1248/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1248/1/testReport/
Max. process+thread count11416 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1248/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani pushed a commit that referenced this pull request Jul 23, 2021
…rectly split page into tasks (#1240) (#1248)
* PHOENIX-6476 Index tool when verifying from index to data doesn't correctly split page into tasks
* Fix failing tests, add comments
* Break early when the matching set is found
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tkhurana@stoty@swaroopak