Phoenix 6454 4.16

[richardantal]

clean cherry-pick from 4.x

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ 4.16 Compile Tests _
+0 🆗	mvndep	5m 31s	Maven dependency ordering for branch
+1 💚	mvninstall	13m 39s	4.16 passed
+1 💚	compile	1m 32s	4.16 passed
+1 💚	checkstyle	0m 49s	4.16 passed
+1 💚	javadoc	0m 57s	4.16 passed
+0 🆗	spotbugs	3m 0s	phoenix-core in 4.16 has 941 extant spotbugs warnings.
+0 🆗	spotbugs	0m 44s	phoenix-tools in 4.16 has 3 extant spotbugs warnings.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	10m 2s	the patch passed
+1 💚	compile	1m 32s	the patch passed
+1 💚	javac	1m 32s	the patch passed
-1 ❌	checkstyle	0m 33s	phoenix-core: The patch generated 41 new + 208 unchanged - 7 fixed = 249 total (was 215)
-1 ❌	checkstyle	0m 19s	phoenix-tools: The patch generated 198 new + 222 unchanged - 41 fixed = 420 total (was 263)
-1 ❌	whitespace	0m 0s	The patch 2 line(s) with tabs.
+1 💚	javadoc	0m 56s	the patch passed
-1 ❌	spotbugs	1m 0s	phoenix-tools generated 5 new + 0 unchanged - 3 fixed = 5 total (was 3)
		_ Other Tests _
+1 💚	unit	196m 26s	phoenix-core in the patch passed.
-1 ❌	unit	3m 57s	phoenix-tools in the patch failed.
+1 💚	asflicense	0m 18s	The patch does not generate ASF License warnings.
		247m 12s

Reason	Tests
FindBugs	module:phoenix-tools
	Found reliance on default encoding in org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String):in org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String): new java.io.FileReader(File) At SchemaSynthesisProcessor.java:[line 210]
	org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String) may fail to close stream At SchemaSynthesisProcessor.java:stream At SchemaSynthesisProcessor.java:[line 210]
	org.apache.phoenix.schema.SchemaTool.conf should be package protected In SchemaTool.java: In SchemaTool.java
	Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.SchemaTool.parseOptions(String[]) Dereferenced at SchemaTool.java:cmdLine in org.apache.phoenix.schema.SchemaTool.parseOptions(String[]) Dereferenced at SchemaTool.java:[line 114]
	Write to static field org.apache.phoenix.schema.SchemaTool.conf from instance method org.apache.phoenix.schema.SchemaTool.run(String[]) At SchemaTool.java:from instance method org.apache.phoenix.schema.SchemaTool.run(String[]) At SchemaTool.java:[line 73]

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1273/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1273
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux ad05270f029c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.16 / 6b29b1d
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1273/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1273/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt
whitespace	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1273/1/artifact/yetus-general-check/output/whitespace-tabs.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1273/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-tools.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1273/1/artifact/yetus-general-check/output/patch-unit-phoenix-tools.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1273/1/testReport/
Max. process+thread count	4923 (vs. ulimit of 30000)
modules	C: phoenix-core phoenix-tools U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1273/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[richardantal]

Committing since it was a clean backport and the tests are OK.