Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-5259 Phoenix Salted Table Secondary Indexes Come Salted - #589
Open
yanxinyi wants to merge 1 commit into
Open
PHOENIX-5259 Phoenix Salted Table Secondary Indexes Come Salted#589yanxinyi wants to merge 1 commit into
yanxinyi wants to merge 1 commit into
Conversation
yanxinyi
commented
Oct 2, 2019
ContributorAuthor
Since the index not longer follows the salted base table, this might change the behavior of the index table. @gjacoby126@ChinmaySKulkarni@kadirozde please take a look if this is expected behavior to remove this inheritance, thanks. cc @dbwong |
| @@ -2069,7 +2069,7 @@ private PTable createTableInternal(CreateTableStatement statement, byte[][] spli | |||
| } | |||
| // Salt the index table if the data table is salted | |||
Contributor
There was a problem hiding this comment.
nit: please update the comment to reflect the change.
| super(isNamespaceMapped); | ||
| } | ||
| private String createTable = "CREATE TABLE %s (ID INTEGER NOT NULL PRIMARY KEY, " + |
stoty
commented
Feb 16, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.