Skip to content

PHOENIX-6220 CREATE INDEX shouldn't ignore IMMUTABLE_STORAGE_SCHEME a… - #963

Closed
gokceni wants to merge 1 commit into
apache:4.x-PHOENIX-5923from
gokceni:PHOENIX-6220
Closed

PHOENIX-6220 CREATE INDEX shouldn't ignore IMMUTABLE_STORAGE_SCHEME a…#963
gokceni wants to merge 1 commit into
apache:4.x-PHOENIX-5923from
gokceni:PHOENIX-6220

Conversation

@gokceni

@gokcenigokceni commented Nov 12, 2020

Copy link
Copy Markdown
Contributor

…nd COLUMN_ENDCODED_BYTES

@gokceni

gokceni commented Nov 12, 2020

Copy link
Copy Markdown
ContributorAuthor

@kadirozde@priyankporwal@swaroopak@tkhurana

@stoty

stoty commented Nov 12, 2020

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 42sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x-PHOENIX-5923 Compile Tests _
+1 💚mvninstall10m 54s4.x-PHOENIX-5923 passed
+1 💚compile0m 55s4.x-PHOENIX-5923 passed
+1 💚checkstyle1m 41s4.x-PHOENIX-5923 passed
+1 💚javadoc0m 44s4.x-PHOENIX-5923 passed
+0 🆗spotbugs2m 58sphoenix-core in 4.x-PHOENIX-5923 has 946 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall5m 25sthe patch passed
+1 💚compile0m 56sthe patch passed
+1 💚javac0m 56sthe patch passed
-1 ❌checkstyle1m 41sphoenix-core: The patch generated 45 new + 2812 unchanged - 16 fixed = 2857 total (was 2828)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 42sthe patch passed
+1 💚spotbugs3m 1sthe patch passed
_ Other Tests _
-1 ❌unit130m 11sphoenix-core in the patch failed.
+1 💚asflicense0m 38sThe patch does not generate ASF License warnings.
168m 9s
ReasonTests
Failed junit testsphoenix.end2end.IndexToolIT
phoenix.end2end.StatsEnabledSplitSystemCatalogIT
phoenix.tx.TransactionIT
phoenix.end2end.ParameterizedIndexUpgradeToolIT
phoenix.end2end.ViewMetadataIT
phoenix.end2end.index.txn.RollbackIT
phoenix.execute.PartialCommitIT
phoenix.rpc.UpdateCacheIT
phoenix.end2end.index.txn.TxWriteFailureIT
phoenix.end2end.TransactionalViewIT
phoenix.tx.FlappingTransactionIT
phoenix.end2end.index.txn.MutableRollbackIT
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#963
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux a3b14b793693 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revision4.x-PHOENIX-5923 / c9c80b2
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/1/testReport/
Max. process+thread count7018 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

stoty commented Nov 12, 2020

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 8sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x-PHOENIX-5923 Compile Tests _
+1 💚mvninstall10m 54s4.x-PHOENIX-5923 passed
+1 💚compile0m 53s4.x-PHOENIX-5923 passed
+1 💚checkstyle1m 41s4.x-PHOENIX-5923 passed
+1 💚javadoc0m 42s4.x-PHOENIX-5923 passed
+0 🆗spotbugs2m 57sphoenix-core in 4.x-PHOENIX-5923 has 946 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall5m 14sthe patch passed
+1 💚compile0m 57sthe patch passed
+1 💚javac0m 57sthe patch passed
-1 ❌checkstyle1m 41sphoenix-core: The patch generated 45 new + 2812 unchanged - 16 fixed = 2857 total (was 2828)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 44sthe patch passed
+1 💚spotbugs3m 3sthe patch passed
_ Other Tests _
-1 ❌unit193m 52sphoenix-core in the patch failed.
+1 💚asflicense0m 35sThe patch does not generate ASF License warnings.
227m 7s
ReasonTests
Failed junit testsphoenix.end2end.index.GlobalIndexCheckerIT
phoenix.end2end.AlterTableWithViewsIT
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#963
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux fc24078036d6 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revision4.x-PHOENIX-5923 / c9c80b2
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/2/testReport/
Max. process+thread count6254 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/2/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

swaroopak
swaroopak reviewed Nov 13, 2020
View reviewed changes
Comment threadphoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java Outdated
swaroopak
swaroopak reviewed Nov 13, 2020
View reviewed changes
Comment threadphoenix-core/src/it/java/org/apache/phoenix/end2end/CreateTableIT.java Outdated
swaroopak
swaroopak reviewed Nov 13, 2020
View reviewed changes

@swaroopakswaroopak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, Rest LGTM

@stoty

stoty commented Nov 14, 2020

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 8sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x-PHOENIX-5923 Compile Tests _
+1 💚mvninstall10m 33s4.x-PHOENIX-5923 passed
+1 💚compile0m 55s4.x-PHOENIX-5923 passed
+1 💚checkstyle1m 40s4.x-PHOENIX-5923 passed
+1 💚javadoc0m 44s4.x-PHOENIX-5923 passed
+0 🆗spotbugs2m 52sphoenix-core in 4.x-PHOENIX-5923 has 946 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall5m 11sthe patch passed
+1 💚compile0m 55sthe patch passed
+1 💚javac0m 55sthe patch passed
-1 ❌checkstyle1m 38sphoenix-core: The patch generated 45 new + 2812 unchanged - 16 fixed = 2857 total (was 2828)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 44sthe patch passed
+1 💚spotbugs3m 3sthe patch passed
_ Other Tests _
-1 ❌unit183m 48sphoenix-core in the patch failed.
+1 💚asflicense0m 38sThe patch does not generate ASF License warnings.
216m 30s
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#963
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux 72bd70d9c93a 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revision4.x-PHOENIX-5923 / c9c80b2
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/3/testReport/
Max. process+thread count6124 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/3/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

gjacoby126
gjacoby126 approved these changes Nov 16, 2020
View reviewed changes

@gjacoby126gjacoby126 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, @gokceni , just please give GlobalMutableTxIndexIT a local run because it looks like it crashed during the last test run. Probably just a CI glitch, but it's related to this change so good to be sure.

@gokceni

gokceni commented Nov 16, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks @gjacoby126 , I did a local run and it completed successfully.

swaroopak
swaroopak approved these changes Nov 16, 2020
View reviewed changes

@swaroopakswaroopak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch and for addressing comments

@gokceni

gokceni commented Nov 17, 2020

Copy link
Copy Markdown
ContributorAuthor

Merged

@gokcenigokceni closed this Nov 17, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swaroopakswaroopakswaroopak approved these changes
@gjacoby126gjacoby126gjacoby126 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gokceni@stoty@swaroopak@gjacoby126