Skip to content

RATIS-1847. Stream has memory leak. - #884

Merged
szetszwo merged 2 commits into
apache:masterfrom
szetszwo:RATIS-1847
Jun 19, 2023
Merged

RATIS-1847. Stream has memory leak.#884
szetszwo merged 2 commits into
apache:masterfrom
szetszwo:RATIS-1847

Conversation

@szetszwo

@szetszwoszetszwo commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

@szetszwo

szetszwo commented Jun 7, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@guohao-rosicky , could you test if this could fix this memory leak and also the cleanup problem?

@guohao-rosicky

guohao-rosicky commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

@guohao-rosicky , could you test if this could fix this memory leak and also the cleanup problem?

sure.

@guohao-rosicky

guohao-rosicky commented Jun 8, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

hi, @szetszwo

By looking at the LEAK log, I'm not sure if the leak was caused by calling ByteBuf::retain here and not calling ByteBuf::release twice.

see:
https://github.com/apache/ratis/blob/master/ratis-netty/src/main/java/org/apache/ratis/netty/NettyDataStreamUtils.java#L139

 static DataStreamRequestByteBuf decodeDataStreamRequestByteBuf(ByteBuf buf) {
return Optional.ofNullable(decodeDataStreamRequestHeader(buf))
.map(header -> checkHeader(header, buf))
.map(header -> new DataStreamRequestByteBuf(header, decodeData(buf, header, ByteBuf::retain)))
.orElse(null);
}

leak log:

ERROR org.apache.ratis.thirdparty.io.netty.util.ResourceLeakDetector: LEAK: ByteBuf.release() was not called before it's garbage-collected. See https://netty.io/wiki/reference-counted-objects.html for more information.
Recent access records: #2:
org.apache.ratis.netty.NettyDataStreamUtils.decodeData(NettyDataStreamUtils.java:249)
org.apache.ratis.netty.NettyDataStreamUtils.lambda$decodeDataStreamRequestByteBuf$1(NettyDataStreamUtils.java:140)
java.util.Optional.map(Optional.java:215)
org.apache.ratis.netty.NettyDataStreamUtils.decodeDataStreamRequestByteBuf(NettyDataStreamUtils.java:140)
org.apache.ratis.netty.server.NettyServerStreamRpc$3.decode(NettyServerStreamRpc.java:289)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:510)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:449)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:279)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
org.apache.ratis.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
org.apache.ratis.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
org.apache.ratis.thirdparty.io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:722)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:658)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:584)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:496)
org.apache.ratis.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:995)
org.apache.ratis.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
java.lang.Thread.run(Thread.java:748)

@szetszwo

szetszwo commented Jun 9, 2023

Copy link
Copy Markdown
ContributorAuthor

By looking at the LEAK log, ...

Do you mean the new LEAK log after applied this change?

... I'm not sure if the leak was caused by calling ByteBuf::retain here and not calling ByteBuf::release twice.

Calling ByteBuf::release twice seems incorrect. The second call should triggered an exception.

@guohao-rosicky

guohao-rosicky commented Jun 14, 2023

Copy link
Copy Markdown
Contributor

hi, @szetszwo. I have committed the code related to stream cleanup on ozone datanode, I have made some changes please help me to review it, thanks.
see:
apache/ozone#4891

@szetszwo

szetszwo commented Jun 19, 2023

Copy link
Copy Markdown
ContributorAuthor

@guohao-rosicky , how is your testing going?

@guohao-rosicky

guohao-rosicky commented Jun 19, 2023

Copy link
Copy Markdown
Contributor

@guohao-rosicky , how is your testing going?
hi, @szetszwo .
I feel that this change is valid and can be merged.
When this pr is merged, the I will submit a pr later to cleanup when the server side #channelInactive.

@szetszwo
szetszwo requested a review from adoroszlaiJune 19, 2023 09:38
adoroszlai
adoroszlai approved these changes Jun 19, 2023
View reviewed changes

@adoroszlaiadoroszlai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @szetszwo for the patch. I'm not familiar with Ratis streaming, but the change itself looks good.

@szetszwo
szetszwo merged commit b49a793 into apache:masterJun 19, 2023
@szetszwo

szetszwo commented Jun 19, 2023

Copy link
Copy Markdown
ContributorAuthor

@guohao-rosicky , thanks a lot for testing this!

@adoroszlai , thanks a lot for reviewing this!

@guohao-rosicky

guohao-rosicky commented Jun 20, 2023

Copy link
Copy Markdown
Contributor

On top of this pr I added some processing, @szetszwo PTAL, thanks.
see:
#887

symious pushed a commit to symious/ratis that referenced this pull request Mar 19, 2024
@szetszwo@symious
RATIS-1847. Stream has memory leak. (apache#884)
253a57f
@SteNicholasSteNicholas mentioned this pull request Apr 24, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guohao-rosickyguohao-rosickyguohao-rosicky left review comments
@adoroszlaiadoroszlaiadoroszlai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@szetszwo@guohao-rosicky@adoroszlai
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
RATIS-1847. Stream has memory leak. by szetszwo · Pull Request #884 · apache/ratis · GitHub
Skip to content
RATIS-1847. Stream has memory leak. - #884
Merged
szetszwo merged 2 commits into
apache:masterfrom 
szetszwo:RATIS-1847
Jun 19, 2023
Merged
RATIS-1847. Stream has memory leak.#884
szetszwo merged 2 commits into
apache:masterfrom 
szetszwo:RATIS-1847
Conversation
@szetszwo
@szetszwoszetszwo
commented
Jun 7, 2023

Copy link


Copy Markdown

Contributor
@szetszwo
szetszwo
commented
Jun 7, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@guohao-rosicky , could you test if this could fix this memory leak and also the cleanup problem?
@guohao-rosicky
guohao-rosicky
commented
Jun 7, 2023

Copy link


Copy Markdown

Contributor
@guohao-rosicky , could you test if this could fix this memory leak and also the cleanup problem?
sure.
@guohao-rosicky
guohao-rosicky
commented
Jun 8, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
hi, @szetszwo
By looking at the LEAK log, I'm not sure if the leak was caused by calling ByteBuf::retain here and not calling ByteBuf::release twice.
see:
https://github.com/apache/ratis/blob/master/ratis-netty/src/main/java/org/apache/ratis/netty/NettyDataStreamUtils.java#L139
 static DataStreamRequestByteBuf decodeDataStreamRequestByteBuf(ByteBuf buf) {
return Optional.ofNullable(decodeDataStreamRequestHeader(buf))
.map(header -> checkHeader(header, buf))
.map(header -> new DataStreamRequestByteBuf(header, decodeData(buf, header, ByteBuf::retain)))
.orElse(null);
}

leak log:
ERROR org.apache.ratis.thirdparty.io.netty.util.ResourceLeakDetector: LEAK: ByteBuf.release() was not called before it's garbage-collected. See https://netty.io/wiki/reference-counted-objects.html for more information.
Recent access records: #2:
org.apache.ratis.netty.NettyDataStreamUtils.decodeData(NettyDataStreamUtils.java:249)
org.apache.ratis.netty.NettyDataStreamUtils.lambda$decodeDataStreamRequestByteBuf$1(NettyDataStreamUtils.java:140)
java.util.Optional.map(Optional.java:215)
org.apache.ratis.netty.NettyDataStreamUtils.decodeDataStreamRequestByteBuf(NettyDataStreamUtils.java:140)
org.apache.ratis.netty.server.NettyServerStreamRpc$3.decode(NettyServerStreamRpc.java:289)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:510)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:449)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:279)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
org.apache.ratis.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
org.apache.ratis.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
org.apache.ratis.thirdparty.io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:722)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:658)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:584)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:496)
org.apache.ratis.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:995)
org.apache.ratis.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
java.lang.Thread.run(Thread.java:748)

@szetszwo
szetszwo
commented
Jun 9, 2023

Copy link


Copy Markdown

ContributorAuthor
By looking at the LEAK log, ...
Do you mean the new LEAK log after applied this change?
... I'm not sure if the leak was caused by calling ByteBuf::retain here and not calling ByteBuf::release twice.
Calling ByteBuf::release twice seems incorrect. The second call should triggered an exception.
@guohao-rosicky
guohao-rosicky
commented
Jun 14, 2023

Copy link


Copy Markdown

Contributor
hi, @szetszwo. I have committed the code related to stream cleanup on ozone datanode, I have made some changes please help me to review it, thanks.

see:
apache/ozone#4891
@szetszwo
szetszwo
commented
Jun 19, 2023

Copy link


Copy Markdown

ContributorAuthor
@guohao-rosicky , how is your testing going?
@guohao-rosicky
guohao-rosicky
commented
Jun 19, 2023

Copy link


Copy Markdown

Contributor
@guohao-rosicky , how is your testing going?

hi, @szetszwo .

I feel that this change is valid and can be merged.

When this pr is merged, the I will submit a pr later to cleanup when the server side #channelInactive.
@szetszwo
szetszwo
requested a review
from adoroszlaiJune 19, 2023 09:38
adoroszlai
adoroszlai
approved these changes
Jun 19, 2023
View reviewed changes
@adoroszlaiadoroszlai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @szetszwo for the patch. I'm not familiar with Ratis streaming, but the change itself looks good.
@szetszwo
szetszwo
merged commit b49a793
into
apache:masterJun 19, 2023
@szetszwo
szetszwo
commented
Jun 19, 2023

Copy link


Copy Markdown

ContributorAuthor
@guohao-rosicky , thanks a lot for testing this!
@adoroszlai , thanks a lot for reviewing this!
@guohao-rosicky
guohao-rosicky
commented
Jun 20, 2023

Copy link


Copy Markdown

Contributor
On top of this pr I added some processing, @szetszwo PTAL, thanks.

see:
#887
symious pushed a commit
to symious/ratis
that referenced
this pull request
Mar 19, 2024
@szetszwo@symious
RATIS-1847. Stream has memory leak. (apache#884)
253a57f
@SteNicholasSteNicholas
mentioned this pull request
Apr 24, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@guohao-rosickyguohao-rosickyguohao-rosicky left review comments
@adoroszlaiadoroszlaiadoroszlai approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@szetszwo@guohao-rosicky@adoroszlai

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
RATIS-1847. Stream has memory leak. by szetszwo · Pull Request #884 · apache/ratis · GitHub
Skip to content
RATIS-1847. Stream has memory leak. - #884
Merged
szetszwo merged 2 commits into
apache:masterfrom 
szetszwo:RATIS-1847
Jun 19, 2023
Merged
RATIS-1847. Stream has memory leak.#884
szetszwo merged 2 commits into
apache:masterfrom 
szetszwo:RATIS-1847
Conversation
@szetszwo
@szetszwoszetszwo
commented
Jun 7, 2023

Copy link


Copy Markdown

Contributor
@szetszwo
szetszwo
commented
Jun 7, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@guohao-rosicky , could you test if this could fix this memory leak and also the cleanup problem?
@guohao-rosicky
guohao-rosicky
commented
Jun 7, 2023

Copy link


Copy Markdown

Contributor
@guohao-rosicky , could you test if this could fix this memory leak and also the cleanup problem?
sure.
@guohao-rosicky
guohao-rosicky
commented
Jun 8, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
hi, @szetszwo
By looking at the LEAK log, I'm not sure if the leak was caused by calling ByteBuf::retain here and not calling ByteBuf::release twice.
see:
https://github.com/apache/ratis/blob/master/ratis-netty/src/main/java/org/apache/ratis/netty/NettyDataStreamUtils.java#L139
 static DataStreamRequestByteBuf decodeDataStreamRequestByteBuf(ByteBuf buf) {
return Optional.ofNullable(decodeDataStreamRequestHeader(buf))
.map(header -> checkHeader(header, buf))
.map(header -> new DataStreamRequestByteBuf(header, decodeData(buf, header, ByteBuf::retain)))
.orElse(null);
}

leak log:
ERROR org.apache.ratis.thirdparty.io.netty.util.ResourceLeakDetector: LEAK: ByteBuf.release() was not called before it's garbage-collected. See https://netty.io/wiki/reference-counted-objects.html for more information.
Recent access records: #2:
org.apache.ratis.netty.NettyDataStreamUtils.decodeData(NettyDataStreamUtils.java:249)
org.apache.ratis.netty.NettyDataStreamUtils.lambda$decodeDataStreamRequestByteBuf$1(NettyDataStreamUtils.java:140)
java.util.Optional.map(Optional.java:215)
org.apache.ratis.netty.NettyDataStreamUtils.decodeDataStreamRequestByteBuf(NettyDataStreamUtils.java:140)
org.apache.ratis.netty.server.NettyServerStreamRpc$3.decode(NettyServerStreamRpc.java:289)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:510)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:449)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:279)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
org.apache.ratis.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
org.apache.ratis.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
org.apache.ratis.thirdparty.io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:722)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:658)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:584)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:496)
org.apache.ratis.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:995)
org.apache.ratis.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
java.lang.Thread.run(Thread.java:748)

@szetszwo
szetszwo
commented
Jun 9, 2023

Copy link


Copy Markdown

ContributorAuthor
By looking at the LEAK log, ...
Do you mean the new LEAK log after applied this change?
... I'm not sure if the leak was caused by calling ByteBuf::retain here and not calling ByteBuf::release twice.
Calling ByteBuf::release twice seems incorrect. The second call should triggered an exception.
@guohao-rosicky
guohao-rosicky
commented
Jun 14, 2023

Copy link


Copy Markdown

Contributor
hi, @szetszwo. I have committed the code related to stream cleanup on ozone datanode, I have made some changes please help me to review it, thanks.

see:
apache/ozone#4891
@szetszwo
szetszwo
commented
Jun 19, 2023

Copy link


Copy Markdown

ContributorAuthor
@guohao-rosicky , how is your testing going?
@guohao-rosicky
guohao-rosicky
commented
Jun 19, 2023

Copy link


Copy Markdown

Contributor
@guohao-rosicky , how is your testing going?

hi, @szetszwo .

I feel that this change is valid and can be merged.

When this pr is merged, the I will submit a pr later to cleanup when the server side #channelInactive.
@szetszwo
szetszwo
requested a review
from adoroszlaiJune 19, 2023 09:38
adoroszlai
adoroszlai
approved these changes
Jun 19, 2023
View reviewed changes
@adoroszlaiadoroszlai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @szetszwo for the patch. I'm not familiar with Ratis streaming, but the change itself looks good.
@szetszwo
szetszwo
merged commit b49a793
into
apache:masterJun 19, 2023
@szetszwo
szetszwo
commented
Jun 19, 2023

Copy link


Copy Markdown

ContributorAuthor
@guohao-rosicky , thanks a lot for testing this!
@adoroszlai , thanks a lot for reviewing this!
@guohao-rosicky
guohao-rosicky
commented
Jun 20, 2023

Copy link


Copy Markdown

Contributor
On top of this pr I added some processing, @szetszwo PTAL, thanks.

see:
#887
symious pushed a commit
to symious/ratis
that referenced
this pull request
Mar 19, 2024
@szetszwo@symious
RATIS-1847. Stream has memory leak. (apache#884)
253a57f
@SteNicholasSteNicholas
mentioned this pull request
Apr 24, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@guohao-rosickyguohao-rosickyguohao-rosicky left review comments
@adoroszlaiadoroszlaiadoroszlai approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@szetszwo@guohao-rosicky@adoroszlai

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
RATIS-1847. Stream has memory leak. by szetszwo · Pull Request #884 · apache/ratis · GitHub
Skip to content
RATIS-1847. Stream has memory leak. - #884
Merged
szetszwo merged 2 commits into
apache:masterfrom 
szetszwo:RATIS-1847
Jun 19, 2023
Merged
RATIS-1847. Stream has memory leak.#884
szetszwo merged 2 commits into
apache:masterfrom 
szetszwo:RATIS-1847
Conversation
@szetszwo
@szetszwoszetszwo
commented
Jun 7, 2023

Copy link


Copy Markdown

Contributor
@szetszwo
szetszwo
commented
Jun 7, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@guohao-rosicky , could you test if this could fix this memory leak and also the cleanup problem?
@guohao-rosicky
guohao-rosicky
commented
Jun 7, 2023

Copy link


Copy Markdown

Contributor
@guohao-rosicky , could you test if this could fix this memory leak and also the cleanup problem?
sure.
@guohao-rosicky
guohao-rosicky
commented
Jun 8, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
hi, @szetszwo
By looking at the LEAK log, I'm not sure if the leak was caused by calling ByteBuf::retain here and not calling ByteBuf::release twice.
see:
https://github.com/apache/ratis/blob/master/ratis-netty/src/main/java/org/apache/ratis/netty/NettyDataStreamUtils.java#L139
 static DataStreamRequestByteBuf decodeDataStreamRequestByteBuf(ByteBuf buf) {
return Optional.ofNullable(decodeDataStreamRequestHeader(buf))
.map(header -> checkHeader(header, buf))
.map(header -> new DataStreamRequestByteBuf(header, decodeData(buf, header, ByteBuf::retain)))
.orElse(null);
}

leak log:
ERROR org.apache.ratis.thirdparty.io.netty.util.ResourceLeakDetector: LEAK: ByteBuf.release() was not called before it's garbage-collected. See https://netty.io/wiki/reference-counted-objects.html for more information.
Recent access records: #2:
org.apache.ratis.netty.NettyDataStreamUtils.decodeData(NettyDataStreamUtils.java:249)
org.apache.ratis.netty.NettyDataStreamUtils.lambda$decodeDataStreamRequestByteBuf$1(NettyDataStreamUtils.java:140)
java.util.Optional.map(Optional.java:215)
org.apache.ratis.netty.NettyDataStreamUtils.decodeDataStreamRequestByteBuf(NettyDataStreamUtils.java:140)
org.apache.ratis.netty.server.NettyServerStreamRpc$3.decode(NettyServerStreamRpc.java:289)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:510)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:449)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:279)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
org.apache.ratis.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
org.apache.ratis.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
org.apache.ratis.thirdparty.io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:722)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:658)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:584)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:496)
org.apache.ratis.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:995)
org.apache.ratis.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
java.lang.Thread.run(Thread.java:748)

@szetszwo
szetszwo
commented
Jun 9, 2023

Copy link


Copy Markdown

ContributorAuthor
By looking at the LEAK log, ...
Do you mean the new LEAK log after applied this change?
... I'm not sure if the leak was caused by calling ByteBuf::retain here and not calling ByteBuf::release twice.
Calling ByteBuf::release twice seems incorrect. The second call should triggered an exception.
@guohao-rosicky
guohao-rosicky
commented
Jun 14, 2023

Copy link


Copy Markdown

Contributor
hi, @szetszwo. I have committed the code related to stream cleanup on ozone datanode, I have made some changes please help me to review it, thanks.

see:
apache/ozone#4891
@szetszwo
szetszwo
commented
Jun 19, 2023

Copy link


Copy Markdown

ContributorAuthor
@guohao-rosicky , how is your testing going?
@guohao-rosicky
guohao-rosicky
commented
Jun 19, 2023

Copy link


Copy Markdown

Contributor
@guohao-rosicky , how is your testing going?

hi, @szetszwo .

I feel that this change is valid and can be merged.

When this pr is merged, the I will submit a pr later to cleanup when the server side #channelInactive.
@szetszwo
szetszwo
requested a review
from adoroszlaiJune 19, 2023 09:38
adoroszlai
adoroszlai
approved these changes
Jun 19, 2023
View reviewed changes
@adoroszlaiadoroszlai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @szetszwo for the patch. I'm not familiar with Ratis streaming, but the change itself looks good.
@szetszwo
szetszwo
merged commit b49a793
into
apache:masterJun 19, 2023
@szetszwo
szetszwo
commented
Jun 19, 2023

Copy link


Copy Markdown

ContributorAuthor
@guohao-rosicky , thanks a lot for testing this!
@adoroszlai , thanks a lot for reviewing this!
@guohao-rosicky
guohao-rosicky
commented
Jun 20, 2023

Copy link


Copy Markdown

Contributor
On top of this pr I added some processing, @szetszwo PTAL, thanks.

see:
#887
symious pushed a commit
to symious/ratis
that referenced
this pull request
Mar 19, 2024
@szetszwo@symious
RATIS-1847. Stream has memory leak. (apache#884)
253a57f
@SteNicholasSteNicholas
mentioned this pull request
Apr 24, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@guohao-rosickyguohao-rosickyguohao-rosicky left review comments
@adoroszlaiadoroszlaiadoroszlai approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@szetszwo@guohao-rosicky@adoroszlai

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
RATIS-1847. Stream has memory leak. by szetszwo · Pull Request #884 · apache/ratis · GitHub
Skip to content
RATIS-1847. Stream has memory leak. - #884
Merged
szetszwo merged 2 commits into
apache:masterfrom 
szetszwo:RATIS-1847
Jun 19, 2023
Merged
RATIS-1847. Stream has memory leak.#884
szetszwo merged 2 commits into
apache:masterfrom 
szetszwo:RATIS-1847
Conversation
@szetszwo
@szetszwoszetszwo
commented
Jun 7, 2023

Copy link


Copy Markdown

Contributor
@szetszwo
szetszwo
commented
Jun 7, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@guohao-rosicky , could you test if this could fix this memory leak and also the cleanup problem?
@guohao-rosicky
guohao-rosicky
commented
Jun 7, 2023

Copy link


Copy Markdown

Contributor
@guohao-rosicky , could you test if this could fix this memory leak and also the cleanup problem?
sure.
@guohao-rosicky
guohao-rosicky
commented
Jun 8, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
hi, @szetszwo
By looking at the LEAK log, I'm not sure if the leak was caused by calling ByteBuf::retain here and not calling ByteBuf::release twice.
see:
https://github.com/apache/ratis/blob/master/ratis-netty/src/main/java/org/apache/ratis/netty/NettyDataStreamUtils.java#L139
 static DataStreamRequestByteBuf decodeDataStreamRequestByteBuf(ByteBuf buf) {
return Optional.ofNullable(decodeDataStreamRequestHeader(buf))
.map(header -> checkHeader(header, buf))
.map(header -> new DataStreamRequestByteBuf(header, decodeData(buf, header, ByteBuf::retain)))
.orElse(null);
}

leak log:
ERROR org.apache.ratis.thirdparty.io.netty.util.ResourceLeakDetector: LEAK: ByteBuf.release() was not called before it's garbage-collected. See https://netty.io/wiki/reference-counted-objects.html for more information.
Recent access records: #2:
org.apache.ratis.netty.NettyDataStreamUtils.decodeData(NettyDataStreamUtils.java:249)
org.apache.ratis.netty.NettyDataStreamUtils.lambda$decodeDataStreamRequestByteBuf$1(NettyDataStreamUtils.java:140)
java.util.Optional.map(Optional.java:215)
org.apache.ratis.netty.NettyDataStreamUtils.decodeDataStreamRequestByteBuf(NettyDataStreamUtils.java:140)
org.apache.ratis.netty.server.NettyServerStreamRpc$3.decode(NettyServerStreamRpc.java:289)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:510)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:449)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:279)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
org.apache.ratis.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
org.apache.ratis.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
org.apache.ratis.thirdparty.io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:722)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:658)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:584)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:496)
org.apache.ratis.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:995)
org.apache.ratis.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
java.lang.Thread.run(Thread.java:748)

@szetszwo
szetszwo
commented
Jun 9, 2023

Copy link


Copy Markdown

ContributorAuthor
By looking at the LEAK log, ...
Do you mean the new LEAK log after applied this change?
... I'm not sure if the leak was caused by calling ByteBuf::retain here and not calling ByteBuf::release twice.
Calling ByteBuf::release twice seems incorrect. The second call should triggered an exception.
@guohao-rosicky
guohao-rosicky
commented
Jun 14, 2023

Copy link


Copy Markdown

Contributor
hi, @szetszwo. I have committed the code related to stream cleanup on ozone datanode, I have made some changes please help me to review it, thanks.

see:
apache/ozone#4891
@szetszwo
szetszwo
commented
Jun 19, 2023

Copy link


Copy Markdown

ContributorAuthor
@guohao-rosicky , how is your testing going?
@guohao-rosicky
guohao-rosicky
commented
Jun 19, 2023

Copy link


Copy Markdown

Contributor
@guohao-rosicky , how is your testing going?

hi, @szetszwo .

I feel that this change is valid and can be merged.

When this pr is merged, the I will submit a pr later to cleanup when the server side #channelInactive.
@szetszwo
szetszwo
requested a review
from adoroszlaiJune 19, 2023 09:38
adoroszlai
adoroszlai
approved these changes
Jun 19, 2023
View reviewed changes
@adoroszlaiadoroszlai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @szetszwo for the patch. I'm not familiar with Ratis streaming, but the change itself looks good.
@szetszwo
szetszwo
merged commit b49a793
into
apache:masterJun 19, 2023
@szetszwo
szetszwo
commented
Jun 19, 2023

Copy link


Copy Markdown

ContributorAuthor
@guohao-rosicky , thanks a lot for testing this!
@adoroszlai , thanks a lot for reviewing this!
@guohao-rosicky
guohao-rosicky
commented
Jun 20, 2023

Copy link


Copy Markdown

Contributor
On top of this pr I added some processing, @szetszwo PTAL, thanks.

see:
#887
symious pushed a commit
to symious/ratis
that referenced
this pull request
Mar 19, 2024
@szetszwo@symious
RATIS-1847. Stream has memory leak. (apache#884)
253a57f
@SteNicholasSteNicholas
mentioned this pull request
Apr 24, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@guohao-rosickyguohao-rosickyguohao-rosicky left review comments
@adoroszlaiadoroszlaiadoroszlai approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@szetszwo@guohao-rosicky@adoroszlai

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
RATIS-1847. Stream has memory leak. by szetszwo · Pull Request #884 · apache/ratis · GitHub
Skip to content
RATIS-1847. Stream has memory leak. - #884
Merged
szetszwo merged 2 commits into
apache:masterfrom 
szetszwo:RATIS-1847
Jun 19, 2023
Merged
RATIS-1847. Stream has memory leak.#884
szetszwo merged 2 commits into
apache:masterfrom 
szetszwo:RATIS-1847
Conversation
@szetszwo
@szetszwoszetszwo
commented
Jun 7, 2023

Copy link


Copy Markdown

Contributor
@szetszwo
szetszwo
commented
Jun 7, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@guohao-rosicky , could you test if this could fix this memory leak and also the cleanup problem?
@guohao-rosicky
guohao-rosicky
commented
Jun 7, 2023

Copy link


Copy Markdown

Contributor
@guohao-rosicky , could you test if this could fix this memory leak and also the cleanup problem?
sure.
@guohao-rosicky
guohao-rosicky
commented
Jun 8, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
hi, @szetszwo
By looking at the LEAK log, I'm not sure if the leak was caused by calling ByteBuf::retain here and not calling ByteBuf::release twice.
see:
https://github.com/apache/ratis/blob/master/ratis-netty/src/main/java/org/apache/ratis/netty/NettyDataStreamUtils.java#L139
 static DataStreamRequestByteBuf decodeDataStreamRequestByteBuf(ByteBuf buf) {
return Optional.ofNullable(decodeDataStreamRequestHeader(buf))
.map(header -> checkHeader(header, buf))
.map(header -> new DataStreamRequestByteBuf(header, decodeData(buf, header, ByteBuf::retain)))
.orElse(null);
}

leak log:
ERROR org.apache.ratis.thirdparty.io.netty.util.ResourceLeakDetector: LEAK: ByteBuf.release() was not called before it's garbage-collected. See https://netty.io/wiki/reference-counted-objects.html for more information.
Recent access records: #2:
org.apache.ratis.netty.NettyDataStreamUtils.decodeData(NettyDataStreamUtils.java:249)
org.apache.ratis.netty.NettyDataStreamUtils.lambda$decodeDataStreamRequestByteBuf$1(NettyDataStreamUtils.java:140)
java.util.Optional.map(Optional.java:215)
org.apache.ratis.netty.NettyDataStreamUtils.decodeDataStreamRequestByteBuf(NettyDataStreamUtils.java:140)
org.apache.ratis.netty.server.NettyServerStreamRpc$3.decode(NettyServerStreamRpc.java:289)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:510)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:449)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:279)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
org.apache.ratis.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
org.apache.ratis.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
org.apache.ratis.thirdparty.io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:722)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:658)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:584)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:496)
org.apache.ratis.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:995)
org.apache.ratis.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
java.lang.Thread.run(Thread.java:748)

@szetszwo
szetszwo
commented
Jun 9, 2023

Copy link


Copy Markdown

ContributorAuthor
By looking at the LEAK log, ...
Do you mean the new LEAK log after applied this change?
... I'm not sure if the leak was caused by calling ByteBuf::retain here and not calling ByteBuf::release twice.
Calling ByteBuf::release twice seems incorrect. The second call should triggered an exception.
@guohao-rosicky
guohao-rosicky
commented
Jun 14, 2023

Copy link


Copy Markdown

Contributor
hi, @szetszwo. I have committed the code related to stream cleanup on ozone datanode, I have made some changes please help me to review it, thanks.

see:
apache/ozone#4891
@szetszwo
szetszwo
commented
Jun 19, 2023

Copy link


Copy Markdown

ContributorAuthor
@guohao-rosicky , how is your testing going?
@guohao-rosicky
guohao-rosicky
commented
Jun 19, 2023

Copy link


Copy Markdown

Contributor
@guohao-rosicky , how is your testing going?

hi, @szetszwo .

I feel that this change is valid and can be merged.

When this pr is merged, the I will submit a pr later to cleanup when the server side #channelInactive.
@szetszwo
szetszwo
requested a review
from adoroszlaiJune 19, 2023 09:38
adoroszlai
adoroszlai
approved these changes
Jun 19, 2023
View reviewed changes
@adoroszlaiadoroszlai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @szetszwo for the patch. I'm not familiar with Ratis streaming, but the change itself looks good.
@szetszwo
szetszwo
merged commit b49a793
into
apache:masterJun 19, 2023
@szetszwo
szetszwo
commented
Jun 19, 2023

Copy link


Copy Markdown

ContributorAuthor
@guohao-rosicky , thanks a lot for testing this!
@adoroszlai , thanks a lot for reviewing this!
@guohao-rosicky
guohao-rosicky
commented
Jun 20, 2023

Copy link


Copy Markdown

Contributor
On top of this pr I added some processing, @szetszwo PTAL, thanks.

see:
#887
symious pushed a commit
to symious/ratis
that referenced
this pull request
Mar 19, 2024
@szetszwo@symious
RATIS-1847. Stream has memory leak. (apache#884)
253a57f
@SteNicholasSteNicholas
mentioned this pull request
Apr 24, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@guohao-rosickyguohao-rosickyguohao-rosicky left review comments
@adoroszlaiadoroszlaiadoroszlai approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@szetszwo@guohao-rosicky@adoroszlai

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
RATIS-1847. Stream has memory leak. by szetszwo · Pull Request #884 · apache/ratis · GitHub
Skip to content
RATIS-1847. Stream has memory leak. - #884
Merged
szetszwo merged 2 commits into
apache:masterfrom 
szetszwo:RATIS-1847
Jun 19, 2023
Merged
RATIS-1847. Stream has memory leak.#884
szetszwo merged 2 commits into
apache:masterfrom 
szetszwo:RATIS-1847
Conversation
@szetszwo
@szetszwoszetszwo
commented
Jun 7, 2023

Copy link


Copy Markdown

Contributor
@szetszwo
szetszwo
commented
Jun 7, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@guohao-rosicky , could you test if this could fix this memory leak and also the cleanup problem?
@guohao-rosicky
guohao-rosicky
commented
Jun 7, 2023

Copy link


Copy Markdown

Contributor
@guohao-rosicky , could you test if this could fix this memory leak and also the cleanup problem?
sure.
@guohao-rosicky
guohao-rosicky
commented
Jun 8, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
hi, @szetszwo
By looking at the LEAK log, I'm not sure if the leak was caused by calling ByteBuf::retain here and not calling ByteBuf::release twice.
see:
https://github.com/apache/ratis/blob/master/ratis-netty/src/main/java/org/apache/ratis/netty/NettyDataStreamUtils.java#L139
 static DataStreamRequestByteBuf decodeDataStreamRequestByteBuf(ByteBuf buf) {
return Optional.ofNullable(decodeDataStreamRequestHeader(buf))
.map(header -> checkHeader(header, buf))
.map(header -> new DataStreamRequestByteBuf(header, decodeData(buf, header, ByteBuf::retain)))
.orElse(null);
}

leak log:
ERROR org.apache.ratis.thirdparty.io.netty.util.ResourceLeakDetector: LEAK: ByteBuf.release() was not called before it's garbage-collected. See https://netty.io/wiki/reference-counted-objects.html for more information.
Recent access records: #2:
org.apache.ratis.netty.NettyDataStreamUtils.decodeData(NettyDataStreamUtils.java:249)
org.apache.ratis.netty.NettyDataStreamUtils.lambda$decodeDataStreamRequestByteBuf$1(NettyDataStreamUtils.java:140)
java.util.Optional.map(Optional.java:215)
org.apache.ratis.netty.NettyDataStreamUtils.decodeDataStreamRequestByteBuf(NettyDataStreamUtils.java:140)
org.apache.ratis.netty.server.NettyServerStreamRpc$3.decode(NettyServerStreamRpc.java:289)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:510)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:449)
org.apache.ratis.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:279)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
org.apache.ratis.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
org.apache.ratis.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
org.apache.ratis.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
org.apache.ratis.thirdparty.io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:722)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:658)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:584)
org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:496)
org.apache.ratis.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:995)
org.apache.ratis.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
java.lang.Thread.run(Thread.java:748)

@szetszwo
szetszwo
commented
Jun 9, 2023

Copy link


Copy Markdown

ContributorAuthor
By looking at the LEAK log, ...
Do you mean the new LEAK log after applied this change?
... I'm not sure if the leak was caused by calling ByteBuf::retain here and not calling ByteBuf::release twice.
Calling ByteBuf::release twice seems incorrect. The second call should triggered an exception.
@guohao-rosicky
guohao-rosicky
commented
Jun 14, 2023

Copy link


Copy Markdown

Contributor
hi, @szetszwo. I have committed the code related to stream cleanup on ozone datanode, I have made some changes please help me to review it, thanks.

see:
apache/ozone#4891
@szetszwo
szetszwo
commented
Jun 19, 2023

Copy link


Copy Markdown

ContributorAuthor
@guohao-rosicky , how is your testing going?
@guohao-rosicky
guohao-rosicky
commented
Jun 19, 2023

Copy link


Copy Markdown

Contributor
@guohao-rosicky , how is your testing going?

hi, @szetszwo .

I feel that this change is valid and can be merged.

When this pr is merged, the I will submit a pr later to cleanup when the server side #channelInactive.
@szetszwo
szetszwo
requested a review
from adoroszlaiJune 19, 2023 09:38
adoroszlai
adoroszlai
approved these changes
Jun 19, 2023
View reviewed changes
@adoroszlaiadoroszlai
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @szetszwo for the patch. I'm not familiar with Ratis streaming, but the change itself looks good.
@szetszwo
szetszwo
merged commit b49a793
into
apache:masterJun 19, 2023
@szetszwo
szetszwo
commented
Jun 19, 2023

Copy link


Copy Markdown

ContributorAuthor
@guohao-rosicky , thanks a lot for testing this!
@adoroszlai , thanks a lot for reviewing this!
@guohao-rosicky
guohao-rosicky
commented
Jun 20, 2023

Copy link


Copy Markdown

Contributor
On top of this pr I added some processing, @szetszwo PTAL, thanks.

see:
#887
symious pushed a commit
to symious/ratis
that referenced
this pull request
Mar 19, 2024
@szetszwo@symious
RATIS-1847. Stream has memory leak. (apache#884)
253a57f
@SteNicholasSteNicholas
mentioned this pull request
Apr 24, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@guohao-rosickyguohao-rosickyguohao-rosicky left review comments
@adoroszlaiadoroszlaiadoroszlai approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@szetszwo@guohao-rosicky@adoroszlai