Skip to content

Add IgnoreSuffix feature - #93

Merged
wu-sheng merged 12 commits into
apache:masterfrom
alonelaval:ignore_suffix
Jan 13, 2022
Merged

Add IgnoreSuffix feature#93
wu-sheng merged 12 commits into
apache:masterfrom
alonelaval:ignore_suffix

Conversation

@alonelaval

@alonelavalalonelaval commented Jan 10, 2022

Copy link
Copy Markdown
Member

No description provided.

@wu-shengwu-sheng added this to the 0.7.0 milestone Jan 10, 2022
@wu-shengwu-sheng added the enhancement New feature or request label Jan 10, 2022
wu-sheng
wu-sheng reviewed Jan 11, 2022
View reviewed changes
Comment threadlib/skywalking/util.lua Outdated
wu-sheng
wu-sheng reviewed Jan 11, 2022
View reviewed changes
Comment threadlib/skywalking/util.lua Outdated
dmsolr
dmsolr reviewed Jan 11, 2022
View reviewed changes
Comment threadlib/skywalking/tracer.lua Outdated
wu-sheng
wu-sheng reviewed Jan 11, 2022
View reviewed changes
Comment threadlib/skywalking/tracer.lua
wu-sheng
wu-sheng reviewed Jan 11, 2022
View reviewed changes
Comment threadlib/skywalking/util.lua Outdated
wu-sheng
wu-sheng reviewed Jan 11, 2022
View reviewed changes
Comment threadlib/skywalking/util.lua
wu-sheng
wu-sheng reviewed Jan 11, 2022
View reviewed changes
Comment threadtest/e2e/e2e-test/nginx/pom.xml Outdated
@wu-sheng

wu-sheng commented Jan 12, 2022

Copy link
Copy Markdown
Member

@alonelaval CI fails

https://github.com/apache/skywalking-nginx-lua/runs/4773611968?check_suite_focus=true

@alonelaval

alonelaval commented Jan 12, 2022

Copy link
Copy Markdown
MemberAuthor

https://github.com/apache/skywalking-nginx-lua/runs/4773611968?check_suite_focus=true

OK，I will fix.

@tzssangglass

tzssangglass commented Jan 12, 2022

Copy link
Copy Markdown
Member

hi, @alonelaval the CI installation of OpenResty includes luajit, try to use /usr/local/openresty-debug/luajit/bin/luajit instead of lua to test, ffi is a module of luajit.

@alonelaval

alonelaval commented Jan 12, 2022

Copy link
Copy Markdown
MemberAuthor

hi, @alonelaval the CI installation of OpenResty includes luajit, try to use /usr/local/openresty-debug/luajit/bin/luajit instead of lua to test, ffi is a module of luajit.

no work，in my local why luarocks installed package 'luaunit' not found.

@wu-shengwu-sheng mentioned this pull request Jan 13, 2022
Merged
wu-sheng
wu-sheng reviewed Jan 13, 2022
View reviewed changes
Comment threadREADME.md Outdated
wu-sheng
wu-sheng reviewed Jan 13, 2022
View reviewed changes
Comment threadexamples/nginx.conf Outdated
wu-sheng
wu-sheng reviewed Jan 13, 2022
View reviewed changes
Comment threadexamples/nginx.conf Outdated
wu-sheng
wu-sheng reviewed Jan 13, 2022
View reviewed changes
Comment threadexamples/nginx.conf
@wu-sheng
wu-sheng requested a review from dmsolrJanuary 13, 2022 07:59
@wu-sheng

wu-sheng commented Jan 13, 2022

Copy link
Copy Markdown
Member

@membphis@dmsolr@tzssangglass Could you review the PR again?

membphis
membphis approved these changes Jan 13, 2022
View reviewed changes

@membphismembphis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wu-sheng
wu-sheng approved these changes Jan 13, 2022
View reviewed changes

@wu-shengwu-sheng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for more approval.

wu-sheng
wu-sheng reviewed Jan 13, 2022
View reviewed changes
Comment threadlicenses/LICENSE-luaffi.txt Outdated
@@ -0,0 +1,58 @@
BSD License

For luaffifb software

@wu-shengwu-shengJan 13, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thing, why do we have this update? I think we don't copy the luaffi source codes.

@alonelavalalonelavalJan 13, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@wu-sheng
wu-sheng merged commit 49adb5f into apache:masterJan 13, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wu-shengwu-shengwu-sheng approved these changes
@dmsolrdmsolrdmsolr approved these changes
@moonmingmoonmingAwaiting requested review from moonming
+1 more reviewer
@membphismembphismembphis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancementNew feature or request

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@alonelaval@wu-sheng@tzssangglass@membphis@dmsolr