Uh oh!
There was an error while loading. Please reload this page.
ci: run lua test cases with luajit - #94
Merged
Merged
Conversation
since lua-cjson 2.1.0-1 may fail to install, ref openresty/lua-cjson#21, so use lua-cjson2, ref: leafo/lapis#539 (comment) Signed-off-by: tzssangglass <tzssangglass@gmail.com>
wu-sheng
commented
Jan 13, 2022
Member
Is this trying to help #93? |
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
tzssangglass
commented
Jan 13, 2022
MemberAuthor
yes |
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
wu-sheng
commented
Jan 13, 2022
Member
If you are going to change CI process, you need to change the doc here, https://github.com/apache/skywalking-nginx-lua#local-development-and-unit-tests |
tzssangglass
commented
Jan 13, 2022
MemberAuthor
Thanks for the reminder, I will change the doc after the CI pass. |
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
tzssangglass
marked this pull request as ready for review
January 13, 2022 03:47
alonelaval
commented
Jan 13, 2022
Member
great. |
alonelaval
approved these changes
Jan 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since lua-cjson 2.1.0-1 may fail to install, ref
openresty/lua-cjson#21, so use lua-cjson2,
ref: leafo/lapis#539 (comment)
Signed-off-by: tzssangglass tzssangglass@gmail.com