Skip to content

[SPARK-12446][SQL] Add unit tests for JDBCRDD internal functions - #10409

Closed
maropu wants to merge 5 commits into
apache:masterfrom
maropu:AddTestsInJdbcRdd
Closed

[SPARK-12446][SQL] Add unit tests for JDBCRDD internal functions#10409
maropu wants to merge 5 commits into
apache:masterfrom
maropu:AddTestsInJdbcRdd

Conversation

@maropu

@maropumaropu commented Dec 21, 2015

Copy link
Copy Markdown
Member

No tests done for JDBCRDD#compileFilter.

@SparkQA

SparkQA commented Dec 21, 2015

Copy link
Copy Markdown

Test build #48097 has finished for PR 10409 at commit ed94623.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

SparkQA commented Dec 22, 2015

Copy link
Copy Markdown

Test build #48142 has finished for PR 10409 at commit 9932f06.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

rxin
rxin reviewed Dec 22, 2015
View reviewed changes
Comment threadsql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala Outdated

@rxinrxinDec 22, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you just move this code block, or was there any changes made?

@maropumaropuDec 22, 2015

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just moved compileValue, escapeSql, and compileFilter in this companion object area.

@rxin

rxin commented Dec 22, 2015

Copy link
Copy Markdown
Contributor

Let me know once you address my comments. This looks pretty good, assuming you mostly just moved the code to become static functions.

maropu
maropu reviewed Dec 22, 2015
View reviewed changes
Comment threadsql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala

@maropumaropuDec 22, 2015

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rxin `s"'$timestampValue'"`` is better here?

@rxinrxinDec 22, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both works - i wouldn't worry about it.

@maropumaropuDec 22, 2015

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

@maropu

maropu commented Dec 22, 2015

Copy link
Copy Markdown
MemberAuthor

@rxin Finished.

@rxin

rxin commented Dec 22, 2015

Copy link
Copy Markdown
Contributor

LGTM. We should merge this as soon as tests pass.

@SparkQA

SparkQA commented Dec 22, 2015

Copy link
Copy Markdown

Test build #2244 has finished for PR 10409 at commit 46c0e7f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin

rxin commented Dec 22, 2015

Copy link
Copy Markdown
Contributor

Thanks - I've merged this.

@SparkQA

SparkQA commented Dec 22, 2015

Copy link
Copy Markdown

Test build #2245 has finished for PR 10409 at commit 46c0e7f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

SparkQA commented Dec 22, 2015

Copy link
Copy Markdown

Test build #2246 has finished for PR 10409 at commit 46c0e7f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropumaropu mentioned this pull request Dec 22, 2015
Closed
zzcclp added a commit to zzcclp/spark that referenced this pull request Jul 27, 2016
@zzcclp
[EXT][SPARK-12446][SQL] Add unit tests for JDBCRDD internal functionsa…
c4ca4ca
…pache#10409
@dongjoon-hyundongjoon-hyun mentioned this pull request Dec 3, 2016
Closed
asfgit pushed a commit that referenced this pull request Dec 3, 2016
@maropu@gatorsmile
[SPARK-12446][SQL][BACKPORT-1.6] Add unit tests for JDBCRDD internal …
70f271b
…functions
No tests done for JDBCRDD#compileFilter.
Author: Takeshi YAMAMURO <linguin.m.sgmail.com>
Closes#10409 from maropu/AddTestsInJdbcRdd.
(cherry picked from commit 8c1b867)
Author: Takeshi YAMAMURO <linguin.m.s@gmail.com>
Closes#16124 from dongjoon-hyun/SPARK-12446-BRANCH-1.6.
zzcclp added a commit to zzcclp/spark that referenced this pull request Dec 5, 2016
@zzcclp
[SPARK-12446][SQL][BACKPORT-1.6] Add unit tests for JDBCRDD internal …
8e57d83
…functions
No tests done for JDBCRDD#compileFilter.
Author: Takeshi YAMAMURO linguin.m.s@gmail.com
Closesapache#10409 from maropu/AddTestsInJdbcRdd.
(cherry picked from commit 8c1b867)
@maropu
maropu deleted the AddTestsInJdbcRdd branch July 5, 2017 11:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maropu@SparkQA@rxin