Skip to content

[SPARK-12446][SQL][BACKPORT-1.6] Add unit tests for JDBCRDD internal functions - #16124

Closed
dongjoon-hyun wants to merge 1 commit into
apache:branch-1.6from
dongjoon-hyun:SPARK-12446-BRANCH-1.6
Closed

[SPARK-12446][SQL][BACKPORT-1.6] Add unit tests for JDBCRDD internal functions#16124
dongjoon-hyun wants to merge 1 commit into
apache:branch-1.6from
dongjoon-hyun:SPARK-12446-BRANCH-1.6

Conversation

@dongjoon-hyun

Copy link
Copy Markdown
Member

No tests done for JDBCRDD#compileFilter.

Author: Takeshi YAMAMURO linguin.m.s@gmail.com

Closes#10409 from maropu/AddTestsInJdbcRdd.

(cherry picked from commit 8c1b867)

No tests done for JDBCRDD#compileFilter.
Author: Takeshi YAMAMURO <linguin.m.s@gmail.com>
Closes#10409 from maropu/AddTestsInJdbcRdd.
(cherry picked from commit 8c1b867)
@dongjoon-hyun

Copy link
Copy Markdown
MemberAuthor

This is the first commit for #16021.
cc @gatorsmile .

@gatorsmile

Copy link
Copy Markdown
Member

Can you please add [Backport-1.6] to the PR title?

@dongjoon-hyundongjoon-hyun changed the title [SPARK-12446][SQL] Add unit tests for JDBCRDD internal functions[SPARK-12446][SQL][BACKPORT-1.6] Add unit tests for JDBCRDD internal functionsDec 3, 2016
@dongjoon-hyun

Copy link
Copy Markdown
MemberAuthor

Sorry for missing that tag. Thank you!

@SparkQA

Copy link
Copy Markdown

Test build #69595 has finished for PR 16124 at commit 9ec8c70.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile

Copy link
Copy Markdown
Member

LGTM

asfgit pushed a commit that referenced this pull request Dec 3, 2016
…functions
No tests done for JDBCRDD#compileFilter.
Author: Takeshi YAMAMURO <linguin.m.sgmail.com>
Closes#10409 from maropu/AddTestsInJdbcRdd.
(cherry picked from commit 8c1b867)
Author: Takeshi YAMAMURO <linguin.m.s@gmail.com>
Closes#16124 from dongjoon-hyun/SPARK-12446-BRANCH-1.6.
@gatorsmile

Copy link
Copy Markdown
Member

Thanks! Merged to 1.6.

Could you close the PR?

@dongjoon-hyun

Copy link
Copy Markdown
MemberAuthor

Thank you! I'll close this and proceed to next.

@dongjoon-hyun
dongjoon-hyun deleted the SPARK-12446-BRANCH-1.6 branch April 27, 2018 17:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dongjoon-hyun@gatorsmile@SparkQA@maropu