[SPARK-12995][GraphX] Remove deprecate APIs from Pregel

[maropu]

No description provided.

[maropu]

@srowen This is an activity from the discussion in #4402.
I checked that GraphX has deprecate APIs used only in Pregel and this pr removes them.
If there are't any problem, I'll also remove deprecate ones from the test codes in GraphX.

[srowen]

While we're here we can remove runSVDPlusPlus in SVDPlusPlus?

[srowen]

Although it's really minor, the paren placement now makes it hard to see that there are two arg lists. I think it was better as-is.

[maropu]

Fixed.

[srowen]

Jenkins, retest this please

[maropu]

Ah, yes. I removed runSVDPlusPlus in this pr.

[SparkQA]

Test build #50097 has finished for PR 10918 at commit 346ebdc.

• This patch fails MiMa tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

@maropu yeah I think you'll need to write MiMa exclusions for the removal, to confirm they are intended.

[maropu]

yeah, I'm working on it.

[SparkQA]

Test build #50101 has finished for PR 10918 at commit 15937eb.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[maropu]

@srowen Finished.

[srowen]

Looks OK to me, though I'lll want to leave it for review for a while. CC @ankurdave if possible

[maropu]

Okay. If this pr merged, I'll fix test codes in graphx to remove deprecate Graph#mapReduceTriplets.

[maropu]

@ankurdave@srowen ping

[maropu]

@srowen@ankurdave almost inactive, so what should I do?

[srowen]

I'm out this week on vacation but definitely intend to proceed next week. I was leaving it for a while in case ankur is around

[maropu]

okay.

[srowen]

I'm back now. I'm almost ready to merge, but I noticed: should this not also remove mapReduceTriplets? Also the MiMa exclusions are correct but seem to be in the wrong place; at least, it might be clearer to make a new Seq section containing the exclusions just for this issue.

[maropu]

Welcome back. We cannot remove mapReduceTripelets because some tests in graphx still use it.
So, I'll make another pr to fix the tests, then remove it.

[maropu]

The position of the mima entry fixed.

[srowen]

If the only usage is tests, then the tests should be removed too, if they're just there to test this deprecated method. If it's found in other tests, can you migrate that code accordingly?

[maropu]

Ah, we cannot simply remove some tests because these tests target other tests for graph processing.
So, we need to replace mapReduceTriplets with newer aggregateMessage.
Yes, I can fix them.

[SparkQA]

Test build #50902 has finished for PR 10918 at commit 12d368a.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[maropu]

Jenkins, retest this please.

[SparkQA]

Test build #50967 has finished for PR 10918 at commit 12d368a.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

@maropu I'm ready to merge this, but it needs a rebase, and I think this should be completed by removing mapReduceTriplets entirely

[maropu]

@srowen okay, I removed `mapReduceTriplets' in this pr.

[SparkQA]

Test build #51271 has finished for PR 10918 at commit 0e301dd.

• This patch fails MiMa tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #51270 has finished for PR 10918 at commit 8cce85f.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #51279 has finished for PR 10918 at commit a1609ed.

• This patch fails MiMa tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #51280 has finished for PR 10918 at commit 24b7580.

• This patch fails MiMa tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #51281 has finished for PR 10918 at commit 7d1452d.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[maropu]

@srowen okay, all the tests passed, so plz check this?

[srowen]

Merged to master