[SPARK-5623][GraphX] Replace an obsolete mapReduceTriplets with a new aggregateMessages in GraphSuite

[maropu]

No description provided.

[ankurdave]

ok to test

[SparkQA]

Test build #26853 has finished for PR 4402 at commit a7eb3d0.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

@maropu this looks stale. Is it still something you think should be merged? maybe you can rebase and then it can be reviewed if so.

[SparkQA]

Test build #30450 has finished for PR 4402 at commit 5810ff2.

• This patch fails Scala style tests.
• This patch merges cleanly.
• This patch adds no public classes.
• This patch does not change any dependencies.

[SparkQA]

Test build #30454 has finished for PR 4402 at commit 182b39b.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.
• This patch does not change any dependencies.

[maropu]

ok, fixed.

[AmplabJenkins]

Can one of the admins verify this patch?

[srowen]

@ankurdave OK with you?

[srowen]

@maropu I think this was actually a good change, as we have had these deprecation warnings for a long time. Do you want to revive this and try to remove as many usages as possible? There may be some usages of the deprecated method in tests that try to test the deprecated method of course. Or, I may just propose separately that we remove deprecated methods in GraphX for 2.x

[maropu]

@srowen yes and I agreed that these duplicated methods should be removed in 2.x. However, since activities in the GraphX component are almost inactive, I don't think pull requests someones make for GraphX are reviewed and merged actively in the current situation.

[srowen]

Yes, in this regard I'm happy to review and merge changes, since it is only removing use of a method that's already deprecated. In fact I think several other people are comfortable reviewing changes that remove the deprecated methods for Spark 2.x. If you feel up for it, go for it, otherwise I may have a look.

[maropu]

@srowen Okay and I'll do that.

[maropu]

@srowen Is there any JIRA ticket about this topic?

[srowen]

SPARK-5623 I suppose, but that's not about removing the deprecated methods. You could close it and make a subtask of https://issues.apache.org/jira/browse/SPARK-11806 for this.

[maropu]

okay.