SPARK-2168 [Spark core] Use relative URIs for the app links in the History Server. by elyast · Pull Request #1160 · apache/spark

elyast · 2014-06-20T21:12:23Z

Removing full URI leaving only relative path in link to the completed application plus unit test

AmplabJenkins · 2014-06-20T21:15:03Z

Can one of the admins verify this patch?

vanzin · 2014-06-26T23:27:59Z

Haven't looked at the code yet, but could you add a more descriptive title to the PR? Thanks!

vanzin · 2014-06-26T23:29:06Z

Also, this should probably go into master before it goes to branch-1.0.

elyast · 2014-06-26T23:58:25Z

I have added more descriptive title

elyast · 2014-06-26T23:59:24Z

so should I open another PR for master branch?

vanzin · 2014-06-27T00:13:17Z

There's a typo in your title. :-)

Also, it could be shorter. Think that the PR title becomes the summary in the final git commit, so it shows in commands like "git log --oneline" where it's nice to have a short, concise description of the commit. I'd suggest something like this:

Use relative URIs for the app links in the History Server.

And then you can put a longer description in the description box, if you wish.

As for the branch, I'm not sure; that's beyond my github knowledge. I'd wait for a committer to chime in. :-)

elyast · 2014-07-01T04:01:28Z

I've shortened description thanks for hints.

andrewor14 · 2014-08-25T21:56:19Z

test this please

andrewor14 · 2014-08-25T21:56:44Z

indentation is weird here. Also, can you explain your comments "when" and "then"?

Sorry about the identation I was pretty sure it's fine when I was committing this one.
About "when" and "then", it's an old habit to simulate BDD-style of testing in Junit, however in Scala it could be replaced by using Specs2 or WordSpec trait from ScalaTest.
Let me know what u would like me to change.

SparkQA · 2014-09-05T23:46:07Z

Can one of the admins verify this patch?

andrewor14 · 2014-09-06T00:54:17Z

ok to test...

SparkQA · 2014-09-06T01:43:34Z

QA tests have started for PR 1160 at commit dc1f70a.

This patch merges cleanly.

SparkQA · 2014-09-06T03:01:59Z

QA tests have finished for PR 1160 at commit dc1f70a.

This patch passes unit tests.
This patch merges cleanly.
This patch adds no public classes.

andrewor14 · 2014-12-22T22:32:24Z

Hey @elyast could you open this against the master branch? It would be good if the latest Spark releases benefit from the changes here as well. For now, I would recommend that we close this PR in favor of one that updates the other branches.

elyast · 2014-12-24T22:58:38Z

@andrewor14 I think it's been fixed on master branch, so if you don't want to release maintenance release for 1.0.x then I would suggest to close it.

andrewor14 · 2015-01-07T23:26:43Z

I see. Nevertheless it would be good to merge the tests in master too. Feel free to open a new PR just for the test.

andrewor14 · 2015-01-07T23:27:00Z

Actually, let's retest this please

SparkQA · 2015-01-07T23:27:48Z

Test build #25182 has started for PR 1160 at commit dc1f70a.

This patch merges cleanly.

SparkQA · 2015-01-08T00:39:22Z

Test build #25182 has finished for PR 1160 at commit dc1f70a.

This patch fails some tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-01-08T00:39:26Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25182/
Test FAILed.

andrewor14 · 2015-01-08T02:13:11Z

retest this please

SparkQA · 2015-01-08T02:17:35Z

Test build #25194 has started for PR 1160 at commit dc1f70a.

This patch merges cleanly.

SparkQA · 2015-01-08T03:29:13Z

Test build #25194 has finished for PR 1160 at commit dc1f70a.

This patch fails some tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-01-08T03:29:18Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25194/
Test FAILed.

andrewor14 · 2015-01-08T17:39:27Z

Looks like branch-1.0 is consistently failing tests (not related to this PR)

srowen · 2015-02-09T11:17:56Z

Is this still live? I think this PR should be closed in any event, but the test can go in master in a separate PR. Otherwise let's close this.

elyast · 2015-02-09T20:54:27Z

Fine with me, I will add tests on master with new PR

…story Server. As agreed in PR #1160 adding test to verify if history server generates relative links to applications. Author: Lukasz Jastrzebski <lukasz.jastrzebski@gmail.com> Closes#4778 from elyast/master and squashes the following commits: 0c07fab [Lukasz Jastrzebski] Incorporating comments for SPARK-2168 6d7866d [Lukasz Jastrzebski] Adjusting test for SPARK-2168 for master branch d6f4fbe [Lukasz Jastrzebski] Added test for SPARK-2168

…story Server. As agreed in PR #1160 adding test to verify if history server generates relative links to applications. Author: Lukasz Jastrzebski <lukasz.jastrzebski@gmail.com> Closes#4778 from elyast/master and squashes the following commits: 0c07fab [Lukasz Jastrzebski] Incorporating comments for SPARK-2168 6d7866d [Lukasz Jastrzebski] Adjusting test for SPARK-2168 for master branch d6f4fbe [Lukasz Jastrzebski] Added test for SPARK-2168 (cherry picked from commit 4a8a0a8) Signed-off-by: Andrew Or <andrew@databricks.com>

* rdar://82095645 (Update the Callhome Version at Apple Spark Build) add jwt token on client side and send more fields to server for analytic and ML purpose

…properties performance (#1160)

elyast added 2 commits June 19, 2014 12:22

fixed links on history page
a362f35

adding test for history server suite
dc1f70a

elyast changed the title ~~SPARK-2168 Spark core~~SPARK-2168 [Spark core] History Server renered page not suitable for load balancing, links to the completed applications should be relativeJun 26, 2014

elyast changed the title ~~SPARK-2168 [Spark core] History Server rendered page not suitable for load balancing, links to the completed applications should be relative~~SPARK-2168 [Spark core] Use relative URIs for the app links in the History Server.Jul 1, 2014

andrewor14 reviewed Aug 25, 2014
View reviewed changes

elyast closed this Feb 9, 2015

elyast mentioned this pull request Feb 26, 2015
SPARK-2168 [Spark core] Use relative URIs for the app links in the History Server. #4778
Closed

flyrain pushed a commit to flyrain/spark that referenced this pull request Sep 21, 2021
Branch 3.1.1 apple (apache#1160)
2eca24d
* rdar://82095645 (Update the Callhome Version at Apple Spark Build) add jwt token on client side and send more fields to server for analytic and ML purpose

wangyum pushed a commit that referenced this pull request May 26, 2023
[CARMEL-6399] Download hive-1.2.1 jar files to local to improve load …
f91eb96
…properties performance (#1160)

mapr-devops pushed a commit to mapr/spark that referenced this pull request May 8, 2025
[EZAF-3795] Spark-3.5.0 fails with unable to find Guava (apache#1160)
3e899cc

Uh oh!

Conversation

elyast commented Jun 20, 2014

Uh oh!

AmplabJenkins commented Jun 20, 2014

Uh oh!

vanzin commented Jun 26, 2014

Uh oh!

vanzin commented Jun 26, 2014

Uh oh!

elyast commented Jun 26, 2014

Uh oh!

elyast commented Jun 26, 2014

Uh oh!

vanzin commented Jun 27, 2014

Uh oh!

elyast commented Jul 1, 2014

Uh oh!

andrewor14 commented Aug 25, 2014

Uh oh!

andrewor14Aug 25, 2014

Choose a reason for hiding this comment

Uh oh!

elyastAug 25, 2014

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Sep 5, 2014

Uh oh!

andrewor14 commented Sep 6, 2014

Uh oh!

SparkQA commented Sep 6, 2014

Uh oh!

SparkQA commented Sep 6, 2014

Uh oh!

andrewor14 commented Dec 22, 2014

Uh oh!

elyast commented Dec 24, 2014

Uh oh!

andrewor14 commented Jan 7, 2015

Uh oh!

andrewor14 commented Jan 7, 2015

Uh oh!

SparkQA commented Jan 7, 2015

Uh oh!

SparkQA commented Jan 8, 2015

Uh oh!

AmplabJenkins commented Jan 8, 2015

Uh oh!

andrewor14 commented Jan 8, 2015

Uh oh!

SparkQA commented Jan 8, 2015

Uh oh!

SparkQA commented Jan 8, 2015

Uh oh!

AmplabJenkins commented Jan 8, 2015

Uh oh!

andrewor14 commented Jan 8, 2015

Uh oh!

srowen commented Feb 9, 2015

Uh oh!

elyast commented Feb 9, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants