SPARK-2168 [Spark core] Use relative URIs for the app links in the History Server.

[elyast]

As agreed in PR #1160 adding test to verify if history server generates relative links to applications.

[AmplabJenkins]

Can one of the admins verify this patch?

[srowen]

ok to test

[SparkQA]

Test build #27998 has started for PR 4778 at commit 6d7866d.

• This patch merges cleanly.

[SparkQA]

Test build #27998 has finished for PR 4778 at commit 6d7866d.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • class HistoryServerSuite extends FunSuite with Matchers with MockitoSugar

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27998/
Test PASSed.

[srowen]

A bunch of little style nits: The indentation is off by one here. Also I think the imports could be ordered, with scala import first and separated by a line. Fix the extra space in true ) above. Don't we need to import postfixOps to avoid a compiler warning? Do the historyServer and request have to be members?

Otherwise this looks just fine as a follow-on test.

[elyast]

I compare indentation with FsHistoryProviderSuite and imho its the same, imports will do.
I don't think postfixOps is actually needed here. I will make historyServer and request local variables.

[SparkQA]

Test build #28047 has started for PR 4778 at commit 0c07fab.

• This patch merges cleanly.

[SparkQA]

Test build #28047 has finished for PR 4778 at commit 0c07fab.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • class HistoryServerSuite extends FunSuite with Matchers with MockitoSugar

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28047/
Test PASSed.

[andrewor14]

Ok LGTM merging into master 1.3 thanks @elyast