Skip to content

SPARK-2804: Remove scalalogging-slf4j dependency - #1208

Closed
witgo wants to merge 1 commit into
apache:masterfrom
witgo:SPARK-1470
Closed

SPARK-2804: Remove scalalogging-slf4j dependency#1208
witgo wants to merge 1 commit into
apache:masterfrom
witgo:SPARK-1470

Conversation

@witgo

@witgowitgo commented Jun 25, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@AmplabJenkins

AmplabJenkins commented Jun 25, 2014

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

AmplabJenkins commented Jun 25, 2014

Copy link
Copy Markdown

Merged build started.

@AmplabJenkins

AmplabJenkins commented Jun 25, 2014

Copy link
Copy Markdown

Merged build finished.

@AmplabJenkins

AmplabJenkins commented Jun 25, 2014

Copy link
Copy Markdown

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16103/

@rxin

rxin commented Jun 25, 2014

Copy link
Copy Markdown
Contributor

To be honest, my scar from the incident (deprecating Scala 2.10 support before Scala 2.11 was even released) hasn't fully recovered. Do we gain anything by moving onto this logging API? There is a tiny teeny performance boost, but I don't think we log any hot code path in spark-core.

@witgo

witgo commented Jun 25, 2014

Copy link
Copy Markdown
ContributorAuthor

The main benefit is unified log Interface. Now the code using scala-logging-slf4j and slf4j-api at the same time

@SparkQA

SparkQA commented Jul 11, 2014

Copy link
Copy Markdown

QA tests have started for PR 1208. This patch DID NOT merge cleanly!
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16549/consoleFull

@SparkQA

SparkQA commented Jul 11, 2014

Copy link
Copy Markdown

QA results for PR 1208:
- This patch FAILED unit tests.

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16549/consoleFull

@SparkQA

SparkQA commented Jul 11, 2014

Copy link
Copy Markdown

QA tests have started for PR 1208. This patch DID NOT merge cleanly!
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16550/consoleFull

@witgowitgo closed this Jul 11, 2014
@SparkQA

SparkQA commented Jul 11, 2014

Copy link
Copy Markdown

QA tests have started for PR 1208. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16551/consoleFull

@witgo
witgo deleted the SPARK-1470 branch July 11, 2014 04:03
@witgowitgo reopened this Jul 11, 2014
@witgowitgo closed this Jul 11, 2014
@witgo
witgo restored the SPARK-1470 branch July 11, 2014 04:07
@witgo
witgo deleted the SPARK-1470 branch July 11, 2014 04:11
@witgo
witgo restored the SPARK-1470 branch July 11, 2014 04:11
@SparkQA

SparkQA commented Jul 11, 2014

Copy link
Copy Markdown

QA results for PR 1208:
- This patch FAILED unit tests.

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16550/consoleFull

@SparkQA

SparkQA commented Jul 11, 2014

Copy link
Copy Markdown

QA results for PR 1208:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16551/consoleFull

@witgo
witgo deleted the SPARK-1470 branch July 11, 2014 05:45
@srowensrowen mentioned this pull request Jul 11, 2014
Closed
@witgo
witgo restored the SPARK-1470 branch July 15, 2014 13:50
@witgowitgo changed the title SPARK-1470: Use the scala-logging wrapper instead of the directly sfl4j apiSPARK-1470: Remove scalalogging-slf4j dependencyAug 2, 2014
@witgowitgo changed the title SPARK-1470: Remove scalalogging-slf4j dependency[WIP][SPARK-1470]: Remove scalalogging-slf4j dependencyAug 2, 2014
@witgowitgo reopened this Aug 2, 2014
@SparkQA

SparkQA commented Aug 2, 2014

Copy link
Copy Markdown

QA tests have started for PR 1208. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17761/consoleFull

@SparkQA

SparkQA commented Aug 2, 2014

Copy link
Copy Markdown

QA tests have started for PR 1208. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17764/consoleFull

@witgo

witgo commented Aug 2, 2014

Copy link
Copy Markdown
ContributorAuthor

@pwendell@marmbrus How to test the performance impact of the PR?

@SparkQA

SparkQA commented Aug 2, 2014

Copy link
Copy Markdown

QA results for PR 1208:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17761/consoleFull

@SparkQA

SparkQA commented Aug 2, 2014

Copy link
Copy Markdown

QA results for PR 1208:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17764/consoleFull

@asfgitasfgit closed this in 4c47711Aug 2, 2014
@pwendell

pwendell commented Aug 2, 2014

Copy link
Copy Markdown
Contributor

Okay - I've merged this into master and 1.1 with three changes:

  1. This patch converted a warning to a debug (https://github.com/apache/spark/pull/1208/files#diff-6b519cd0a9dc5b0ee9caab7712d252e9L238), I reverted that change.
  2. In this patch, TestHive.scala still used the old format (log.info), so I switched it to use the standard Spark format that includes guards (e.g. logInfo).
  3. I updated the title to reflect a new JIRA that more correctly describes the current approach.

4c47711

asfgit pushed a commit that referenced this pull request Aug 2, 2014
@witgo@pwendell
SPARK-2804: Remove scalalogging-slf4j dependency
7924d72
This also Closes#1701.
Author: GuoQiang Li <witgo@qq.com>
Closes#1208 from witgo/SPARK-1470 and squashes the following commits:
422646b [GuoQiang Li] Remove scalalogging-slf4j dependency
@witgo
witgo deleted the SPARK-1470 branch August 3, 2014 01:20
@witgowitgo changed the title [WIP][SPARK-1470]: Remove scalalogging-slf4j dependencySPARK-2804: Remove scalalogging-slf4j dependencyAug 3, 2014
@witgo

witgo commented Aug 3, 2014

Copy link
Copy Markdown
ContributorAuthor

Cool thanks

@mengxrmengxr mentioned this pull request Aug 3, 2014
Merged
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@witgo@conviva-zz
SPARK-2804: Remove scalalogging-slf4j dependency
2979cf4
This also Closesapache#1701.
Author: GuoQiang Li <witgo@qq.com>
Closesapache#1208 from witgo/SPARK-1470 and squashes the following commits:
422646b [GuoQiang Li] Remove scalalogging-slf4j dependency
wangyum pushed a commit that referenced this pull request May 26, 2023
fenzhuGitHub Enterprise
[CARMEL-6518] Record temp view usage in workload analysis (#1208)
deb3e82
* [CARMEL-6518] Record temp view usage in workload analysis
* record temp view
* fix typo
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@witgo@AmplabJenkins@rxin@SparkQA@pwendell