Skip to content

[SPARK-1812] upgrade dependency to scala-logging 2.1.2 - #1701

Closed
avati wants to merge 1 commit into
apache:masterfrom
avati:SPARK-1812-slf4j-2.1.2
Closed

[SPARK-1812] upgrade dependency to scala-logging 2.1.2#1701
avati wants to merge 1 commit into
apache:masterfrom
avati:SPARK-1812-slf4j-2.1.2

Conversation

@avati

Copy link
Copy Markdown
Contributor

Scala 2.11 packages not available for the current version (1.0.1)

Signed-off-by: Anand Avati avati@redhat.com

Signed-off-by: Anand Avati <avati@redhat.com>
@AmplabJenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@avatiavati changed the title SPARK-1812: upgrade dependency to scala-logging 2.1.2[SPARK-1812] upgrade dependency to scala-logging 2.1.2Jul 31, 2014
@avatiavati changed the title [SPARK-1812] upgrade dependency to scala-logging 2.1.2[SPARK-1812] [SPARK-1842] upgrade dependency to scala-logging 2.1.2Jul 31, 2014
@avatiavati changed the title [SPARK-1812] [SPARK-1842] upgrade dependency to scala-logging 2.1.2[SPARK-1812] upgrade dependency to scala-logging 2.1.2Aug 1, 2014
@ScrapCodes

Copy link
Copy Markdown
Member

Jenkins, test this please.

Comment threadsql/core/pom.xml

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why we need the second artifact ?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scalalogging-slf4j-1.0.1 seems to be split into scala-logging-{slf4j,api} for 2.1.2. Previously scalalogging was missing in sql/core pom.xml (usually not a problem unless you do mvn compile within the module)

@ScrapCodes

Copy link
Copy Markdown
Member

@pwendell Jenkins does not listen to my commands, Can you command it ?

@ScrapCodes

Copy link
Copy Markdown
Member

LGTM, if jenkins build passes. It would be good to merge this with #940.

@mengxr

Copy link
Copy Markdown
Contributor

Jenkins, test this please.

@SparkQA

Copy link
Copy Markdown

QA tests have started for PR 1701. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17676/consoleFull

@SparkQA

Copy link
Copy Markdown

QA results for PR 1701:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17676/consoleFull

@asfgitasfgit closed this in 4c47711Aug 2, 2014
asfgit pushed a commit that referenced this pull request Aug 2, 2014
This also Closes#1701.
Author: GuoQiang Li <witgo@qq.com>
Closes#1208 from witgo/SPARK-1470 and squashes the following commits:
422646b [GuoQiang Li] Remove scalalogging-slf4j dependency
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
This also Closesapache#1701.
Author: GuoQiang Li <witgo@qq.com>
Closesapache#1208 from witgo/SPARK-1470 and squashes the following commits:
422646b [GuoQiang Li] Remove scalalogging-slf4j dependency
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@avati@AmplabJenkins@ScrapCodes@mengxr@SparkQA