Skip to content

[SPARK-15072][SQL][PySpark] FollowUp: Remove SparkSession.withHiveSupport in PySpark - #13063

Closed
techaddict wants to merge 1 commit into
apache:masterfrom
techaddict:SPARK-15072-followup
Closed

[SPARK-15072][SQL][PySpark] FollowUp: Remove SparkSession.withHiveSupport in PySpark#13063
techaddict wants to merge 1 commit into
apache:masterfrom
techaddict:SPARK-15072-followup

Conversation

@techaddict

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

This is a followup of #12851
Remove SparkSession.withHiveSupport in PySpark and instead use SparkSession.builder. enableHiveSupport

How was this patch tested?

Existing tests.

@andrewor14

andrewor14 commented May 11, 2016

Copy link
Copy Markdown
Contributor

@techaddict in the future can you try to put more changes in one patch instead of having many small related patches?

@techaddict

Copy link
Copy Markdown
ContributorAuthor

Hi @andrewor14 support for enableHiveSupport was added(0903a18) after I started working on removing withHiveSupport in #12851
That's why the Follow Up PR.

@andrewor14

Copy link
Copy Markdown
Contributor

I see. That's fine then.

@SparkQA

Copy link
Copy Markdown

Test build #58411 has finished for PR 13063 at commit 413a9ec.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14

Copy link
Copy Markdown
Contributor

Merging into master 2.0. Thanks.

asfgit pushed a commit that referenced this pull request May 12, 2016
…port in PySpark
## What changes were proposed in this pull request?
This is a followup of #12851
Remove `SparkSession.withHiveSupport` in PySpark and instead use `SparkSession.builder. enableHiveSupport`
## How was this patch tested?
Existing tests.
Author: Sandeep Singh <sandeep@techaddict.me>
Closes#13063 from techaddict/SPARK-15072-followup.
@yhuai

Copy link
Copy Markdown
Contributor

There are still places where we use withHiveSupport. Seems our tests did not catch those.

@yhuai

Copy link
Copy Markdown
Contributor

#13069 is the fix

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@techaddict@andrewor14@SparkQA@yhuai