Skip to content

[SPARK-15072][SQL][PYSPARK][HOT-FIX] Remove SparkSession.withHiveSupport from readwrite.py - #13069

Closed
yhuai wants to merge 1 commit into
apache:masterfrom
yhuai:fixPython
Closed

[SPARK-15072][SQL][PYSPARK][HOT-FIX] Remove SparkSession.withHiveSupport from readwrite.py#13069
yhuai wants to merge 1 commit into
apache:masterfrom
yhuai:fixPython

Conversation

@yhuai

@yhuaiyhuai commented May 12, 2016

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Seems db573fc did not remove withHiveSupport from readwrite.py

@yhuaiyhuai mentioned this pull request May 12, 2016
Closed
@yhuai

yhuai commented May 12, 2016

Copy link
Copy Markdown
ContributorAuthor

i have tested locally. It fixed the test. I am merging it to master and branch 2.0.

asfgit pushed a commit that referenced this pull request May 12, 2016
@yhuai
[SPARK-15072][SQL][PYSPARK][HOT-FIX] Remove SparkSession.withHiveSupp…
7d18753
…ort from readwrite.py
## What changes were proposed in this pull request?
Seems db573fc did not remove withHiveSupport from readwrite.py
Author: Yin Huai <yhuai@databricks.com>
Closes#13069 from yhuai/fixPython.
(cherry picked from commit ba5487c)
Signed-off-by: Yin Huai <yhuai@databricks.com>
@viiryaviirya mentioned this pull request May 12, 2016
Closed
@SparkQA

SparkQA commented May 12, 2016

Copy link
Copy Markdown

Test build #58441 has finished for PR 13069 at commit f0a1fd1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@nchammas

nchammas commented May 16, 2016

Copy link
Copy Markdown
Contributor

Seems db573fc did not remove withHiveSupport from readwrite.py

@yhuai - It did, but I added it back in as part of this PR: https://github.com/apache/spark/pull/13034/files#diff-6d503df22b5f03cff987f1ccae32c1f4R878

What's the reason for the change to not use withHiveSupport()? The JIRA doesn't explain.

@yhuai

yhuai commented May 16, 2016

Copy link
Copy Markdown
ContributorAuthor

@nchammas It's part of the cleanup related to how we create SparkSession. Since with/without hive support is controlled by a conf, we replaced withHiveSupport with enableHiveSupport (this one just set the conf).

@nchammas

nchammas commented May 16, 2016

Copy link
Copy Markdown
Contributor

Okie doke, thanks for the explanation!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yhuai@SparkQA@nchammas