Uh oh!
There was an error while loading. Please reload this page.
[SPARK-14387][SQL] Enable Hive-1.x ORC compatibility with spark.sql.hive.convertMetastoreOrc - #14471
Closed
rajeshbalamohan wants to merge 3 commits into
Closed
[SPARK-14387][SQL] Enable Hive-1.x ORC compatibility with spark.sql.hive.convertMetastoreOrc#14471rajeshbalamohan wants to merge 3 commits into
rajeshbalamohan wants to merge 3 commits into
Conversation
SparkQA
commented
Aug 3, 2016
Test build #63147 has finished for PR 14471 at commit
|
rajeshbalamohan
commented
Aug 3, 2016
Author
Fixed scalastyle issues |
SparkQA
commented
Aug 3, 2016
Test build #63150 has finished for PR 14471 at commit
|
rxin
commented
Aug 3, 2016
Contributor
Can you add a test case? |
rxin
commented
Aug 3, 2016
Contributor
also can you update the title? The current title is very generic. This ticket seems to be solving a specific problem. |
…ive.convertMetastoreOrc
Author
Thanks @rxin. Changes:
|
SparkQA
commented
Aug 3, 2016
Test build #63169 has finished for PR 14471 at commit
|
JoshRosen
commented
Sep 20, 2016
Contributor
Jenkins, retest this please. |
SparkQA
commented
Sep 21, 2016
Test build #65687 has finished for PR 14471 at commit
|
dongjoon-hyun
commented
Sep 15, 2017
Member
Hi, @rajeshbalamohan . I'll refer your commit for SPARK-19459 . You'll be the main author in case of merge. |
dongjoon-hyun
commented
Oct 21, 2017
Member
Hi, @rajeshbalamohan . |
zifeif2 pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
Closesapache#11494Closesapache#14158Closesapache#16803Closesapache#16864Closesapache#17455Closesapache#17936Closesapache#19377 Added: Closesapache#19380Closesapache#18642Closesapache#18377Closesapache#19632 Added: Closesapache#14471Closesapache#17402Closesapache#17953Closesapache#18607 Also cc srowen vanzin HyukjinKwon gatorsmile cloud-fan to see if you have other PRs to close. Author: Xingbo Jiang <xingbo.jiang@databricks.com> Closesapache#19669 from jiangxb1987/stale-prs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR improves ORCFileFormat to handle cases when schema stored in the ORC file does not match the schema stored in metastore.
ORC Data written by Hive-1.x had virtual column names (HIVE-4243). This is fixed in Hive-2.x, but for data stored using Hive-1.x spark would throw exceptions. To mitigate this, "spark.sql.hve.convertMetastoreOrc" was disabled via SPARK-15705. However, that would incur
performance penalties as it would go via HiveTableScan and HadoopRDD. This PR fixes this issue.
Related tickets:
SPARK-15705 : Change the default value of spark.sql.hive.convertMetastoreOrc to false.
SPARK-15705 : Spark won't read ORC schema from metastore for partitioned tables
SPARK-16628 : OrcConversions should not convert an ORC table represented by MetastoreRelation to HadoopFsRelation if metastore schema does not match schema stored in ORC files
How was this patch tested?
Manual testing by setting "spark.sql.hve.convertMetastoreOrc=true" and querying data stored via Hive-1.x in ORC format. Also ran unit-tests related to sql.
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)