Uh oh!
There was an error while loading. Please reload this page.
[SPARK-22154] add a shutdown hook that explains why the output is terminating - #19377
[SPARK-22154] add a shutdown hook that explains why the output is terminating#19377liu-zhaokun wants to merge 1 commit into
Conversation
srowen
commented
Sep 28, 2017
The events of a shutdown are already logged; what does this add? it's already clear something is shutting down |
AmplabJenkins
commented
Sep 28, 2017
Can one of the admins verify this patch? |
liu-zhaokun
commented
Sep 28, 2017
It says that "It would be nice to add a shutdown hook here that explains why the output is terminating. Otherwise if the worker dies the executor logs will silently stop" in "TODO",I think it is justified. |
srowen
commented
Sep 28, 2017
Why a shutdown hook instead of something in the lifecycle of this process? |
liu-zhaokun
commented
Sep 28, 2017
@srowen |
srowen
commented
Sep 28, 2017
Where does the worker exit normally or in case of an error? Why not log there? |
liu-zhaokun
commented
Sep 28, 2017
@srowen |
jiangxb1987
commented
Nov 6, 2017
I'm going to close this PR because it goes stale, please feel free to reopen it or open another PR if anyone have more thoughts on this issue. |
Closesapache#11494Closesapache#14158Closesapache#16803Closesapache#16864Closesapache#17455Closesapache#17936Closesapache#19377 Added: Closesapache#19380Closesapache#18642Closesapache#18377Closesapache#19632 Added: Closesapache#14471Closesapache#17402Closesapache#17953Closesapache#18607 Also cc srowen vanzin HyukjinKwon gatorsmile cloud-fan to see if you have other PRs to close. Author: Xingbo Jiang <xingbo.jiang@databricks.com> Closesapache#19669 from jiangxb1987/stale-prs.
It would be nice to add a shutdown hook here that explains why the output is terminating. Otherwise if the worker dies the executor logs will silently stop.