Uh oh!
There was an error while loading. Please reload this page.
[SPARK-18871][SQL][TESTS] New test cases for IN/NOT IN subquery 4th batch - #16915
Closed
kevinyu98 wants to merge 48 commits into
Closed
[SPARK-18871][SQL][TESTS] New test cases for IN/NOT IN subquery 4th batch#16915kevinyu98 wants to merge 48 commits into
kevinyu98 wants to merge 48 commits into
Conversation
get latest code from upstream
adding trim characters support
get latest code for pr12646
merge latest code
merge upstream/master
| ON t1c = t2c | ||
| LEFT JOIN t3 | ||
| ON t2d = t3d ) AND | ||
| t1a = "val1b") |
Member
There was a problem hiding this comment.
The style looks strange. Could you adjust them?
ContributorAuthor
There was a problem hiding this comment.
sure, I have adjust the style and resubmit. thanks.
gatorsmile
commented
Feb 14, 2017
Member
ok to test |
SparkQA
commented
Feb 14, 2017
Test build #72846 has finished for PR 16915 at commit
|
hvanhovell
commented
Feb 15, 2017
Contributor
@kevinyu98@nsyca@dilipbiswal could someone confirm that these results match DB2? I also think that this PR is almost too large. |
nsyca
reviewed
Feb 15, 2017
| 1 10 NULL 2014-08-04 | ||
| 1 10 NULL 2014-09-04 | ||
| 1 10 NULL 2015-05-04 | ||
| 1 10 NULL 2014-05-04 |
Contributor
There was a problem hiding this comment.
All the results are equivalent with the ones from DB2.
| struct<t1a:string,t1b:smallint,t1c:int,t1d:bigint,t1h:timestamp> | ||
| -- !query 12 output | ||
| val1b 8 16 19 2014-05-04 01:01:00 | ||
| val1c 8 16 19 2014-05-04 01:02:00.001 |
Contributor
There was a problem hiding this comment.
All the results are equivalent with the ones from DB2.
| -- !query 8 schema | ||
| struct<count(DISTINCT t1a):bigint,t1b:smallint,t1c:int,t1d:bigint> | ||
| -- !query 8 output | ||
| 1 6 8 10 |
Contributor
There was a problem hiding this comment.
All the results are equivalent with the ones from DB2.
nsyca
commented
Feb 15, 2017
Contributor
It's larger than typical test PRs we submitted for the subquery JIRA but since it's the last test PR, we think we wanted to avoid an additional round of administrative work. |
gatorsmile
commented
Feb 15, 2017
Member
retest this please |
SparkQA
commented
Feb 15, 2017
Test build #72952 has finished for PR 16915 at commit
|
gatorsmile
commented
Feb 16, 2017
Member
LGTM. Merging to master. |
kevinyu98
commented
Feb 16, 2017
ContributorAuthor
@gatorsmile thanks a lot. |
cmonkey pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 16, 2017
…atch ## What changes were proposed in this pull request? This is 4th batch of test case for IN/NOT IN subquery. In this PR, it has these test files: `in-set-operations.sql` `in-with-cte.sql` `not-in-joins.sql` Here are the queries and results from running on DB2. [in-set-operations DB2 version](https://github.com/apache/spark/files/772846/in-set-operations.sql.db2.txt) [Output of in-set-operations](https://github.com/apache/spark/files/772848/in-set-operations.sql.db2.out.txt) [in-with-cte DB2 version](https://github.com/apache/spark/files/772849/in-with-cte.sql.db2.txt) [Output of in-with-cte](https://github.com/apache/spark/files/772856/in-with-cte.sql.db2.out.txt) [not-in-joins DB2 version](https://github.com/apache/spark/files/772851/not-in-joins.sql.db2.txt) [Output of not-in-joins](https://github.com/apache/spark/files/772852/not-in-joins.sql.db2.out.txt) ## How was this patch tested? This pr is adding new test cases. We compare the result from spark with the result from another RDBMS(We used DB2 LUW). If the results are the same, we assume the result is correct. Author: Kevin Yu <qyu@us.ibm.com> Closesapache#16915 from kevinyu98/spark-18871-44.
asfgit pushed a commit
that referenced
this pull request
Mar 14, 2017
…ll up to Optimizer phase ## What changes were proposed in this pull request? Currently Analyzer as part of ResolveSubquery, pulls up the correlated predicates to its originating SubqueryExpression. The subquery plan is then transformed to remove the correlated predicates after they are moved up to the outer plan. In this PR, the task of pulling up correlated predicates is deferred to Optimizer. This is the initial work that will allow us to support the form of correlated subqueries that we don't support today. The design document from nsyca can be found in the following link : [DesignDoc](https://docs.google.com/document/d/1QDZ8JwU63RwGFS6KVF54Rjj9ZJyK33d49ZWbjFBaIgU/edit#) The brief description of code changes (hopefully to aid with code review) can be be found in the following link: [CodeChanges](https://docs.google.com/document/d/18mqjhL9V1An-tNta7aVE13HkALRZ5GZ24AATA-Vqqf0/edit#) ## How was this patch tested? The test case PRs were submitted earlier using. [16337](#16337) [16759](#16759) [16841](#16841) [16915](#16915) [16798](#16798) [16712](#16712) [16710](#16710) [16760](#16760) [16802](#16802) Author: Dilip Biswal <dbiswal@us.ibm.com> Closes#16954 from dilipbiswal/SPARK-18874.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is 4th batch of test case for IN/NOT IN subquery. In this PR, it has these test files:
in-set-operations.sqlin-with-cte.sqlnot-in-joins.sqlHere are the queries and results from running on DB2.
in-set-operations DB2 version
Output of in-set-operations
in-with-cte DB2 version
Output of in-with-cte
not-in-joins DB2 version
Output of not-in-joins
How was this patch tested?
This pr is adding new test cases. We compare the result from spark with the result from another RDBMS(We used DB2 LUW). If the results are the same, we assume the result is correct.