Uh oh!
There was an error while loading. Please reload this page.
[SPARK-26744][SQL][HOTFIX] Disable schema validation tests for FileDataSourceV2 (partially revert SPARK-26744) - #23828
Closed
HyukjinKwon wants to merge 1 commit into
Closed
[SPARK-26744][SQL][HOTFIX] Disable schema validation tests for FileDataSourceV2 (partially revert SPARK-26744)#23828HyukjinKwon wants to merge 1 commit into
HyukjinKwon wants to merge 1 commit into
Conversation
… for FileDataSourceV2
HyukjinKwon
commented
Feb 18, 2019
MemberAuthor
cc @cloud-fan, @gengliangwang, @rdblue. |
HyukjinKwon
commented
Feb 18, 2019
MemberAuthor
I'll close this one if there'd a quick fix or action soon. |
cloud-fan
commented
Feb 18, 2019
Contributor
There is a fix: #23824 But it seems can't be merged very soon, let's disable the test first. |
cloud-fan
commented
Feb 18, 2019
Contributor
I'm merging it to unblock other PRs, thanks! |
HyukjinKwon
commented
Feb 18, 2019
MemberAuthor
Thanks, Wenchen. |
MemberAuthor
Oops, what's hot fox hahaha typo :( .. OMG I didn't even know hot fox has a meaning too!! embarrassing! |
SparkQA
commented
Feb 18, 2019
Test build #102474 has finished for PR 23828 at commit
|
mccheah pushed a commit
to palantir/spark
that referenced
this pull request
May 15, 2019
…ts for FileDataSourceV2 (partially revert ) ## What changes were proposed in this pull request? This PR partially revert SPARK-26744. apache@60caa92 and apache@4dce45a were merged at similar time range independently. So the test failures were not caught. - apache@60caa92 happened to add a schema reading logic in writing path for overwrite mode as well. - apache@4dce45a added some tests with overwrite modes with migrated ORC v2. And the tests looks starting to fail. I guess the discussion won't be short (see apache#23606 (comment)) and this PR proposes to disable the tests added at apache@4dce45a to unblock other PRs for now. ## How was this patch tested? Existing tests. Closesapache#23828 from HyukjinKwon/SPARK-26744. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR partially revert SPARK-26744.
60caa92 and 4dce45a were merged at similar time range independently. So the test failures were not caught.
60caa92 happened to add a schema reading logic in writing path for overwrite mode as well.
4dce45a added some tests with overwrite modes with migrated ORC v2.
And the tests looks starting to fail.
I guess the discussion won't be short (see #23606 (comment)) and this PR proposes to disable the tests added at 4dce45a to unblock other PRs for now.
How was this patch tested?
Existing tests.