Uh oh!
There was an error while loading. Please reload this page.
[MINOR][SQL][TESTS] Check file based V2 datasources on unsupported types - #50356
Closed
MaxGekk wants to merge 1 commit into
Closed
[MINOR][SQL][TESTS] Check file based V2 datasources on unsupported types#50356MaxGekk wants to merge 1 commit into
MaxGekk wants to merge 1 commit into
Conversation
MaxGekk
marked this pull request as ready for review
March 23, 2025 15:19
MaxGekk
commented
Mar 23, 2025
MaxGekk
left a comment
MemberAuthor
There was a problem hiding this comment.
@dongjoon-hyun@HyukjinKwon@gengliangwang@cloud-fan Could you review the changes, please. It is related to your PR (or your reviews):
HyukjinKwon
approved these changes
Mar 24, 2025
HyukjinKwon
commented
Mar 24, 2025
Member
Merged to master. |
cloud-fan
commented
Mar 24, 2025
Contributor
late LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to modify
FileBasedDataSourceSuiteand check V2 datasources: JSON/CSV, ORC, Parquet on the unsupported data types: intervals and null. And remove TODOs.Why are the changes needed?
To extend test coverage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running the modified test suites:
Was this patch authored or co-authored using generative AI tooling?
No.