Uh oh!
There was an error while loading. Please reload this page.
[SPARK-30159][SQL][FOLLOWUP] Fix lint-java via removing unnecessary imports - #26818
[SPARK-30159][SQL][FOLLOWUP] Fix lint-java via removing unnecessary imports#26818HeartSaVioR wants to merge 1 commit into
Conversation
dongjoon-hyun
commented
Dec 9, 2019
Thank you, @HeartSaVioR ! |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. This passed GitHub Action linter.
Merged to master.
gengliangwang
commented
Dec 9, 2019
@HeartSaVioR Thanks for the follow-up |
SparkQA
commented
Dec 9, 2019
Test build #115044 has finished for PR 26818 at commit
|
HeartSaVioR
commented
Dec 9, 2019
Thanks all for reviewing and merging! |
HyukjinKwon
commented
Dec 10, 2019
Thanks for fixing it. Hm, I wonder why there's a diff ... |
HeartSaVioR
commented
Dec 10, 2019
#26820 seems to be an answer; we don't fail the build even though there're style guide violations. In script of Github Action, we run |
Yes.
|
HyukjinKwon
commented
Dec 10, 2019
I mean, Jenkins uses I don't believe the linter doesn't fail in PR builder if this isn't a regression - I tested it when I added it. |
What changes were proposed in this pull request?
This patch fixes the Java code style violations in SPARK-30159 (#26788) which are caught by lint-java (Github Action caught it and I can reproduce it locally). Looks like Jenkins build may have different policy on checking Java style check or less accurate.
Why are the changes needed?
Java linter starts complaining.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
lint-java passed locally
This closes#26819