Skip to content

[SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server - #28721

Closed
MaxGekk wants to merge 1 commit into
apache:masterfrom
MaxGekk:enable-date.sql-for-thrift
Closed

[SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server#28721
MaxGekk wants to merge 1 commit into
apache:masterfrom
MaxGekk:enable-date.sql-for-thrift

Conversation

@MaxGekk

@MaxGekkMaxGekk commented Jun 3, 2020

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Enable date.sql and run it via Thrift Server in ThriftServerQueryTestSuite.

Why are the changes needed?

To improve test coverage.

Does this PR introduce any user-facing change?

No

How was this patch tested?

By running the enabled tests via:

$ build/sbt -Phive-thriftserver "hive-thriftserver/test-only *ThriftServerQueryTestSuite -- -z date.sql"

@SparkQA

SparkQA commented Jun 3, 2020

Copy link
Copy Markdown

Test build #123508 has finished for PR 28721 at commit abd7bed.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu

maropu commented Jun 3, 2020

Copy link
Copy Markdown
Member

retest this please

@maropu

maropu commented Jun 3, 2020

Copy link
Copy Markdown
Member

Looks nice if the tests passed.

HyukjinKwon
HyukjinKwon approved these changes Jun 4, 2020
View reviewed changes

@HyukjinKwonHyukjinKwon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too if tests pass

@SparkQA

SparkQA commented Jun 4, 2020

Copy link
Copy Markdown

Test build #123512 has finished for PR 28721 at commit abd7bed.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu

maropu commented Jun 4, 2020

Copy link
Copy Markdown
Member

This fix can be merged into branch-3.0? I'm not really sure that branch-3.0 has no issue described in SPARK-28624 though.

@HyukjinKwon

HyukjinKwon commented Jun 4, 2020

Copy link
Copy Markdown
Member

Let me merge it to master first. From reading the JIRA, seems it's fixed only in the master.

@HyukjinKwon

HyukjinKwon commented Jun 4, 2020

Copy link
Copy Markdown
Member

Merged to master.

holdenk pushed a commit to holdenk/spark that referenced this pull request Jun 4, 2020
@MaxGekk@holdenk
[SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server
6f0544a
### What changes were proposed in this pull request?
Enable `date.sql` and run it via Thrift Server in `ThriftServerQueryTestSuite`.
### Why are the changes needed?
To improve test coverage.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By running the enabled tests via:
```
$ build/sbt -Phive-thriftserver "hive-thriftserver/test-only *ThriftServerQueryTestSuite -- -z date.sql"
```
Closesapache#28721 from MaxGekk/enable-date.sql-for-thrift.
Authored-by: Max Gekk <max.gekk@gmail.com>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
@HyukjinKwon

HyukjinKwon commented Jun 5, 2020

Copy link
Copy Markdown
Member

I had an offline discussion with @MaxGekk and @cloud-fan. Per #28723 (comment), I will revert this too.

Again, technically it was fine to merge in a way because the skipped tests passed. I am here reverting this rather for the management purpose - the JIRA isn't resolved yet because we need to discuss if the result is correct or not.

@MaxGekk
MaxGekk deleted the enable-date.sql-for-thrift branch June 5, 2020 19:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maropumaropumaropu approved these changes
@HyukjinKwonHyukjinKwonHyukjinKwon approved these changes

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MaxGekk@SparkQA@maropu@HyukjinKwon