Uh oh!
There was an error while loading. Please reload this page.
[SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server - #28723
[SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server#28723MaxGekk wants to merge 1 commit into
Conversation
MaxGekk
commented
Jun 4, 2020
@HyukjinKwon Please, review this PR. |
HyukjinKwon
commented
Jun 4, 2020
Looks good if the tests pass. WDYT can you point out which change fixed this if you already know? |
MaxGekk
commented
Jun 4, 2020
@HyukjinKwon I guess this PR fixes the issue mainly: |
SparkQA
commented
Jun 4, 2020
Test build #123519 has finished for PR 28723 at commit
|
HyukjinKwon
commented
Jun 4, 2020
Let's cut out RC3 first and then merge. |
| "postgreSQL/boolean.sql", | ||
| "postgreSQL/case.sql", | ||
| // SPARK-28624 | ||
| "date.sql", |
There was a problem hiding this comment.
thriftserver doesn't support negative year, I think we still need to ignore this test.
HyukjinKwon
commented
Jun 5, 2020
I discussed with @MaxGekk@cloud-fan. The tests will have to be disabled back at SPARK-30808. Basically, resulting to We strictly can just merge and enable it for Spark 3.0 specifically because SPARK-30808 won't land to |
What changes were proposed in this pull request?
Enable
date.sqland run it via Thrift Server inThriftServerQueryTestSuite.Why are the changes needed?
To improve test coverage.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By running the enabled tests via: