[SQL][minor] remove duplicated resolveGetField and update comment

[cloud-fan]

It's after #5189

[cloud-fan]

cc @marmbrus

[marmbrus]

ok to test

[marmbrus]

Thanks for reopening this. Sorry for missing your PR against my branch.

[SparkQA]

Test build #29515 has finished for PR 5304 at commit c58c9b3.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • class Normalizer extends UnaryTransformer[Vector, Vector, Normalizer]
  • case class Data(
  • case class Data(
  • s" but class priors vector pi had $
  • s" but class conditionals array theta had $
  • case class Data(word: String, vector: Array[Float])
  • class LinearClassificationModel(LinearModel):
  • class LogisticRegressionModel(LinearClassificationModel):
  • class SVMModel(LinearClassificationModel):
  • class UDFRegistration(object):
  • class DataFrameNaFunctions(object):
  • class Analyzer(
  • trait CheckAnalysis
  • case class CreateStruct(children: Seq[NamedExpression]) extends Expression
  • case class AtLeastNNonNulls(n: Int, children: Seq[Expression]) extends Predicate
  • case class StringStartsWith(attribute: String, value: String) extends Filter
  • case class StringEndsWith(attribute: String, value: String) extends Filter
  • case class StringContains(attribute: String, value: String) extends Filter
• This patch adds the following new dependencies:
  • avro-1.7.7.jar
  • breeze-macros_2.10-0.11.2.jar
  • breeze_2.10-0.11.2.jar
• This patch removes the following dependencies:
  • avro-1.7.6.jar
  • breeze-macros_2.10-0.11.1.jar
  • breeze_2.10-0.11.1.jar

[cloud-fan]

Hi @marmbrus , is it ready to go? Or should we create a companion object GetField and put resolveGetField into it?

[marmbrus]

Sorry for the delay. I'm going to go ahead and merge so we don't forget to remove the duplication. I do like the idea of putting this in an object instead.

[JoshRosen]

(bump to get Spark PRs to refresh this)