Skip to content

[SQL][minor] move resolveGetField into a object - #5435

Closed
cloud-fan wants to merge 1 commit into
apache:masterfrom
cloud-fan:tmp
Closed

[SQL][minor] move resolveGetField into a object#5435
cloud-fan wants to merge 1 commit into
apache:masterfrom
cloud-fan:tmp

Conversation

@cloud-fan

@cloud-fancloud-fan commented Apr 9, 2015

Copy link
Copy Markdown
Contributor

The method resolveGetField isn't belong to LogicalPlan logically and didn't access any members of it.

@cloud-fan

cloud-fan commented Apr 9, 2015

Copy link
Copy Markdown
ContributorAuthor

cc @marmbrus, it's a follow-up of #5304.

@marmbrus

marmbrus commented Apr 12, 2015

Copy link
Copy Markdown
Contributor

ok to test

@SparkQA

SparkQA commented Apr 12, 2015

Copy link
Copy Markdown

Test build #30096 has finished for PR 5435 at commit 9a66c83.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@marmbrus

marmbrus commented Apr 12, 2015

Copy link
Copy Markdown
Contributor

Awesome, thanks! This looks much cleaner. Merging to master.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cloud-fan@marmbrus@SparkQA