Skip to content

Storm 1226 - #1043

Closed
rfarivar wants to merge 19 commits into
apache:masterfrom
rfarivar:STORM-1226
Closed

Storm 1226#1043
rfarivar wants to merge 19 commits into
apache:masterfrom
rfarivar:STORM-1226

Conversation

@rfarivar

@rfarivarrfarivar commented Jan 25, 2016

Copy link
Copy Markdown
Contributor

This is translating util.clj into java functions mostly in utils/Utils.java.

Translation is half way done, passing all unit tests. Putting the pull request up to get reviews.

rfarivarand others added 16 commits January 13, 2016 14:05
rfarivar
first batch of util.clj functions translated to java
cc2daf3
rfarivar
upmerged with org.apache.storm reorg
41d229b
rfarivar
fixing the failing test in supervisor-test due to find-first translation
912d14c
rfarivar
translation finished up to find-first, passing all tests
65522f0
rfarivar
passing test, done up to uuid
d4a7af6
Derek Dagit
translate batch 3
b6edf16
rfarivar
passing tests. In the middle of replacing map-val
7de457e
Derek Dagit
Merge branch 'STORM-1226' ofhttps://github.com/rfarivar/storminto y…
c0aff49
…storm-2572-util-translate-batch-3
Derek Dagit
fix failing tests
4067809
Derek Dagit
creates package to help with mocking static methods
56d48fa
rfarivar
Batch 1 complete, all tests passing
f478858
Derek Dagit
moves staticmocking under test/
43da3c6
Derek Dagit
Merge remote-tracking branch 'reza/STORM-1226' into ystorm-2572-util-…
b370d9e
…translate-batch-3
Reza Farivar
Merge pull request#1from d2r/ystorm-2572-util-translate-batch-3
77e10d4
util translate batch 3
rfarivar
Translation up to the middle of batch 2, batch 1 and 3 complete
eff86b2
rfarivar
upmerged to master
69c3ab7
knusbaum
knusbaum reviewed Jan 25, 2016
View reviewed changes
Comment threadstorm-core/src/jvm/org/apache/storm/utils/Utils.java

@knusbaumknusbaumJan 25, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if, else, and do-while can be replaced by a while:

while (iter != null && iter.hasNext()) {
...
}

revans2
revans2 reviewed Jan 26, 2016
View reviewed changes
Comment threadstorm-core/src/jvm/org/apache/storm/utils/Utils.java

@revans2revans2Jan 26, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this a javadoc instead of just a comment?

@revans2

revans2 commented Jan 26, 2016

Copy link
Copy Markdown
Contributor

Finished with my first pass through the code. For the most part things are looking very good.

@revans2revans2 mentioned this pull request Jan 27, 2016
Merged
@knusbaum

knusbaum commented Jan 28, 2016

Copy link
Copy Markdown
Contributor

Also, will you kindly edit the title of this PR so it follows protocol?

@knusbaum

knusbaum commented Feb 1, 2016

Copy link
Copy Markdown
Contributor

It would be good to move MockedUtils.java into org/apache/storm/testing/staticmocking where the other mocking stuff is.

@d2r

d2r commented Feb 1, 2016

Copy link
Copy Markdown

Let's rename the title of this pull request so it describes the work being done. Something about translating the utils namespace to Java.

knusbaum added a commit to knusbaum/incubator-storm that referenced this pull request Feb 2, 2016
@knusbaum
Addressed comments from pullapache#1043
acc77f8
knusbaum added a commit to knusbaum/incubator-storm that referenced this pull request Feb 2, 2016
@knusbaum
Addressed comments from pullapache#1043
30635f8
@knusbaum

knusbaum commented Feb 3, 2016

Copy link
Copy Markdown
Contributor

Should close this PR because of #1074

d2r pushed a commit to d2r/storm that referenced this pull request Oct 16, 2018
Derek Dagit
Closes Pull Requests unchanged in 2018
fcda81c
We are closing stale Pull Requests to make the list more manageable.
Please re-open any Pull Request that has been closed in error.
Closesapache#608Closesapache#639Closesapache#640Closesapache#648Closesapache#662Closesapache#668Closesapache#692Closesapache#705Closesapache#724Closesapache#728Closesapache#730Closesapache#753Closesapache#803Closesapache#854Closesapache#922Closesapache#986Closesapache#992Closesapache#1019Closesapache#1040Closesapache#1041Closesapache#1043Closesapache#1046Closesapache#1051Closesapache#1078Closesapache#1146Closesapache#1164Closesapache#1165Closesapache#1178Closesapache#1213Closesapache#1225Closesapache#1258Closesapache#1259Closesapache#1268Closesapache#1272Closesapache#1277Closesapache#1278Closesapache#1288Closesapache#1296Closesapache#1328Closesapache#1342Closesapache#1353Closesapache#1370Closesapache#1376Closesapache#1391Closesapache#1395Closesapache#1399Closesapache#1406Closesapache#1410Closesapache#1422Closesapache#1427Closesapache#1443Closesapache#1462Closesapache#1468Closesapache#1483Closesapache#1506Closesapache#1509Closesapache#1515Closesapache#1520Closesapache#1521Closesapache#1525Closesapache#1527Closesapache#1544Closesapache#1550Closesapache#1566Closesapache#1569Closesapache#1570Closesapache#1575Closesapache#1580Closesapache#1584Closesapache#1591Closesapache#1600Closesapache#1611Closesapache#1613Closesapache#1639Closesapache#1703Closesapache#1711Closesapache#1719Closesapache#1737Closesapache#1760Closesapache#1767Closesapache#1768Closesapache#1785Closesapache#1799Closesapache#1822Closesapache#1824Closesapache#1844Closesapache#1874Closesapache#1918Closesapache#1928Closesapache#1937Closesapache#1942Closesapache#1951Closesapache#1957Closesapache#1963Closesapache#1964Closesapache#1965Closesapache#1967Closesapache#1968Closesapache#1971Closesapache#1985Closesapache#1986Closesapache#1998Closesapache#2031Closesapache#2032Closesapache#2071Closesapache#2076Closesapache#2108Closesapache#2119Closesapache#2128Closesapache#2142Closesapache#2174Closesapache#2206Closesapache#2297Closesapache#2322Closesapache#2332Closesapache#2341Closesapache#2377Closesapache#2414Closesapache#2469
d2r pushed a commit to d2r/storm that referenced this pull request Oct 16, 2018
Derek Dagit
Closes Pull Requests unchanged in 2018
fdb95d0
We are closing stale Pull Requests to make the list more manageable.
Please re-open any Pull Request that has been closed in error.
Closesapache#608Closesapache#639Closesapache#640Closesapache#648Closesapache#662Closesapache#668Closesapache#692Closesapache#705Closesapache#724Closesapache#728Closesapache#730Closesapache#753Closesapache#803Closesapache#854Closesapache#922Closesapache#986Closesapache#992Closesapache#1019Closesapache#1040Closesapache#1041Closesapache#1043Closesapache#1046Closesapache#1051Closesapache#1078Closesapache#1146Closesapache#1164Closesapache#1165Closesapache#1178Closesapache#1213Closesapache#1225Closesapache#1258Closesapache#1259Closesapache#1268Closesapache#1272Closesapache#1277Closesapache#1278Closesapache#1288Closesapache#1296Closesapache#1328Closesapache#1342Closesapache#1353Closesapache#1370Closesapache#1376Closesapache#1391Closesapache#1395Closesapache#1399Closesapache#1406Closesapache#1410Closesapache#1422Closesapache#1427Closesapache#1443Closesapache#1462Closesapache#1468Closesapache#1483Closesapache#1506Closesapache#1509Closesapache#1515Closesapache#1520Closesapache#1521Closesapache#1525Closesapache#1527Closesapache#1544Closesapache#1550Closesapache#1566Closesapache#1569Closesapache#1570Closesapache#1575Closesapache#1580Closesapache#1584Closesapache#1591Closesapache#1600Closesapache#1611Closesapache#1613Closesapache#1639Closesapache#1703Closesapache#1711Closesapache#1719Closesapache#1737Closesapache#1760Closesapache#1767Closesapache#1768Closesapache#1785Closesapache#1799Closesapache#1822Closesapache#1824Closesapache#1844Closesapache#1874Closesapache#1918Closesapache#1928Closesapache#1937Closesapache#1942Closesapache#1951Closesapache#1957Closesapache#1963Closesapache#1964Closesapache#1965Closesapache#1967Closesapache#1968Closesapache#1971Closesapache#1985Closesapache#1986Closesapache#1998Closesapache#2031Closesapache#2032Closesapache#2071Closesapache#2076Closesapache#2108Closesapache#2119Closesapache#2128Closesapache#2142Closesapache#2174Closesapache#2206Closesapache#2297Closesapache#2322Closesapache#2332Closesapache#2341Closesapache#2377Closesapache#2414Closesapache#2469
@d2rd2r mentioned this pull request Oct 16, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rfarivar@revans2@knusbaum@d2r@zhuoliu