Skip to content

TEZ-4303: Exclude compile-time httpclient dependency from Tez - #119

Merged
abstractdog merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4303
Dec 26, 2021
Merged

TEZ-4303: Exclude compile-time httpclient dependency from Tez#119
abstractdog merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4303

Conversation

@abstractdog

Copy link
Copy Markdown
Contributor

No description provided.

@hadoop-yetus

This comment has been minimized.

@jteaglesjteagles left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. This will be nice to remove

@jteagles

Copy link
Copy Markdown
Contributor

@abstractdog, can we get an updated patch that addresses the merge conflict?

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

thanks for the review @jteagles, I've just uploaded new version

@hadoop-yetus

This comment has been minimized.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

rebasing before merge

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec16m 45sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall13m 5smaster passed
+1 💚compile2m 15smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚compile2m 2smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javadoc2m 21smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc1m 36smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
_ Patch Compile Tests _
+1 💚mvninstall4m 5sthe patch passed
+1 💚compile2m 15sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javac2m 15sthe patch passed
+1 💚compile2m 1sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac2m 1sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚javadoc1m 58sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc1m 36sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
_ Other Tests _
-1 ❌unit69m 0sroot in the patch failed.
+1 💚asflicense0m 31sThe patch does not generate ASF License warnings.
120m 27s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-119/3/artifact/out/Dockerfile
GITHUB PR#119
JIRA IssueTEZ-4303
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux 813befa3be38 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / bf616b2
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
unithttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-119/3/artifact/out/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-119/3/testReport/
Max. process+thread count1186 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-119/3/console
versionsgit=2.25.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

TestFaultTolerance failed (timeout), unrelated failure, already exists on master

@abstractdog
abstractdog merged commit 8f846dc into apache:masterDec 26, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@abstractdog@hadoop-yetus@jteagles@tez-yetus