Skip to content

TEZ-4347: Add some diagnostic endpoints to TezAM's WebUIService - #160

Merged
abstractdog merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4347
May 4, 2022
Merged

TEZ-4347: Add some diagnostic endpoints to TezAM's WebUIService#160
abstractdog merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4347

Conversation

@abstractdog

@abstractdogabstractdog commented Nov 11, 2021

Copy link
Copy Markdown
Contributor

Add some diagnostic endpoints to TezAM's WebUIService

  • add new endpoints to webuiservice
  • make port range configurable
  • publish the web endpoint through dag client
  • unit test included: TestAM
  • checked in browser too

@tez-yetus

This comment has been minimized.

@tez-yetus

This comment has been minimized.

@tez-yetus

This comment has been minimized.

@tez-yetus

This comment has been minimized.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

could you please review this @jteagles , @zjffdu? a medium size patch for adding new features to tez am web ui service

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec16m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep5m 5sMaven dependency ordering for branch
+1 💚mvninstall9m 48smaster passed
+1 💚compile2m 31smaster passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚compile2m 17smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle2m 5smaster passed
+1 💚javadoc2m 27smaster passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc2m 7smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗spotbugs0m 43sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 39smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall1m 39sthe patch passed
+1 💚compile1m 48sthe patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚cc1m 48sthe patch passed
+1 💚javac1m 48sthe patch passed
+1 💚compile1m 35sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚cc1m 35sthe patch passed
+1 💚javac1m 35sthe patch passed
-0 ⚠️checkstyle0m 8stez-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc1m 30sthe patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc1m 23sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚findbugs4m 14sthe patch passed
_ Other Tests _
+1 💚unit2m 1stez-api in the patch passed.
+1 💚unit0m 24stez-common in the patch passed.
+1 💚unit1m 12stez-mapreduce in the patch passed.
+1 💚unit4m 16stez-dag in the patch passed.
+1 💚unit38m 56stez-tests in the patch passed.
+1 💚asflicense0m 58sThe patch does not generate ASF License warnings.
110m 22s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-160/10/artifact/out/Dockerfile
GITHUB PR#160
JIRA IssueTEZ-4347
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile cc prototool
unameLinux 0f5a1586d607 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / f724c54
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-160/10/artifact/out/diff-checkstyle-tez-common.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-160/10/testReport/
Max. process+thread count1214 (vs. ulimit of 5500)
modulesC: tez-api tez-common tez-mapreduce tez-dag tez-tests U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-160/10/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

please review this @rbalamohan , @jteagles, thanks in advance!
tested locally, we would like this patch to be the base of further improvements like TEZ-4038, so we're kind of blocked here

@rbalamohan

Copy link
Copy Markdown
Contributor

LGTM. +1. This can serve as the base for adding "/prof" endpoint in AM later.

@abstractdog
abstractdog merged commit 798ddda into apache:masterMay 4, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@abstractdog@tez-yetus@rbalamohan