Skip to content

TEZ-4340: Show convenient input -> output vertex names in input messages - #170

Merged
abstractdog merged 1 commit into
apache:masterfrom
csjuhasz-c:master
Jan 17, 2022
Merged

TEZ-4340: Show convenient input -> output vertex names in input messages#170
abstractdog merged 1 commit into
apache:masterfrom
csjuhasz-c:master

Conversation

@csjuhasz-c

Copy link
Copy Markdown
Contributor

No description provided.

@tez-yetus

This comment has been minimized.

@abstractdog

abstractdog commented Dec 25, 2021

Copy link
Copy Markdown
Contributor

patch looks good mostly, some comments:

  1. please replace srcNameTrimmed in ShuffleManager and ShuffleScheduler too, similarly to UnorderedPartitionedKVWriter in TEZ-4180
  2. address checkstyle/whitespace warnings where possible

@tez-yetus

This comment has been minimized.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 4 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep4m 47sMaven dependency ordering for branch
+1 💚mvninstall10m 17smaster passed
+1 💚compile2m 43smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚compile2m 40smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle2m 23smaster passed
+1 💚javadoc2m 46smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc2m 14smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗spotbugs0m 46sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 37smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall1m 44sthe patch passed
+1 💚compile1m 49sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javac1m 49sthe patch passed
+1 💚compile1m 36sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac1m 36sthe patch passed
+1 💚checkstyle0m 13sThe patch passed checkstyle in tez-api
+1 💚checkstyle0m 9sThe patch passed checkstyle in tez-runtime-internals
-0 ⚠️checkstyle0m 19stez-runtime-library: The patch generated 4 new + 160 unchanged - 3 fixed = 164 total (was 163)
+1 💚checkstyle0m 12sThe patch passed checkstyle in tez-mapreduce
+1 💚checkstyle0m 13stez-tests: The patch generated 0 new + 39 unchanged - 1 fixed = 39 total (was 40)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc1m 31sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc1m 24sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚findbugs4m 7sthe patch passed
_ Other Tests _
+1 💚unit2m 2stez-api in the patch passed.
+1 💚unit0m 35stez-runtime-internals in the patch passed.
+1 💚unit4m 18stez-runtime-library in the patch passed.
+1 💚unit1m 14stez-mapreduce in the patch passed.
+1 💚unit46m 29stez-tests in the patch passed.
+1 💚asflicense0m 57sThe patch does not generate ASF License warnings.
104m 5s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-170/3/artifact/out/Dockerfile
GITHUB PR#170
JIRA IssueTEZ-4340
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux 8f243b6da851 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 41cbc17
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-170/3/artifact/out/diff-checkstyle-tez-runtime-library.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-170/3/testReport/
Max. process+thread count1398 (vs. ulimit of 5500)
modulesC: tez-api tez-runtime-internals tez-runtime-library tez-mapreduce tez-tests U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-170/3/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 8sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 6 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep4m 48sMaven dependency ordering for branch
+1 💚mvninstall9m 33smaster passed
+1 💚compile2m 27smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚compile2m 14smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle2m 3smaster passed
+1 💚javadoc2m 22smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc2m 2smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗spotbugs0m 44sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 26smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall1m 35sthe patch passed
+1 💚compile1m 41sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javac1m 41sthe patch passed
+1 💚compile1m 29sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac1m 29sthe patch passed
+1 💚checkstyle0m 11sThe patch passed checkstyle in tez-api
+1 💚checkstyle0m 9sThe patch passed checkstyle in tez-runtime-internals
-0 ⚠️checkstyle0m 18stez-runtime-library: The patch generated 7 new + 274 unchanged - 4 fixed = 281 total (was 278)
+1 💚checkstyle0m 11sThe patch passed checkstyle in tez-mapreduce
+1 💚checkstyle0m 12stez-tests: The patch generated 0 new + 39 unchanged - 1 fixed = 39 total (was 40)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc1m 25sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc1m 17sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚findbugs3m 59sthe patch passed
_ Other Tests _
+1 💚unit1m 58stez-api in the patch passed.
+1 💚unit0m 32stez-runtime-internals in the patch passed.
+1 💚unit4m 5stez-runtime-library in the patch passed.
+1 💚unit1m 11stez-mapreduce in the patch passed.
+1 💚unit43m 30stez-tests in the patch passed.
+1 💚asflicense0m 49sThe patch does not generate ASF License warnings.
97m 42s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-170/4/artifact/out/Dockerfile
GITHUB PR#170
JIRA IssueTEZ-4340
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux 7fbff432f002 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 41cbc17
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-170/4/artifact/out/diff-checkstyle-tez-runtime-library.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-170/4/testReport/
Max. process+thread count2089 (vs. ulimit of 5500)
modulesC: tez-api tez-runtime-internals tez-runtime-library tez-mapreduce tez-tests U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-170/4/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 6 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep4m 41sMaven dependency ordering for branch
+1 💚mvninstall9m 8smaster passed
+1 💚compile2m 44smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚compile2m 41smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle2m 33smaster passed
+1 💚javadoc2m 48smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc2m 27smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗spotbugs0m 46sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 37smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall1m 33sthe patch passed
+1 💚compile1m 36sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javac1m 36sthe patch passed
+1 💚compile1m 28sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac1m 28sthe patch passed
+1 💚checkstyle0m 12sThe patch passed checkstyle in tez-api
+1 💚checkstyle0m 10sThe patch passed checkstyle in tez-runtime-internals
-0 ⚠️checkstyle0m 21stez-runtime-library: The patch generated 4 new + 274 unchanged - 4 fixed = 278 total (was 278)
+1 💚checkstyle0m 12sThe patch passed checkstyle in tez-mapreduce
+1 💚checkstyle0m 12stez-tests: The patch generated 0 new + 39 unchanged - 1 fixed = 39 total (was 40)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc1m 29sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc1m 19sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚findbugs3m 49sthe patch passed
_ Other Tests _
+1 💚unit2m 1stez-api in the patch passed.
+1 💚unit0m 35stez-runtime-internals in the patch passed.
+1 💚unit4m 28stez-runtime-library in the patch passed.
+1 💚unit1m 13stez-mapreduce in the patch passed.
+1 💚unit48m 26stez-tests in the patch passed.
+1 💚asflicense0m 58sThe patch does not generate ASF License warnings.
104m 35s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-170/5/artifact/out/Dockerfile
GITHUB PR#170
JIRA IssueTEZ-4340
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux 0607e7c8856b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 41cbc17
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-170/5/artifact/out/diff-checkstyle-tez-runtime-library.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-170/5/testReport/
Max. process+thread count1362 (vs. ulimit of 5500)
modulesC: tez-api tez-runtime-internals tez-runtime-library tez-mapreduce tez-tests U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-170/5/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdogabstractdog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@csjuhasz-c@tez-yetus@abstractdog