Skip to content

TEZ-4399: ShuffleHandler fails with SSLHandshakeException not found when SSL is enabled - #196

Merged
abstractdog merged 1 commit into
apache:masterfrom
himanshu-mishra:master
Apr 1, 2022
Merged

TEZ-4399: ShuffleHandler fails with SSLHandshakeException not found when SSL is enabled#196
abstractdog merged 1 commit into
apache:masterfrom
himanshu-mishra:master

Conversation

@himanshu-mishra

Copy link
Copy Markdown
Contributor

Shuffle handler fails with ClassNotFound org.apache.tez.shaded.javax.net.ssl.SSLHandshakeException
when SSL is enabled. Excluding shading of javax.net.** from
tez-aux-services uber jar.

DagDeleteTracker is hardcoded to generate URL with http. Fixing it to
use https when SSL config is enabled.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec18m 14sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep5m 7sMaven dependency ordering for branch
+1 💚mvninstall9m 40smaster passed
+1 💚compile1m 4smaster passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚compile0m 58smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle1m 3smaster passed
+1 💚javadoc1m 6smaster passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚javadoc0m 50smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗spotbugs0m 39sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs2m 14smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 8sMaven dependency ordering for patch
+1 💚mvninstall0m 51sthe patch passed
+1 💚compile0m 47sthe patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚javac0m 47sthe patch passed
+1 💚compile0m 40sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac0m 40sthe patch passed
+1 💚checkstyle0m 26sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚javadoc0m 35sthe patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚javadoc0m 32sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚findbugs1m 49sthe patch passed
_ Other Tests _
+1 💚unit4m 22stez-dag in the patch passed.
+1 💚unit2m 37stez-aux-services in the patch passed.
+1 💚asflicense0m 21sThe patch does not generate ASF License warnings.
54m 28s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-196/1/artifact/out/Dockerfile
GITHUB PR#196
JIRA IssueTEZ-4399
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile xml
unameLinux 693939c7dc70 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / f724c54
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-196/1/testReport/
Max. process+thread count1402 (vs. ulimit of 5500)
modulesC: tez-dag tez-plugins/tez-aux-services U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-196/1/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…hen SSL is enabled
Shuffle handler fails with ClassNotFound org.apache.tez.shaded.javax.net.ssl.SSLHandshakeException
when SSL is enabled. Excluding shading of javax.net.** from
tez-aux-services uber jar.
Few places have hardcoded ssl parameter to generate URL with http.
Fixing them to use https when SSL config is enabled.
Respect SSL config in Vertex and TaskAttempt runnables
@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 4sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep4m 56sMaven dependency ordering for branch
+1 💚mvninstall9m 37smaster passed
+1 💚compile1m 6smaster passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚compile0m 59smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle1m 3smaster passed
+1 💚javadoc1m 4smaster passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc0m 50smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗spotbugs0m 39sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs2m 13smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall0m 51sthe patch passed
+1 💚compile0m 47sthe patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚javac0m 47sthe patch passed
+1 💚compile0m 39sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac0m 39sthe patch passed
+1 💚checkstyle0m 26sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚javadoc0m 36sthe patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc0m 33sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚findbugs1m 50sthe patch passed
_ Other Tests _
+1 💚unit4m 20stez-dag in the patch passed.
+1 💚unit2m 39stez-aux-services in the patch passed.
+1 💚asflicense0m 20sThe patch does not generate ASF License warnings.
37m 7s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-196/2/artifact/out/Dockerfile
GITHUB PR#196
JIRA IssueTEZ-4399
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile xml
unameLinux a641f0ea6a00 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / f724c54
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-196/2/testReport/
Max. process+thread count1415 (vs. ulimit of 5500)
modulesC: tez-dag tez-plugins/tez-aux-services U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-196/2/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
abstractdog self-requested a review March 30, 2022 16:03
@himanshu-mishra

Copy link
Copy Markdown
ContributorAuthor

Thanks @abstractdog for the review and approval. Could you please merge the PR ?

@abstractdog
abstractdog merged commit 3e452e9 into apache:masterApr 1, 2022
@abstractdog

Copy link
Copy Markdown
Contributor

merged to master, thanks @himanshu-mishra for the patch!

asfgit pushed a commit that referenced this pull request Apr 1, 2022
…hen SSL is enabled (#196) (Himanshu Mishra reviewed by Laszlo Bodor)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@himanshu-mishra@tez-yetus@abstractdog