Skip to content

TEZ-4381: Speed up TestSecureShuffle - #180

Merged
abstractdog merged 1 commit into
apache:masterfrom
mark-bathori:TEZ-4381
Jan 30, 2022
Merged

TEZ-4381: Speed up TestSecureShuffle#180
abstractdog merged 1 commit into
apache:masterfrom
mark-bathori:TEZ-4381

Conversation

@mark-bathori

Copy link
Copy Markdown
Contributor

I've changed the recommended TEZ_AM_TASK_MAX_FAILED_ATTEMPTS configuration value and made some test run to see the run times. The default value for maximum failed attempts per task was 4 so I did 4 different run for each test where I reduced the config value by 1 in each run.

[sslInCluster:true, resultWithTezSSL:0, resultWithoutTezSSL:1, asyncHttp:false, taskMaxFailed:4]1min 25sec
[sslInCluster:true, resultWithTezSSL:0, resultWithoutTezSSL:1, asyncHttp:false, taskMaxFailed:3]1min 0sec
[sslInCluster:true, resultWithTezSSL:0, resultWithoutTezSSL:1, asyncHttp:false, taskMaxFailed:2]48sec 655ms
[sslInCluster:true, resultWithTezSSL:0, resultWithoutTezSSL:1, asyncHttp:false, taskMaxFailed:1]53sec 320ms

[sslInCluster:true, resultWithTezSSL:0, resultWithoutTezSSL:1, asyncHttp:true, taskMaxFailed:4]7min 59sec
[sslInCluster:true, resultWithTezSSL:0, resultWithoutTezSSL:1, asyncHttp:true, taskMaxFailed:3]5min 55sec
[sslInCluster:true, resultWithTezSSL:0, resultWithoutTezSSL:1, asyncHttp:true, taskMaxFailed:2]3min 47sec
[sslInCluster:true, resultWithTezSSL:0, resultWithoutTezSSL:1, asyncHttp:true, taskMaxFailed:1]1min 41sec

[sslInCluster:false, resultWithTezSSL:1, resultWithoutTezSSL:0, asyncHttp:true, taskMaxFailed:4]51sec 613ms
[sslInCluster:false, resultWithTezSSL:1, resultWithoutTezSSL:0, asyncHttp:true, taskMaxFailed:3]44sec 417ms
[sslInCluster:false, resultWithTezSSL:1, resultWithoutTezSSL:0, asyncHttp:true, taskMaxFailed:2]41sec 378ms
[sslInCluster:false, resultWithTezSSL:1, resultWithoutTezSSL:0, asyncHttp:true, taskMaxFailed:1]39sec 172ms

[sslInCluster:false, resultWithTezSSL:1, resultWithoutTezSSL:0, asyncHttp:false, taskMaxFailed:4]51sec 87ms
[sslInCluster:false, resultWithTezSSL:1, resultWithoutTezSSL:0, asyncHttp:false, taskMaxFailed:3]47sec 374ms
[sslInCluster:false, resultWithTezSSL:1, resultWithoutTezSSL:0, asyncHttp:false, taskMaxFailed:2]55sec 452ms
[sslInCluster:false, resultWithTezSSL:1, resultWithoutTezSSL:0, asyncHttp:false, taskMaxFailed:1]39sec 101ms

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 9sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall13m 36smaster passed
+1 💚compile0m 29smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚compile0m 27smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle0m 54smaster passed
+1 💚javadoc0m 35smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc0m 22smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗spotbugs1m 7sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs1m 4smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 19sthe patch passed
+1 💚compile0m 20sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javac0m 20sthe patch passed
+1 💚compile0m 17sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac0m 17sthe patch passed
+1 💚checkstyle0m 10sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 14sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc0m 12sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚findbugs0m 40sthe patch passed
_ Other Tests _
+1 💚unit34m 41stez-tests in the patch passed.
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
56m 31s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-180/1/artifact/out/Dockerfile
GITHUB PR#180
JIRA IssueTEZ-4381
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux 2687692243b1 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 4e3eb95
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-180/1/testReport/
Max. process+thread count1151 (vs. ulimit of 5500)
modulesC: tez-tests U: tez-tests
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-180/1/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
abstractdog self-requested a review January 29, 2022 20:21
@abstractdog

Copy link
Copy Markdown
Contributor

double-check full unit test
before: [INFO] Total time: 10:53 min (Wall Clock)
after: [INFO] Total time: 03:47 min (Wall Clock)

merging this, thanks @mbathori-cloudera for the patch and testing

@abstractdog
abstractdog merged commit 6d7ef20 into apache:masterJan 30, 2022
asfgit pushed a commit that referenced this pull request Jan 30, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mark-bathori@tez-yetus@abstractdog