Skip to content

TEZ-4403: Upgrade SLF4J Version To 1.7.36 - #198

Merged
abstractdog merged 1 commit into
apache:masterfrom
shameersss1:TEZ-4403
Apr 30, 2022
Merged

TEZ-4403: Upgrade SLF4J Version To 1.7.36#198
abstractdog merged 1 commit into
apache:masterfrom
shameersss1:TEZ-4403

Conversation

@shameersss1

@shameersss1shameersss1 commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

@tez-yetus

This comment was marked as outdated.

@shameersss1

Copy link
Copy Markdown
ContributorAuthor

@abstractdog Could you please review the changes?

@shameersss1

Copy link
Copy Markdown
ContributorAuthor

@abstractdog Can you please review the changes?

@abstractdog

Copy link
Copy Markdown
Contributor

thanks for taking care of this @shameersss1!
as far as I can see, there is already 1.7.36, would you consider upgrading to that? it's told to fix log4j issues by pulling in reload4j
https://www.slf4j.org/news.html
let me know if it makes sense

@shameersss1shameersss1 changed the title TEZ-4403: Upgrade SLF4J Version To 1.7.34TEZ-4403: Upgrade SLF4J Version To 1.7.36Apr 25, 2022
@tez-yetus

This comment was marked as outdated.

@shameersss1

Copy link
Copy Markdown
ContributorAuthor

@abstractdog - i have upgraded the version to 1.7.36 and re-triggered the pre-commit

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 59sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall15m 48smaster passed
+1 💚compile2m 33smaster passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚compile2m 18smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javadoc2m 36smaster passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚javadoc1m 50smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
_ Patch Compile Tests _
+1 💚mvninstall4m 49sthe patch passed
+1 💚compile3m 2sthe patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚javac3m 2sthe patch passed
+1 💚compile2m 48sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac2m 48sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚javadoc2m 46sthe patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚javadoc2m 4sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
_ Other Tests _
+1 💚unit66m 25sroot in the patch passed.
+1 💚asflicense0m 46sThe patch does not generate ASF License warnings.
109m 52s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-198/3/artifact/out/Dockerfile
GITHUB PR#198
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux 2320942233e3 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 2a9495a
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-198/3/testReport/
Max. process+thread count1373 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-198/3/console
versionsgit=2.25.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
abstractdog self-requested a review April 30, 2022 08:05
@abstractdog
abstractdog merged commit 4d1a860 into apache:masterApr 30, 2022
asfgit pushed a commit that referenced this pull request Apr 30, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@shameersss1@tez-yetus@abstractdog