Skip to content

TEZ-4405: Replace log4j 1.x with reload4j - #200

Merged
abstractdog merged 1 commit into
apache:masterfrom
dmmkr:TEZ-4405
May 2, 2022
Merged

TEZ-4405: Replace log4j 1.x with reload4j#200
abstractdog merged 1 commit into
apache:masterfrom
dmmkr:TEZ-4405

Conversation

@dmmkr

Copy link
Copy Markdown
Contributor

No description provided.

@dmmkr

Copy link
Copy Markdown
ContributorAuthor

@abstractdog Could you please review the changes?

@abstractdog

Copy link
Copy Markdown
Contributor

thanks for reporting and fixing this @dmmkr
there is TEZ-4403 already in progress, let's wait if it takes care of this too, see my comment there: #198 (comment)

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec16m 44sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep6m 31sMaven dependency ordering for branch
+1 💚mvninstall10m 25smaster passed
+1 💚compile5m 5smaster passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚compile4m 41smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javadoc4m 42smaster passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javadoc3m 58smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall5m 43sthe patch passed
+1 💚compile5m 5sthe patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javac5m 5sthe patch passed
+1 💚compile4m 43sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac4m 43sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 6sThe patch has no ill-formed XML file.
+1 💚javadoc4m 29sthe patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javadoc3m 57sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
_ Other Tests _
+1 💚unit0m 51stez-common in the patch passed.
+1 💚unit0m 52stez-runtime-internals in the patch passed.
+1 💚unit4m 24stez-ext-service-tests in the patch passed.
+1 💚unit2m 58stez-aux-services in the patch passed.
+1 💚unit69m 25sroot in the patch passed.
+1 💚asflicense2m 58sThe patch does not generate ASF License warnings.
159m 28s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-200/2/artifact/out/Dockerfile
GITHUB PR#200
JIRA IssueTEZ-4405
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux 1a0e677a3f9e 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 4d1a860
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-200/2/testReport/
Max. process+thread count1393 (vs. ulimit of 5500)
modulesC: tez-common tez-runtime-internals tez-ext-service-tests tez-plugins/tez-aux-services . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-200/2/console
versionsgit=2.25.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
abstractdog self-requested a review May 2, 2022 06:39
@abstractdog
abstractdog merged commit 75876fc into apache:masterMay 2, 2022
asfgit pushed a commit that referenced this pull request May 2, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dmmkr@abstractdog@tez-yetus