Skip to content

TEZ-4613: Remove unused StringBuilder in DAGImpl - #400

Merged
abstractdog merged 2 commits into
apache:masterfrom
dk2k:dk_remove_stringbuilder
Jan 22, 2026
Merged

TEZ-4613: Remove unused StringBuilder in DAGImpl#400
abstractdog merged 2 commits into
apache:masterfrom
dk2k:dk_remove_stringbuilder

Conversation

@dk2k

@dk2kdk2k commented Mar 31, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@tez-yetus

This comment was marked as outdated.

readLock.lock();
try {
StringBuilder diagsb = new StringBuilder();
/*StringBuilder diagsb = new StringBuilder();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's not needed, please remove instead of commenting out

@dk2kdk2k changed the title [optimization] commented out unused stringbuilderTEZ-4613 [optimization] commented out unused stringbuilderMar 31, 2025
@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 10sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 1sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall9m 36smaster passed
+1 💚compile0m 26smaster passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚compile0m 21smaster passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚checkstyle0m 50smaster passed
+1 💚javadoc0m 21smaster passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚javadoc0m 12smaster passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+0 🆗spotbugs1m 5sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs1m 4smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 18sthe patch passed
+1 💚compile0m 18sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚javac0m 18sthe patch passed
+1 💚compile0m 16sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚javac0m 16sthe patch passed
+1 💚checkstyle0m 13sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 7sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚javadoc0m 7sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚findbugs0m 49sthe patch passed
_ Other Tests _
+1 💚unit4m 17stez-dag in the patch passed.
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
20m 16s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-400/2/artifact/out/Dockerfile
GITHUB PR#400
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux d5280d15e73a 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / c34ec16
Default JavaPrivate Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-400/2/testReport/
Max. process+thread count249 (vs. ulimit of 5500)
modulesC: tez-dag U: tez-dag
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-400/2/console
versionsgit=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ayushtknayushtkn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayushtknayushtkn changed the title TEZ-4613 [optimization] commented out unused stringbuilderTEZ-4613: Remove unused StringBuilder in DAGImplMar 31, 2025
@abstractdog
abstractdog merged commit 9ec09ad into apache:masterJan 22, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dk2k@tez-yetus@abstractdog@ayushtkn