Skip to content

TEZ-4323: Jetty jars were removed from dist package with TEZ-4114 - #140

Merged
abstractdog merged 1 commit into
apache:masterfrom
tasanuma:TEZ-4323
Aug 19, 2021
Merged

TEZ-4323: Jetty jars were removed from dist package with TEZ-4114#140
abstractdog merged 1 commit into
apache:masterfrom
tasanuma:TEZ-4323

Conversation

@tasanuma

Copy link
Copy Markdown
Member

No description provided.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec16m 18sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall12m 42smaster passed
+1 💚compile2m 17smaster passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚compile2m 2smaster passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚javadoc2m 17smaster passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc1m 37smaster passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
_ Patch Compile Tests _
+1 💚mvninstall4m 3sthe patch passed
+1 💚compile2m 16sthe patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javac2m 16sthe patch passed
+1 💚compile2m 5sthe patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚javac2m 5sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚javadoc1m 58sthe patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc1m 35sthe patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
_ Other Tests _
+1 💚unit71m 36sroot in the patch passed.
+1 💚asflicense0m 32sThe patch does not generate ASF License warnings.
122m 18s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-140/1/artifact/out/Dockerfile
GITHUB PR#140
JIRA IssueTEZ-4323
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux 4cc28be894d9 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 464d86d
Default JavaPrivate Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-140/1/testReport/
Max. process+thread count2010 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-140/1/console
versionsgit=2.25.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

+1. Looks good. Is there anything else to do with this jira before it is merged?

@tasanuma

Copy link
Copy Markdown
MemberAuthor

I confirmed that the version of the generated jetty jars is the same of hadoop's jetty version.

# jetty version in Hadoop-3.2.2 is 9.4.20.v20190813
$ mvn clean package -DskipTests -Dmaven.javadoc.skip=true
...
find tez-dist/target | grep jetty
tez-dist/target/tez-0.10.2-SNAPSHOT/lib/jetty-io-9.4.20.v20190813.jar
tez-dist/target/tez-0.10.2-SNAPSHOT/lib/jetty-util-9.4.20.v20190813.jar
tez-dist/target/tez-0.10.2-SNAPSHOT/lib/jetty-server-9.4.20.v20190813.jar
tez-dist/target/tez-0.10.2-SNAPSHOT/lib/jetty-webapp-9.4.20.v20190813.jar
tez-dist/target/tez-0.10.2-SNAPSHOT/lib/jetty-http-9.4.20.v20190813.jar
tez-dist/target/tez-0.10.2-SNAPSHOT/lib/jetty-xml-9.4.20.v20190813.jar
tez-dist/target/tez-0.10.2-SNAPSHOT/lib/jetty-security-9.4.20.v20190813.jar
tez-dist/target/tez-0.10.2-SNAPSHOT/lib/jetty-servlet-9.4.20.v20190813.jar
# jetty version in Hadoop-3.3.1 is 9.4.40.v20210413
$ mvn clean package -Dhadoop.version=3.3.1 -DskipTests -Dmaven.javadoc.skip=true
...
find tez-dist/target | grep jetty
tez-dist/target/tez-0.10.2-SNAPSHOT/lib/jetty-util-ajax-9.4.40.v20210413.jar
tez-dist/target/tez-0.10.2-SNAPSHOT/lib/jetty-webapp-9.4.40.v20210413.jar
tez-dist/target/tez-0.10.2-SNAPSHOT/lib/jetty-io-9.4.40.v20210413.jar
tez-dist/target/tez-0.10.2-SNAPSHOT/lib/jetty-server-9.4.40.v20210413.jar
tez-dist/target/tez-0.10.2-SNAPSHOT/lib/jetty-util-9.4.40.v20210413.jar
tez-dist/target/tez-0.10.2-SNAPSHOT/lib/jetty-servlet-9.4.40.v20210413.jar
tez-dist/target/tez-0.10.2-SNAPSHOT/lib/jetty-http-9.4.40.v20210413.jar
tez-dist/target/tez-0.10.2-SNAPSHOT/lib/jetty-client-9.4.40.v20210413.jar
tez-dist/target/tez-0.10.2-SNAPSHOT/lib/jetty-xml-9.4.40.v20210413.jar
tez-dist/target/tez-0.10.2-SNAPSHOT/lib/jetty-security-9.4.40.v20210413.jar

@tasanuma

Copy link
Copy Markdown
MemberAuthor

@abstractdog Could you review this PR?

@abstractdog
abstractdog merged commit 8c97365 into apache:masterAug 19, 2021
@abstractdog

Copy link
Copy Markdown
Contributor

looks good, merged to master
thanks @tasanuma for the patch!

@tasanuma

Copy link
Copy Markdown
MemberAuthor

Thanks for your review!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tasanuma@hadoop-yetus@tez-yetus@abstractdog