Skip to content

TEZ-4618: JDK17: adding profile for jdk17 builds - #404

Closed
maheshrajus wants to merge 1 commit into
apache:masterfrom
maheshrajus:TEZ-4618
Closed

TEZ-4618: JDK17: adding profile for jdk17 builds#404
maheshrajus wants to merge 1 commit into
apache:masterfrom
maheshrajus:TEZ-4618

Conversation

@maheshrajus

Copy link
Copy Markdown
Contributor

adding profile for jdk17 builds

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec13m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 ❌mvninstall7m 30sroot in master failed.
-1 ❌compile0m 39sroot in master failed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04.
+1 💚compile1m 30smaster passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚javadoc1m 3smaster passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚javadoc0m 46smaster passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
_ Patch Compile Tests _
+1 💚mvninstall2m 58sthe patch passed
+1 💚compile1m 23sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚javac1m 23sthe patch passed
+1 💚compile1m 13sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚javac1m 13sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚javadoc0m 45sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚javadoc0m 45sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
_ Other Tests _
+1 💚unit64m 23sroot in the patch passed.
+1 💚asflicense0m 27sThe patch does not generate ASF License warnings.
97m 45s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-404/1/artifact/out/Dockerfile
GITHUB PR#404
JIRA IssueTEZ-4618
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux 8fb7e2d9d991 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 7c24f25
Default JavaPrivate Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
mvninstallhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-404/1/artifact/out/branch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-404/1/artifact/out/branch-compile-root-jdkUbuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-404/1/testReport/
Max. process+thread count1556 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-404/1/console
versionsgit=2.34.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Comment threadpom.xml
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>--add-opens java.base/java.lang=ALL-UNNAMED</argLine>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argLine should also contain the -Xmx1024m -XX:+HeapDumpOnOutOfMemoryError, otherwise it will get overwritten. This can be confirmend by running test in debug mode. Rest of the configuration, evn and sytem properties are carried forward to java17 profile from the initial maven surefire plugin

mvn test -Dtest="org.apache.tez.dag.history.recovery.TestRecoveryService#testRecoveryFlushOnSummaryEvent" -X | grep "argLine"

@maheshrajus

Copy link
Copy Markdown
ContributorAuthor

Raised PR.
#405

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@maheshrajus@tez-yetus@Aggarwal-Raghav