Uh oh!
There was an error while loading. Please reload this page.
TEZ-4711: Normalize ASF license header - #488
Conversation
tez-yetus
commented
Apr 21, 2026
💔 -1 overall
This message was automatically generated. |
tez-yetus
commented
May 1, 2026
💔 -1 overall
This message was automatically generated. |
this makes pretty much sense to me, I quite often find myself simply copy the header from an already existing file, so from now on, I'll copy the correct one :) the precommit test is crucial this time even if only comments were changed, because we need to make sure that our checkstyle/spotbugs/etc. think the same about "correct formatting" as us |
tez-yetus
commented
May 2, 2026
(!) A patch to the testing environment has been detected. |
tez-yetus
commented
May 2, 2026
💔 -1 overall
This message was automatically generated. |
tez-yetus
commented
May 2, 2026
(!) A patch to the testing environment has been detected. |
timeout happened in |
tez-yetus
commented
May 2, 2026
💔 -1 overall
This message was automatically generated. |
tez-yetus
commented
May 2, 2026
(!) A patch to the testing environment has been detected. |
tez-yetus
commented
May 2, 2026
💔 -1 overall
This message was automatically generated. |
tez-yetus
commented
May 2, 2026
(!) A patch to the testing environment has been detected. |
tez-yetus
commented
May 2, 2026
💔 -1 overall
This message was automatically generated. |
tez-yetus
commented
May 2, 2026
💔 -1 overall
This message was automatically generated. |
Same error I'm getting locally as well when building docker image. Maybe with latest change in go repo can you please apply the workaround @abstractdog ? I'm not sure where this go is used anyway? I'm thinking of optimizing this dockerfile |
tez-yetus
commented
May 12, 2026
💔 -1 overall
This message was automatically generated. |
Aggarwal-Raghav
commented
May 13, 2026
@abstractdog , whenever you have time can you please trigger that workaround one more time? |
tez-yetus
commented
May 17, 2026
(!) A patch to the testing environment has been detected. |
abstractdog
commented
May 17, 2026
replayed as |
This comment was marked as outdated.
This comment was marked as outdated.
Aggarwal-Raghav
commented
May 17, 2026
Thanks for triggering it. The reason why the failures are appearing because I have addressed it in #498 |
Aggarwal-Raghav
commented
May 17, 2026
Also all these prev failure that's because of rebase issue is yetus behaviour of checking out PR then master branch and then re-applying the commit. This behaviour is also fixed in #498 by using ![]() |
abstractdog
commented
May 17, 2026
@Aggarwal-Raghav : shall we go for #498 first and then come back for this one? |
Aggarwal-Raghav
commented
May 17, 2026
makes sense |
tez-yetus
commented
May 20, 2026
(!) A patch to the testing environment has been detected. |
This comment was marked as outdated.
This comment was marked as outdated.
Aggarwal-Raghav
commented
May 20, 2026
Forgot to fix the -Ptools profile license header 😔 |
tez-yetus
commented
May 20, 2026
(!) A patch to the testing environment has been detected. |
This comment was marked as outdated.
This comment was marked as outdated.
Will take a look at afterwards, the |
abstractdog
commented
May 21, 2026
|
tez-yetus
commented
May 21, 2026
(!) A patch to the testing environment has been detected. |
This comment was marked as outdated.
This comment was marked as outdated.
Aggarwal-Raghav
commented
May 21, 2026
tez-yetus
commented
May 25, 2026
(!) A patch to the testing environment has been detected. |
This comment was marked as outdated.
This comment was marked as outdated.
tez-yetus
commented
May 25, 2026
(!) A patch to the testing environment has been detected. |
tez-yetus
commented
May 25, 2026
(!) A patch to the testing environment has been detected. |
tez-yetus
commented
May 25, 2026
(!) A patch to the testing environment has been detected. |
tez-yetus
commented
May 25, 2026
🎊 +1 overall
This message was automatically generated. |
Aggarwal-Raghav
commented
May 25, 2026
The PR is ready @abstractdog |
There was a problem hiding this comment.
.mvn directory is required for the project.root variable in parent pom.xml to resolve the root direcotry path correctly. In spotbugs and javadoc it is doing cd tez-api; mvn test-compile javadoc:javadoc and the dev-support directory path was not concatenated correctly.
To ensure github clock the empty directory, i kept a dummy empty file .keep in .mvn direcotry.
Uh oh!
There was an error while loading. Please reload this page.





For yml, sh and dockerfile have manually fixed them. becuase of delimiters and comments in files, there is no generic regex for them.
Maybe this can help: https://github.com/geruh/incubator-xtable/blob/7c7b54b3870791578b4689b29cf8794866eefa52/pom.xml#L542-L633 but it will still require manual intervention at first