Skip to content

TEZ-4711: Normalize ASF license header - #488

Merged
abstractdog merged 1 commit into
apache:masterfrom
Aggarwal-Raghav:TEZ-4711
May 26, 2026
Merged

TEZ-4711: Normalize ASF license header#488
abstractdog merged 1 commit into
apache:masterfrom
Aggarwal-Raghav:TEZ-4711

Conversation

@Aggarwal-Raghav

@Aggarwal-RaghavAggarwal-Raghav commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

For yml, sh and dockerfile have manually fixed them. becuase of delimiters and comments in files, there is no generic regex for them.
Maybe this can help: https://github.com/geruh/incubator-xtable/blob/7c7b54b3870791578b4689b29cf8794866eefa52/pom.xml#L542-L633 but it will still require manual intervention at first

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 7s#488 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/1/console
versionsgit=2.34.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 6s#488 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/2/console
versionsgit=2.34.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog

abstractdog commented May 2, 2026

Copy link
Copy Markdown
Contributor

this makes pretty much sense to me, I quite often find myself simply copy the header from an already existing file, so from now on, I'll copy the correct one :)
let me replay the last test job with a workaround to apply large patches (#423 (comment))
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/3/

the precommit test is crucial this time even if only comments were changed, because we need to make sure that our checkstyle/spotbugs/etc. think the same about "correct formatting" as us

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/3/console in case of problems.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌docker3m 7sDocker failed to build run-specific yetus/tez:tp-20616}.
SubsystemReport/Notes
GITHUB PR#488
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/3/console
versionsgit=2.34.1
Powered byApache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/4/console in case of problems.

@abstractdog

abstractdog commented May 2, 2026

Copy link
Copy Markdown
Contributor

this makes pretty much sense to me, I quite often find myself simply copy the header from an already existing file, so from now on, I'll copy the correct one :) let me replay the last test job with a workaround to apply large patches (#423 (comment)) https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/3/

the precommit test is crucial even if only comments were changed, because we need to make sure that our checkstyle/spotbugs/etc. think the same about "correct formatting" as us

timeout happened in
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/3
rerunning as
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/4

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌docker2m 13sDocker failed to build run-specific yetus/tez:tp-20678}.
SubsystemReport/Notes
GITHUB PR#488
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/4/console
versionsgit=2.34.1
Powered byApache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/5/console in case of problems.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌docker2m 12sDocker failed to build run-specific yetus/tez:tp-29023}.
SubsystemReport/Notes
GITHUB PR#488
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/5/console
versionsgit=2.34.1
Powered byApache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/6/console in case of problems.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌docker2m 12sDocker failed to build run-specific yetus/tez:tp-10271}.
SubsystemReport/Notes
GITHUB PR#488
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/6/console
versionsgit=2.34.1
Powered byApache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 6s#488 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/7/console
versionsgit=2.34.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@Aggarwal-Raghav

Aggarwal-Raghav commented May 2, 2026

Copy link
Copy Markdown
ContributorAuthor

Same error I'm getting locally as well when building docker image.
Screenshot 2026-05-03 at 12 00 12 AM

Maybe with latest change in go repo can you please apply the workaround @abstractdog ? I'm not sure where this go is used anyway? I'm thinking of optimizing this dockerfile

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 8s#488 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/8/console
versionsgit=2.34.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

@abstractdog , whenever you have time can you please trigger that workaround one more time?

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/9/console in case of problems.

@abstractdog

Copy link
Copy Markdown
Contributor

(!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/9/console in case of problems.

replayed as
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/9
🤞

@tez-yetus

This comment was marked as outdated.

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

Thanks for triggering it. The reason why the failures are appearing because dev-support is excluded in jenkinsflile because of this flag:
YETUS_ARGS+=("--skip-dirs=dev-support")

[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:3.1.0:check (spotless-check) on project tez-runtime-internals: Execution spotless-check of goal com.diffplug.spotless:spotless-maven-plugin:3.1.0:check failed: Unable to locate file with path: /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-488/src/tez-runtime-internals/dev-support/spotless/license.java: Could not find resource '/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-488/src/tez-runtime-internals/dev-support/spotless/license.java'. -> [Help 1]
[ERROR] 

I have addressed it in #498

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

Also all these prev failure that's because of rebase issue is yetus behaviour of checking out PR then master branch and then re-applying the commit. This behaviour is also fixed in #498 by using

 cd "${WORKSPACE}/${SOURCEDIR}"
# Ensure origin/master is available for diffing
git fetch origin master || true
git diff origin/master...HEAD > "${WORKSPACE}/${PATCHDIR}/local-pr.patch"
cd "${WORKSPACE}"
Screenshot 2026-05-17 at 2 07 14 PM

@abstractdog

Copy link
Copy Markdown
Contributor

@Aggarwal-Raghav : shall we go for #498 first and then come back for this one?

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

@Aggarwal-Raghav : shall we go for #498 first and then come back for this one?

makes sense

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/10/console in case of problems.

@tez-yetus

This comment was marked as outdated.

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

Forgot to fix the -Ptools profile license header 😔

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/11/console in case of problems.

@tez-yetus

This comment was marked as outdated.

@Aggarwal-Raghav

Aggarwal-Raghav commented May 20, 2026

Copy link
Copy Markdown
ContributorAuthor

Will take a look at afterwards, the project.root is not resolving correctly. Will eval some plugin to do so.
I'll park it for now and once the other priority PR are merged, will pick it up again.
On bright side, this big PR didn't require the manual workaround in CI to run.

Locally the command is passing 🤔
Screenshot 2026-05-20 at 8 39 43 PM

@abstractdog

Copy link
Copy Markdown
Contributor

Will take a look at afterwards, the project.root is not resolving correctly. Will eval some plugin to do so. I'll park it for now and once the other priority PR are merged, will pick it up again. On bright side, this big PR didn't require the manual workaround in CI to run.

Locally the command is passing 🤔 Screenshot 2026-05-20 at 8 39 43 PM

this big PR didn't require the manual workaround in CI to run. <- exactly, already an important step!

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/12/console in case of problems.

@tez-yetus

This comment was marked as outdated.

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

The run was aborted because of infra issue 😓

ERROR: Cannot resume build because FlowNode 35 for FlowHead 1 could not be loaded. This is expected to happen when using the PERFORMANCE_OPTIMIZED durability setting and
Jenkins is not shut down cleanly. Consider investigating to understand if Jenkins was not shut down cleanly or switching to the MAX_SURVIVABILITY durability setting which
should prevent this issue in most cases
Screenshot 2026-05-21 at 10 30 00 PM

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/13/console in case of problems.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/14/console in case of problems.

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/15/console in case of problems.

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/16/console in case of problems.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 12sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 8sNo case conflicting files found.
+0 🆗detsecrets0m 8sdetect-secrets was not available.
+0 🆗shelldocs0m 8sShelldocs was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 280 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
+1 💚mvninstall3m 30smaster passed
+1 💚compile2m 42smaster passed
+1 💚checkstyle10m 22smaster passed
+1 💚javadoc8m 45smaster passed
+0 🆗spotbugs0m 31shadoop-shim in master has 3 extant spotbugs warnings.
+0 🆗spotbugs0m 51stez-api in master has 92 extant spotbugs warnings.
+0 🆗spotbugs0m 16sbranch/tez-build-tools no spotbugs output file (spotbugsXml.xml)
+0 🆗spotbugs0m 33stez-common in master has 13 extant spotbugs warnings.
+0 🆗spotbugs0m 37stez-runtime-internals in master has 92 extant spotbugs warnings.
+0 🆗spotbugs0m 44stez-runtime-library in master has 143 extant spotbugs warnings.
+0 🆗spotbugs0m 37stez-mapreduce in master has 97 extant spotbugs warnings.
+0 🆗spotbugs0m 30stez-examples in master has 2 extant spotbugs warnings.
+0 🆗spotbugs1m 5stez-dag in master has 537 extant spotbugs warnings.
+0 🆗spotbugs0m 34stez-tests in master has 6 extant spotbugs warnings.
+0 🆗spotbugs0m 32sbranch/tez-ui no spotbugs output file (spotbugsXml.xml)
+0 🆗spotbugs1m 6stez-plugins in master has 43 extant spotbugs warnings.
+0 🆗spotbugs0m 28stez-plugins/tez-protobuf-history-plugin in master has 7 extant spotbugs warnings.
+0 🆗spotbugs0m 23stez-plugins/tez-yarn-timeline-history in master has 2 extant spotbugs warnings.
+0 🆗spotbugs0m 22stez-plugins/tez-yarn-timeline-history-with-acls in master has 2 extant spotbugs warnings.
+0 🆗spotbugs0m 23stez-plugins/tez-yarn-timeline-cache-plugin in master has 1 extant spotbugs warnings.
+0 🆗spotbugs0m 27stez-plugins/tez-yarn-timeline-history-with-fs in master has 5 extant spotbugs warnings.
+0 🆗spotbugs0m 28stez-plugins/tez-history-parser in master has 21 extant spotbugs warnings.
+0 🆗spotbugs0m 30stez-plugins/tez-aux-services in master has 5 extant spotbugs warnings.
+0 🆗spotbugs0m 40stez-tools in master has 26 extant spotbugs warnings.
+0 🆗spotbugs0m 25stez-tools/analyzers in master has 20 extant spotbugs warnings.
+0 🆗spotbugs0m 23stez-tools/tez-javadoc-tools in master has 3 extant spotbugs warnings.
+0 🆗spotbugs0m 13sbranch/docs no spotbugs output file (spotbugsXml.xml)
+0 🆗spotbugs3m 54sroot in master has 1054 extant spotbugs warnings.
+0 🆗spotbugs0m 20sbranch/tez-dist no spotbugs output file (spotbugsXml.xml)
+0 🆗spotbugs0m 29stez-tools/analyzers/job-analyzer in master has 20 extant spotbugs warnings.
+0 🆗spotbugs0m 28stez-tools/tez-tfile-parser in master has 3 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall2m 42sthe patch passed
+1 💚codespell1m 1sNo new issues.
+1 💚compile2m 28sthe patch passed
+1 💚javac2m 28sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle0m 12s/results-checkstyle-hadoop-shim.txthadoop-shim: The patch generated 1 new + 11 unchanged - 1 fixed = 12 total (was 12)
-0 ⚠️checkstyle0m 20s/results-checkstyle-tez-common.txttez-common: The patch generated 3 new + 110 unchanged - 3 fixed = 113 total (was 113)
-0 ⚠️checkstyle0m 22s/results-checkstyle-tez-runtime-internals.txttez-runtime-internals: The patch generated 9 new + 353 unchanged - 9 fixed = 362 total (was 362)
-0 ⚠️checkstyle0m 31s/results-checkstyle-tez-runtime-library.txttez-runtime-library: The patch generated 2 new + 1995 unchanged - 2 fixed = 1997 total (was 1997)
-0 ⚠️checkstyle0m 39s/results-checkstyle-tez-dag.txttez-dag: The patch generated 15 new + 3000 unchanged - 15 fixed = 3015 total (was 3015)
-0 ⚠️checkstyle0m 24s/results-checkstyle-tez-tests.txttez-tests: The patch generated 3 new + 1136 unchanged - 3 fixed = 1139 total (was 1139)
-0 ⚠️checkstyle0m 25s/results-checkstyle-tez-plugins.txttez-plugins: The patch generated 10 new + 633 unchanged - 10 fixed = 643 total (was 643)
-0 ⚠️checkstyle0m 16s/results-checkstyle-tez-plugins_tez-protobuf-history-plugin.txttez-plugins/tez-protobuf-history-plugin: The patch generated 1 new + 138 unchanged - 1 fixed = 139 total (was 139)
-0 ⚠️checkstyle0m 21s/results-checkstyle-tez-plugins_tez-yarn-timeline-history-with-acls.txttez-plugins/tez-yarn-timeline-history-with-acls: The patch generated 1 new + 27 unchanged - 1 fixed = 28 total (was 28)
-0 ⚠️checkstyle0m 18s/results-checkstyle-tez-plugins_tez-yarn-timeline-cache-plugin.txttez-plugins/tez-yarn-timeline-cache-plugin: The patch generated 1 new + 20 unchanged - 1 fixed = 21 total (was 21)
-0 ⚠️checkstyle0m 18s/results-checkstyle-tez-plugins_tez-yarn-timeline-history-with-fs.txttez-plugins/tez-yarn-timeline-history-with-fs: The patch generated 2 new + 46 unchanged - 2 fixed = 48 total (was 48)
-0 ⚠️checkstyle0m 20s/results-checkstyle-tez-plugins_tez-history-parser.txttez-plugins/tez-history-parser: The patch generated 4 new + 222 unchanged - 4 fixed = 226 total (was 226)
-0 ⚠️checkstyle0m 17s/results-checkstyle-tez-plugins_tez-aux-services.txttez-plugins/tez-aux-services: The patch generated 1 new + 118 unchanged - 1 fixed = 119 total (was 119)
-0 ⚠️checkstyle0m 18s/results-checkstyle-tez-tools.txttez-tools: The patch generated 3 new + 105 unchanged - 3 fixed = 108 total (was 108)
-0 ⚠️checkstyle0m 20s/results-checkstyle-tez-tools_analyzers.txttez-tools/analyzers: The patch generated 3 new + 101 unchanged - 3 fixed = 104 total (was 104)
-0 ⚠️checkstyle0m 18s/results-checkstyle-tez-tools_analyzers_job-analyzer.txttez-tools/analyzers/job-analyzer: The patch generated 3 new + 101 unchanged - 3 fixed = 104 total (was 104)
-0 ⚠️checkstyle0m 15s/results-checkstyle-hadoop-shim-impls.txthadoop-shim-impls: The patch generated 1 new + 1 unchanged - 1 fixed = 2 total (was 2)
-0 ⚠️checkstyle0m 18s/results-checkstyle-hadoop-shim-impls_hadoop-shim-2.8.txthadoop-shim-impls/hadoop-shim-2.8: The patch generated 1 new + 1 unchanged - 1 fixed = 2 total (was 2)
-0 ⚠️checkstyle1m 23s/results-checkstyle-root.txtroot: The patch generated 47 new + 10189 unchanged - 47 fixed = 10236 total (was 10236)
+1 💚hadolint0m 0sNo new issues.
+1 💚shellcheck0m 0sNo new issues.
+1 💚yamllint0m 2sNo new issues.
+1 💚javadoc9m 41sthe patch passed
+0 🆗spotbugs0m 18stez-build-tools has no data from spotbugs
+0 🆗spotbugs0m 35stez-ui has no data from spotbugs
+0 🆗spotbugs0m 17stez-dist has no data from spotbugs
+0 🆗spotbugs0m 19sdocs has no data from spotbugs
_ Other Tests _
+1 💚unit60m 12sroot in the patch passed.
+1 💚asflicense7m 26sThe patch does not generate ASF License warnings.
172m 14s
SubsystemReport/Notes
DockerClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/16/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense codespell detsecrets hadolint shellcheck shelldocs javac javadoc spotbugs checkstyle xmllint yamllint
unameLinux abb3b1bb4271 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 13:29:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / b6b5d42
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/16/testReport/
Max. process+thread count1442 (vs. ulimit of 5500)
modulesC: hadoop-shim tez-api tez-build-tools tez-common tez-runtime-internals tez-runtime-library tez-mapreduce tez-examples tez-dag tez-tests tez-ext-service-tests tez-ui tez-plugins tez-plugins/tez-protobuf-history-plugin tez-plugins/tez-yarn-timeline-history tez-plugins/tez-yarn-timeline-history-with-acls tez-plugins/tez-yarn-timeline-cache-plugin tez-plugins/tez-yarn-timeline-history-with-fs tez-plugins/tez-history-parser tez-plugins/tez-aux-services tez-tools tez-tools/analyzers tez-tools/analyzers/job-analyzer tez-tools/tez-javadoc-tools hadoop-shim-impls hadoop-shim-impls/hadoop-shim-2.8 tez-dist docs . tez-tools/tez-tfile-parser U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-488/16/console
versionsgit=2.43.0 maven=3.9.15 hadolint=2.14.0 spotbugs=4.9.3 codespell=2.4.1 shellcheck=0.11.0 yamllint=1.38.0
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

The PR is ready @abstractdog

Comment thread.mvn/.keep

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file needed?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.mvn directory is required for the project.root variable in parent pom.xml to resolve the root direcotry path correctly. In spotbugs and javadoc it is doing cd tez-api; mvn test-compile javadoc:javadoc and the dev-support directory path was not concatenated correctly.
To ensure github clock the empty directory, i kept a dummy empty file .keep in .mvn direcotry.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, thanks!

@abstractdog
abstractdog self-requested a review May 26, 2026 09:01
@abstractdog
abstractdog merged commit 330fdc8 into apache:masterMay 26, 2026
4 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Aggarwal-Raghav@tez-yetus@abstractdog