Skip to content

TEZ-4711: [Addendum] Normalize ASF license header in hadoop27 profile - #503

Closed
Aggarwal-Raghav wants to merge 1 commit into
apache:masterfrom
Aggarwal-Raghav:TEZ-4711-add
Closed

TEZ-4711: [Addendum] Normalize ASF license header in hadoop27 profile#503
Aggarwal-Raghav wants to merge 1 commit into
apache:masterfrom
Aggarwal-Raghav:TEZ-4711-add

Conversation

@Aggarwal-Raghav

Copy link
Copy Markdown
Contributor

No description provided.

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

@abstractdog , this was missed in #488 as hadoop27 profile was not activated and found in Junit PR.

</plugins>
</build>

<profiles>

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removal is requied as this was self-reference and a bug mvn spotless:apply -Phadoop27 was not working without this.
Do we need hadoop27 or hadoop28 now in Tez-1.0.0, Can't we drop those module and profile?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, it's time to drop hadoop 2.x support from Tez master

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I close this PR and raise the one where hadoop2.x is removed?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, hadoop2.x removal should have visibility

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed TEZ-4721, keeping this PR open till then.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec4m 5sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 33sMaven dependency ordering for branch
+1 💚mvninstall4m 30smaster passed
+1 💚compile4m 3smaster passed
+1 💚checkstyle0m 53smaster passed
-1 ❌javadoc0m 26s/branch-javadoc-hadoop-shim-impls_hadoop-shim-2.7.txthadoop-shim-2.7 in master failed.
+0 🆗spotbugs0m 48stez-plugins/tez-yarn-timeline-history in master has 2 extant spotbugs warnings.
-1 ❌spotbugs0m 25s/branch-spotbugs-hadoop-shim-impls_hadoop-shim-2.7.txthadoop-shim-2.7 in master failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall3m 36sthe patch passed
+1 💚codespell1m 35sNo new issues.
+1 💚compile3m 59sthe patch passed
+1 💚javac3m 59sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle0m 23s/results-checkstyle-hadoop-shim-impls_hadoop-shim-2.7.txthadoop-shim-impls/hadoop-shim-2.7: The patch generated 1 new + 2 unchanged - 1 fixed = 3 total (was 3)
+1 💚javadoc0m 52sthe patch passed
+1 💚spotbugs1m 45sthe patch passed
_ Other Tests _
+1 💚unit71m 43sroot in the patch passed.
+1 💚asflicense0m 54sThe patch does not generate ASF License warnings.
103m 28s
SubsystemReport/Notes
DockerClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-503/1/artifact/out/Dockerfile
Optional Testsdupname compile unit asflicense javac javadoc codespell detsecrets xmllint spotbugs checkstyle
unameLinux b56281d9f0c3 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 13:29:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitytez-personality.sh
git revisionmaster / 330fdc8
Default JavaEclipse Adoptium-21.0.11+10-LTS
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-503/1/testReport/
Max. process+thread count1449 (vs. ulimit of 5500)
modulesC: tez-plugins/tez-yarn-timeline-history hadoop-shim-impls/hadoop-shim-2.7 U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-503/1/console
versionsgit=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1
Powered byApache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

The javadoc and spotbugs failure in master is expected. They are fixed in patch phase

@Aggarwal-Raghav

Copy link
Copy Markdown
ContributorAuthor

Closing this, will be handled by #505

@Aggarwal-Raghav
Aggarwal-Raghav deleted the TEZ-4711-add branch June 28, 2026 17:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Aggarwal-Raghav@tez-yetus@abstractdog